From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8A5ECAAD3 for ; Mon, 5 Sep 2022 18:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E4BA801F9; Mon, 5 Sep 2022 14:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26D05801E6; Mon, 5 Sep 2022 14:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E797801F9; Mon, 5 Sep 2022 14:20:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ED698801E6 for ; Mon, 5 Sep 2022 14:20:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AAAC5C03B9 for ; Mon, 5 Sep 2022 18:20:23 +0000 (UTC) X-FDA: 79878846726.16.F71F865 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 2E59BC0064 for ; Mon, 5 Sep 2022 18:20:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41317B81113; Mon, 5 Sep 2022 18:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76A42C433D7; Mon, 5 Sep 2022 18:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662402020; bh=v7P6Uw4HRJRP4lWIfQcjoKQy75gM4zEUpDlPO/DPqz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CHC0kzZF/ex5uMQxHHasuue1Hxlvx0zNLHDfvhPxdjZEtkmrsZ9BTrGMP6qC9yK2+ a9r0j8RRkVKNMSTOfc+15y1xhFDC2Y913HuDJhCnihSiLU/Bk/ahw1b0YceOSmTjYX KmEDIQCPKk9heFzQSjJRG1EcXR+1KPZEuaHfA+HonRemofBwJoVYlhTH9TDYwAC6dk jZUYY7cI2WRsehHRV45ROVUSjlfV42c+6lTdg3WgwrCQH7aj5LgYxBLnfYAtn5IUCn tfwaJt8xSTkLiyjCCFjOmffjKxAIgbnBSs9rwhiHcYUvVlAo7L5/eSU6ZIISNPWmNW yqxvy/mQWEHJg== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/sysfs: simplify the judgement whether kdamonds are busy Date: Mon, 5 Sep 2022 18:20:17 +0000 Message-Id: <20220905182017.50625-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1662302166-13216-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662402023; a=rsa-sha256; cv=none; b=UhquQ8AO6pgY/2HdIFjNn3riKA9ukkYv+4O4hIgvgAsT1LcuvfycAd5ahYZWBa/Ye7bjHy YR31pejsuaAzKeqsOEP6Yw+t3PREqVMnElHBY21anMLj1MuP1mPtw0nPKo5hjb13S5EyuH RMdHY/vkgRnKPlEqz/UfUFIwVprrnBo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CHC0kzZF; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662402023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/rySa0ifHvZpBUe+sJu6dwO7LC94E2D/3Py2YYuKFQU=; b=eGa0BGcoa5dq6FWzpZONiYwD2qAA3KtiefZ0G7VR2RmYt3wByAIrJfbQHDNZcH+FvbzNIi VfzSnVBnJ9In57CL6MZU69qADmz+gX0XGjEhKlAZYEFNBVC+S8S15L13wuWLFUCekYrtKs FnlkkyoDuNQszq+kXY0KoCan0s8d3vQ= X-Stat-Signature: 5h76y3djt8qug57ooptknecc8odbftid X-Rspamd-Queue-Id: 2E59BC0064 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CHC0kzZF; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1662402023-95261 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Sun, 4 Sep 2022 22:36:06 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > It is unnecessary to get the number of the running kdamond to judge > whether kdamonds are busy. Here we can use the > damon_sysfs_kdamond_running() helper and return -EBUSY directly > when finding a running kdamond. Meanwhile, merging with the judgement > that a kdamond has current sysfs command callback request to make > the code more clear. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/sysfs.c | 25 +++++++------------------ > 1 file changed, 7 insertions(+), 18 deletions(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..fe6c6870cf86 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2657,23 +2657,18 @@ static void damon_sysfs_kdamonds_rm_dirs(struct damon_sysfs_kdamonds *kdamonds) > kdamonds->kdamonds_arr = NULL; > } > > -static int damon_sysfs_nr_running_ctxs(struct damon_sysfs_kdamond **kdamonds, > +static bool damon_sysfs_kdamonds_busy(struct damon_sysfs_kdamond **kdamonds, > int nr_kdamonds) > { > - int nr_running_ctxs = 0; > int i; > > for (i = 0; i < nr_kdamonds; i++) { > - struct damon_ctx *ctx = kdamonds[i]->damon_ctx; > - > - if (!ctx) > - continue; > - mutex_lock(&ctx->kdamond_lock); > - if (ctx->kdamond) > - nr_running_ctxs++; > - mutex_unlock(&ctx->kdamond_lock); > + if (damon_sysfs_kdamond_running(kdamonds[i]) || > + damon_sysfs_cmd_request.kdamond == kdamonds[i]) > + return true; > } > - return nr_running_ctxs; > + > + return false; > } > > static int damon_sysfs_kdamonds_add_dirs(struct damon_sysfs_kdamonds *kdamonds, > @@ -2682,15 +2677,9 @@ static int damon_sysfs_kdamonds_add_dirs(struct damon_sysfs_kdamonds *kdamonds, > struct damon_sysfs_kdamond **kdamonds_arr, *kdamond; > int err, i; > > - if (damon_sysfs_nr_running_ctxs(kdamonds->kdamonds_arr, kdamonds->nr)) > + if (damon_sysfs_kdamonds_busy(kdamonds->kdamonds_arr, kdamonds->nr)) > return -EBUSY; > > - for (i = 0; i < kdamonds->nr; i++) { > - if (damon_sysfs_cmd_request.kdamond == > - kdamonds->kdamonds_arr[i]) > - return -EBUSY; > - } > - > damon_sysfs_kdamonds_rm_dirs(kdamonds); > if (!nr_kdamonds) > return 0; > -- > 2.27.0 > >