From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A5BBECAAD3 for ; Mon, 5 Sep 2022 14:42:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A818D801E9; Mon, 5 Sep 2022 10:42:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A301E801E6; Mon, 5 Sep 2022 10:42:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F848801E9; Mon, 5 Sep 2022 10:42:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7CC74801E6 for ; Mon, 5 Sep 2022 10:42:36 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 39DF11A02BF for ; Mon, 5 Sep 2022 14:42:36 +0000 (UTC) X-FDA: 79878297912.25.1F94B83 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id D495E140073 for ; Mon, 5 Sep 2022 14:42:35 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 68A1B68D05; Mon, 5 Sep 2022 16:42:29 +0200 (CEST) Date: Mon, 5 Sep 2022 16:42:28 +0200 From: Christoph Hellwig To: Dan Williams Cc: akpm@linux-foundation.org, djwong@kernel.org, Shiyang Ruan , Christoph Hellwig , Al Viro , Dave Chinner , Goldwyn Rodrigues , Jane Chu , Matthew Wilcox , Miaohe Lin , Naoya Horiguchi , Ritesh Harjani , nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/4] xfs: Quiet notify_failure EOPNOTSUPP cases Message-ID: <20220905144228.GA6784@lst.de> References: <166153426798.2758201.15108211981034512993.stgit@dwillia2-xfh.jf.intel.com> <166153427440.2758201.6709480562966161512.stgit@dwillia2-xfh.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166153427440.2758201.6709480562966161512.stgit@dwillia2-xfh.jf.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662388955; a=rsa-sha256; cv=none; b=PrI7FGL1vpjyrW4oiKHOosYCmE6CQcg8xZYr2VcwFRkjJ/kHErfOmHXETtXsa4kPjvN0C+ fXjo0oP57Q5rO+wf4f9mu2W9HjLJj8vGQ+Sj+4ylIxiO7oiLMl+0CudIz23yd01qH/KDpk OFuSocePiozOUiFIHxM02m2DyEd//Hg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662388955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=38jBRE5wtw8TQT2s8CMsOnd7/jBZoEzof2igGhcR+Fg=; b=nhZr5Shv9tHYZWzYrTTFTbYrh+rdZsF+GKr4Dk6fOycG6yUpvhCUMcOr8zYhtPxKmrYP72 c18XmWTWq+373jO+uhsDsu+FmvSigqTBlR53rlilnMPFh2MJgDAFAU4Q5Mln4snFDb18ak BU+evAbtHPrSh3HxrX0vG7kdQL/P8iU= X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D495E140073 X-Stat-Signature: ecrnhimcrqciaizh4e8n7ji9riuk9jjn X-HE-Tag: 1662388955-590713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 10:17:54AM -0700, Dan Williams wrote: > XFS always registers dax_holder_operations regardless of whether the > filesystem is capable of handling the notifications. The expectation is > that if the notify_failure handler cannot run then there are no > scenarios where it needs to run. In other words the expected semantic is > that page->index and page->mapping are valid for memory_failure() when > the conditions that cause -EOPNOTSUPP in xfs_dax_notify_failure() are > present. > > A fallback to the generic memory_failure() path is expected so do not > warn when that happens. Looks good: Reviewed-by: Christoph Hellwig