From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9C0ECAAD3 for ; Sun, 4 Sep 2022 07:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C63880189; Sun, 4 Sep 2022 03:46:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94F608015A; Sun, 4 Sep 2022 03:46:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817C680189; Sun, 4 Sep 2022 03:46:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6E4708015A for ; Sun, 4 Sep 2022 03:46:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 49E4EA0C8D for ; Sun, 4 Sep 2022 07:46:51 +0000 (UTC) X-FDA: 79873621422.08.F35D87D Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf12.hostedemail.com (Postfix) with ESMTP id BC34F40078 for ; Sun, 4 Sep 2022 07:46:50 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id q15-20020a17090a304f00b002002ac83485so2003081pjl.0 for ; Sun, 04 Sep 2022 00:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date; bh=MNCodJQdObDjrnT0Izj/sQ+uO9mQ8GTBinVlGbDhzBg=; b=ltndlkcpAl4jmPWsFREMk9p7wATBSb+I5sr1s7EcJOc1fYxYE0FNr+s6CxN3dfcJq+ w65m3eIvHbRQgHaEfHsCkQrjbq2pMqoeh9LzPCvwWzBm7lPmECkdv3+Gk38aL5JNml8k IvTFF9+YG9UExawUu+55auCNI870adk8PDDRrgQUx/cqGVbl8kqATXEg77Gx3wc2TqG8 nirxyo7o/waKYQabtQlr9gik3sbUZi5jWHBAgyo+SjILRZ4xmDXOdIkSd+n0rNZh1lSN Qb7rbI+9OCZzUeamNn7Js+gmNSSb6Yy4E0lKkh56ONfIJZFrGX7b+wzFnvD1HJn+Mrwb sASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=MNCodJQdObDjrnT0Izj/sQ+uO9mQ8GTBinVlGbDhzBg=; b=fH42H37jjHNFo+j5bz2hRCmMkUNrx71fsoxTAiSwcBuT2Ct4tK42446Pd21V7peRUv eVzKYYtohcogM9idYfPfFHw9oyd3NzMPDv16LdyXwanFX1VP5qjxdx42eoXZCafaJrNS laUGelH6MBJbRwm9+n14W5uj2sBYj2bFrDuM/l76HEXOyLH2SygMWCKvLzrX4GPbJfWB 3cIgW6Fv5ZfaTKeqMpWvweThS2QriL9g2PtmVa2v+Cplop1FhU4Mmwm3CsWScj0HJuWJ Avi1xPfDaVtv2IOvPS3m20s1BvRublTWYX26Pyo1tCVd0jolqzsz7SywcmVFOmJrKWp9 72LA== X-Gm-Message-State: ACgBeo3dO9pSYBNyiko7ekSY3hxVk1KzxplvTMXt2eb+MExQ8L2J5BDY 3PaHYuJpW+9qE9TEYEQ8S3U= X-Google-Smtp-Source: AA6agR41XDk23/RDtx6Hla5UHGEscly4WpsCTJEoYwfuGZWi+BSAHQcmeYfRyCp9G9X9B3PNOBVS8w== X-Received: by 2002:a17:902:ecc6:b0:174:90c5:613b with SMTP id a6-20020a170902ecc600b0017490c5613bmr33591646plh.28.1662277609493; Sun, 04 Sep 2022 00:46:49 -0700 (PDT) Received: from cloud-MacBookPro ([2601:646:8201:c2e0:a34:9c8c:fea7:d064]) by smtp.gmail.com with ESMTPSA id x22-20020a170902821600b0016f057b88c9sm4918559pln.26.2022.09.04.00.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 00:46:48 -0700 (PDT) Date: Sun, 4 Sep 2022 00:46:47 -0700 From: Binyi Han To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mm: fix dereferencing possible ERR_PTR Message-ID: <20220904074647.GA64291@cloud-MacBookPro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662277610; a=rsa-sha256; cv=none; b=NvndD1EMhAjJtMESvGJRHxCjh9/UIStfC0sM/WgOH1osLFeHPZZ1as0lg+9+Z9gA6ihl4U yyGsvP5/FF00NtYhU116aeMfnlUZIvHCrgEyIeMBzakPaeRRzwMC2ogoSNeFKUbi6mJTh2 JSwEjKs1DltQI30hJqiPpaiqDAtBZYc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ltndlkcp; spf=pass (imf12.hostedemail.com: domain of dantengknight@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=dantengknight@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662277610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=MNCodJQdObDjrnT0Izj/sQ+uO9mQ8GTBinVlGbDhzBg=; b=zlRlTfAlQo1Q5sKyKl7QpKvPb+IKmI7MPiUgcjgSTs3fbzjki0uLduuEJhjeFyCYOO9LSa bX0T5otW4frmqzmRNuUd01g5zdXNNt9Rt4oLoPwdhACPb+A3BhWYsq2/Iku1tyCYMmS88N Xm8K+laefSrXGKDLod/e+UbQyRQbBQA= X-Stat-Signature: 7n1izufc6oge8qdpxgou19f75duzdzs7 X-Rspamd-Queue-Id: BC34F40078 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ltndlkcp; spf=pass (imf12.hostedemail.com: domain of dantengknight@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=dantengknight@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1662277610-283099 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Smatch checker complains that 'secretmem_mnt' dereferencing possible ERR_PTR(). Let the function return if 'secretmem_mnt' is ERR_PTR, to avoid deferencing it. Signed-off-by: Binyi Han --- mm/secretmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/secretmem.c b/mm/secretmem.c index e3e9590c6fb3..3f7154099795 100644 --- a/mm/secretmem.c +++ b/mm/secretmem.c @@ -285,7 +285,7 @@ static int secretmem_init(void) secretmem_mnt = kern_mount(&secretmem_fs); if (IS_ERR(secretmem_mnt)) - ret = PTR_ERR(secretmem_mnt); + return PTR_ERR(secretmem_mnt); /* prevent secretmem mappings from ever getting PROT_EXEC */ secretmem_mnt->mnt_flags |= MNT_NOEXEC; -- 2.25.1