From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A1BDECAAD3 for ; Fri, 2 Sep 2022 00:37:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF0118D0011; Thu, 1 Sep 2022 20:37:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B78C48D0001; Thu, 1 Sep 2022 20:37:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A243B8D0011; Thu, 1 Sep 2022 20:37:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B2A98D0001 for ; Thu, 1 Sep 2022 20:37:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 61C52A0B4D for ; Fri, 2 Sep 2022 00:37:06 +0000 (UTC) X-FDA: 79865280852.03.8F5A3B9 Received: from mail-oa1-f67.google.com (mail-oa1-f67.google.com [209.85.160.67]) by imf14.hostedemail.com (Postfix) with ESMTP id 00DF0100042 for ; Fri, 2 Sep 2022 00:37:05 +0000 (UTC) Received: by mail-oa1-f67.google.com with SMTP id 586e51a60fabf-11ba6e79dd1so1221302fac.12 for ; Thu, 01 Sep 2022 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=xM433NCCdFsj/Dus8z982guFSm6mdOX0+AhxRQOZ+mQ=; b=nBlvj7nrHPVVIGNi93HF0NaakZvzGnxIVe7It932X+c4rUd2Jj88O9cFLEMb0aFJgN i3akrSqOsEfHJ/UYxuzE79m0BXm/ppqU5PlUX0FbQOYYyxyMCE/JhHHPYNOcBigzkAK7 aX+T08h2pGs8fpER4RghbnPfpK4Mv6ojIIImZWtxMv+k2qGR4q1CUUqi7JfzefpUHI3A 6qjPoJQXj+WRHXtFQdRd9tTCHsLPoCXBkx6bGA5I8rWfPbpl32/2G6/jlBZieuAdYfjs pNoXeeBxVtMKSvnPpXbYW3tuCpAB8K8BMmqRqAF7umHaQajfdBV7l1v6H9UGn6U+Ye3w sYNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=xM433NCCdFsj/Dus8z982guFSm6mdOX0+AhxRQOZ+mQ=; b=VZNyeLpkJm5QHNhijJ7gsk5jkSkt7pqJMT2cPXYulCsLRfb5URAJsiYI+pbFsyWqW5 1l6J5H0mX2fy3cW7epLb7AHPSodsYr/YwEb+ccrAOeSq1+XE7A7c6X//1WgV6snqivT8 6xnxDgHn7bI/xSKEL/CMoYyInOxOaBcCos1AUJFKr2pd4ZuJYg5p3/Gx4h5r/+nePs11 U9D4P1qrCcsLzTQCNanz+QcCJj0pR18FVRblYS92OkK+ol/AtzZX0x1X4erhHgUnjn6Y qpAwohPgsQqU70KlYvpzog5nm9yZcpj3UdOywjacfqLstgap95LbQwQRo4cwsne9J1CM QOiQ== X-Gm-Message-State: ACgBeo0M/8tXuU14WF/KJkk4t7bs/4lFeJxmicF0tzH/pFZw7ilLhcEC ALq0AfXXcBIGt1bxx5IBD08= X-Google-Smtp-Source: AA6agR4w24tn4ZIX/Y0E/iC+KDhcc4aQLCRBSznfH/pvuxzQ2STSLHaCFjI3AfDLko8i5rU4FnVbhA== X-Received: by 2002:a05:6808:151f:b0:343:2cbe:ad68 with SMTP id u31-20020a056808151f00b003432cbead68mr867716oiw.254.1662079025189; Thu, 01 Sep 2022 17:37:05 -0700 (PDT) Received: from sophie (static-198-54-128-70.cust.tzulo.com. [198.54.128.70]) by smtp.gmail.com with ESMTPSA id m8-20020a056870058800b0011d02a3fa63sm420199oap.14.2022.09.01.17.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 17:37:04 -0700 (PDT) Date: Thu, 1 Sep 2022 19:37:03 -0500 From: Rebecca Mckeever To: David Hildenbrand Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] memblock tests: add top-down NUMA tests for memblock_alloc_try_nid* Message-ID: <20220902003703.GB18733@sophie> References: <957966f06474e3885796247ad1beaa6b3841ebd1.1660897864.git.remckee0@gmail.com> <6f61b669-e89f-6615-6b80-088940221858@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f61b669-e89f-6615-6b80-088940221858@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662079026; a=rsa-sha256; cv=none; b=Pje4Z5Hw47f7Jo+UAp4jD/mlQEJdcNHvxigMU7dKHoAbLvGQzYAn2zD7xMpiUrXCrOUgVY 7nMGHzktpoi2QWxU959aP0qLhFCrMD9DmEoBq+aAW9nL/2+MKJta8m0fpX8L7eSw0HNb9P ZGPiku88Z3sv+nyJBfDKiftGZzfr3Xg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nBlvj7nr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662079026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xM433NCCdFsj/Dus8z982guFSm6mdOX0+AhxRQOZ+mQ=; b=Dmh9cDPktPwtwvdReVcQZzo4cNYugI1tO6bQznzve2DldT+Zl/08eiv/sOYbmLSNSA2ZEi 1jWIThDZXJ1y78QO6Y7EvAb+Nqawt7PGUZcgu7k0Tws8Grvcbn33UTNlsYe2QK8eLxBHFz FbOQsyB0MO0tOHOOXLnhSyV7cWlPaLQ= X-Rspamd-Server: rspam09 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nBlvj7nr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspam-User: X-Stat-Signature: ps1x67korbwjfosmrxybfc9gkuox4wd9 X-Rspamd-Queue-Id: 00DF0100042 X-HE-Tag: 1662079025-484393 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 01:56:00PM +0200, David Hildenbrand wrote: > On 19.08.22 11:05, Rebecca Mckeever wrote: > > Add tests for memblock_alloc_try_nid() and memblock_alloc_try_nid_raw() > > where the simulated physical memory is set up with multiple NUMA nodes. > > Additionally, all of these tests set nid != NUMA_NO_NODE. These tests are > > run with a top-down allocation direction. > > > > The tested scenarios are: > > > > Range unrestricted: > > - region can be allocated in the specific node requested: > > + there are no previously reserved regions > > + the requested node is partially reserved but has enough space > > - the specific node requested cannot accommodate the request, but the > > region can be allocated in a different node: > > + there are no previously reserved regions, but node is too small > > + the requested node is fully reserved > > + the requested node is partially reserved and does not have > > enough space > > > > Range restricted: > > - region can be allocated in the specific node requested after dropping > > min_addr: > > + range partially overlaps with two different nodes, where the first > > node is the requested node > > + range partially overlaps with two different nodes, where the > > requested node ends before min_addr > > - region cannot be allocated in the specific node requested, but it can be > > allocated in the requested range: > > + range overlaps with multiple nodes along node boundaries, and the > > requested node ends before min_addr > > + range overlaps with multiple nodes along node boundaries, and the > > requested node starts after max_addr > > - region cannot be allocated in the specific node requested, but it can be > > allocated after dropping min_addr: > > + range partially overlaps with two different nodes, where the > > second node is the requested node > > > > Signed-off-by: Rebecca Mckeever > > --- > > tools/testing/memblock/tests/alloc_nid_api.c | 702 ++++++++++++++++++- > > tools/testing/memblock/tests/alloc_nid_api.h | 16 + > > tools/testing/memblock/tests/common.h | 18 + > > 3 files changed, 725 insertions(+), 11 deletions(-) > > > > diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c > > index 2c1d5035e057..a410f1318402 100644 > > --- a/tools/testing/memblock/tests/alloc_nid_api.c > > +++ b/tools/testing/memblock/tests/alloc_nid_api.c > > @@ -1102,7 +1102,7 @@ static int alloc_try_nid_bottom_up_cap_min_check(void) > > return 0; > > } > > > > -/* Test case wrappers */ > > +/* Test case wrappers for range tests */ > > static int alloc_try_nid_simple_check(void) > > { > > test_print("\tRunning %s...\n", __func__); > > @@ -1234,17 +1234,10 @@ static int alloc_try_nid_low_max_check(void) > > return 0; > > } > > > > -static int memblock_alloc_nid_checks_internal(int flags) > > +static int memblock_alloc_nid_range_checks(void) > > { > > - const char *func = get_func_testing(flags); > > - > > - alloc_nid_test_flags = flags; > > - prefix_reset(); > > - prefix_push(func); > > - test_print("Running %s tests...\n", func); > > - > > - reset_memblock_attributes(); > > - dummy_physical_memory_init(); > > + test_print("Running %s range tests...\n", > > + get_func_testing(alloc_nid_test_flags)); > > > > alloc_try_nid_simple_check(); > > alloc_try_nid_misaligned_check(); > > @@ -1261,6 +1254,693 @@ static int memblock_alloc_nid_checks_internal(int flags) > > alloc_try_nid_reserved_all_check(); > > alloc_try_nid_low_max_check(); > > > > + return 0; > > +} > > + > > +/* > > + * A test that tries to allocate a memory region in a specific NUMA node that > > + * has enough memory to allocate a region of the requested size. > > + * Expect to allocate an aligned region at the end of the requested node. > > + */ > > +static int alloc_try_nid_top_down_numa_simple_check(void) > > +{ > > + int nid_req = 3; > > + struct memblock_region *new_rgn = &memblock.reserved.regions[0]; > > + struct memblock_region *req_node = &memblock.memory.regions[nid_req]; > > + void *allocated_ptr = NULL; > > + > > + PREFIX_PUSH(); > > + > > + phys_addr_t size; > > + phys_addr_t min_addr; > > + phys_addr_t max_addr; > > Usually we define variables in a single block. So, before the > PREFIX_PUSH(). Same applies to the other functions. > Got it. > > + > > + setup_numa_memblock(); > > + > > + ASSERT_LE(SZ_4, req_node->size); > > + size = req_node->size / SZ_4; > > + min_addr = memblock_start_of_DRAM(); > > + max_addr = memblock_end_of_DRAM(); > > + > > + allocated_ptr = run_memblock_alloc_try_nid(size, SMP_CACHE_BYTES, > > + min_addr, max_addr, nid_req); > > + > > + ASSERT_NE(allocated_ptr, NULL); > > + verify_mem_content(allocated_ptr, size, alloc_nid_test_flags); > > + > > + ASSERT_EQ(new_rgn->size, size); > > + ASSERT_EQ(new_rgn->base, region_end(req_node) - size); > > + ASSERT_LE(req_node->base, new_rgn->base); > > + > > + ASSERT_EQ(memblock.reserved.cnt, 1); > > + ASSERT_EQ(memblock.reserved.total_size, size); > > + > > + test_pass_pop(); > > + > > + return 0; > > +} > > + > > [...] > > > + > > +/* > > + * A test that tries to allocate a memory region that spans over the min_addr > > + * and max_addr range and overlaps with two different nodes, where the first > > + * node is the requested node: > > + * > > + * min_addr > > + * | max_addr > > + * | | > > + * v v > > + * | +-----------------------+-----------+ | > > + * | | requested | node3 | | > > + * +-----------+-----------------------+-----------+--------------+ > > + * + + > > + * | +-----------+ | > > + * | | rgn | | > > + * +-----------------------+-----------+--------------------------+ > > + * > > + * Expect to drop the lower limit and allocate a cleared memory region that > > + * ends at the end of the requested node. > > Interesting, allocating out-of-range is expected behavior? At least to > me that wasn't immediately clear :) > Yeah, it seems that memblock avoids allocations that would overlap with more than one node. Do you think I should explain that in the comment? > [...] > > > + > > +/* > > + * A test that tries to allocate a memory region that spans over the min_addr > > + * and max_addr range and overlaps with two different nodes, where the second > > + * node is the requested node: > > + * > > + * min_addr > > + * | max_addr > > + * | | > > + * v v > > + * | +--------------------------+---------+ | > > + * | | expected |requested| | > > + * +------+--------------------------+---------+----------------+ > > + * + + > > + * | +---------+ | > > + * | | rgn | | > > + * +-----------------------+---------+--------------------------+ > > + * > > + * Expect to drop the lower limit and allocate a cleared memory region that > > Does the "cleared memory region" part still apply? Or would we also end > up calling the raw variant from run_memblock_alloc_try_nid() ? > No, it doesn't apply. Thanks for catching this. I should probably add another patch to update the wording in the pre-existing tests too. > > + * ends at the end of the first node that overlaps with the range. > > + */ > > +static int alloc_try_nid_top_down_numa_split_range_high_check(void) > > +{ > > + int nid_req = 3; > > + int nid_exp = nid_req - 1; > > + struct memblock_region *new_rgn = &memblock.reserved.regions[0]; > > + struct memblock_region *exp_node = &memblock.memory.regions[nid_exp]; > > + void *allocated_ptr = NULL; > > + > > + PREFIX_PUSH(); > > + > > + phys_addr_t size = SZ_512; > > + phys_addr_t min_addr; > > + phys_addr_t max_addr; > > + phys_addr_t exp_node_end; > > + > > + setup_numa_memblock(); > > + > > + exp_node_end = region_end(exp_node); > > + min_addr = exp_node_end - SZ_256; > > + max_addr = min_addr + size; > > + > > + allocated_ptr = run_memblock_alloc_try_nid(size, SMP_CACHE_BYTES, > > + min_addr, max_addr, nid_req); > > + > > + ASSERT_NE(allocated_ptr, NULL); > > + verify_mem_content(allocated_ptr, size, alloc_nid_test_flags); > > + > > + ASSERT_EQ(new_rgn->size, size); > > + ASSERT_EQ(new_rgn->base, exp_node_end - size); > > + ASSERT_LE(exp_node->base, new_rgn->base); > > + > > + ASSERT_EQ(memblock.reserved.cnt, 1); > > + ASSERT_EQ(memblock.reserved.total_size, size); > > + > > + test_pass_pop(); > > + > > + return 0; > > +} > > > [...] > > > +int __memblock_alloc_nid_numa_checks(void) > > +{ > > + test_print("Running %s NUMA tests...\n", > > + get_func_testing(alloc_nid_test_flags)); > > + > > + alloc_try_nid_numa_simple_check(); > > + alloc_try_nid_numa_small_node_check(); > > + alloc_try_nid_numa_node_reserved_check(); > > + alloc_try_nid_numa_part_reserved_check(); > > + alloc_try_nid_numa_part_reserved_fallback_check(); > > + alloc_try_nid_numa_split_range_low_check(); > > + alloc_try_nid_numa_split_range_high_check(); > > + > > + alloc_try_nid_numa_no_overlap_split_check(); > > + alloc_try_nid_numa_no_overlap_low_check(); > > + alloc_try_nid_numa_no_overlap_high_check(); > > + > > + return 0; > > +} > > + > > +static int memblock_alloc_nid_checks_internal(int flags) > > +{ > > + alloc_nid_test_flags = flags; > > Empty line missing > Got it. > > + prefix_reset(); > > + prefix_push(get_func_testing(flags)); > > + > > + reset_memblock_attributes(); > > + dummy_physical_memory_init(); > > + > > + memblock_alloc_nid_range_checks(); > > + memblock_alloc_nid_numa_checks(); > > + > > dummy_physical_memory_cleanup(); > > > > prefix_pop(); > > > -- > Thanks, > > David / dhildenb > > Thanks, Rebecca