From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A716ECAAD3 for ; Thu, 1 Sep 2022 23:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5EF80082; Thu, 1 Sep 2022 19:26:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 284EC8000D; Thu, 1 Sep 2022 19:26:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1257F80082; Thu, 1 Sep 2022 19:26:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F24CD8000D for ; Thu, 1 Sep 2022 19:26:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CEBFC140680 for ; Thu, 1 Sep 2022 23:26:53 +0000 (UTC) X-FDA: 79865103906.23.F3C59E5 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf22.hostedemail.com (Postfix) with ESMTP id 481A9C0051 for ; Thu, 1 Sep 2022 23:26:53 +0000 (UTC) Date: Thu, 1 Sep 2022 19:26:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662074812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ziQwyv6CBY5n7ARW4qu86GPnvQN6geI/tFyfrLXQmYY=; b=J6csj5dyhB9n57JXIj/oDTNnfDhtPgzehwGStIMJ1Zca26/ME4gYxeDh8PpO+R5AM1uQtx AuGPCBQOLiOURlLPfz0PHN++Qv8oJrHnFRvUJhS53h6Xh9/SgubQ1HLN0ij2EQ6piWu6qx RwYFCEhuRCegC1FPS7XpHSMhorTcjrw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Joe Perches Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 28/30] Improved symbolic error names Message-ID: <20220901232645.4dogffr26oisd7p5@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-29-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662074813; a=rsa-sha256; cv=none; b=mxd1gKPakEiBOsypto/mmc+sI7d5k92fwsoGorqebBwqnjc+0glOpKNtbYhRhAKmkMVrZz c9Uq0dnZVqtoZXItgyjW8VT5mbVzz7g6X2RVK9frOJ9P262qIkfMIdEPVLwWw8VSnHtIyO NRXCNp0guP7uaJlhed4Jdxzqgv/dUfE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=J6csj5dy; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662074813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ziQwyv6CBY5n7ARW4qu86GPnvQN6geI/tFyfrLXQmYY=; b=aPb05XjecxbqjlYTg6jGCkiiabcCHjF0rxVZreobrsU1P1pYrVovmXZK9//x/QjZqc9cvO 6TQZ8iPc8hTyJIoPD+YprfoDy3zN59mFQ+l4McF/dz49Ggl+BaMcJgkGRQKk+2LGqM1QMz Ib/X9AOWLBa3rhaWrnB4it6KPA8A/28= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=J6csj5dy; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Stat-Signature: xthzsc1crn56px1wpfg87oy5kunfikkr X-Rspamd-Queue-Id: 481A9C0051 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1662074813-388811 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 04:19:35PM -0700, Joe Perches wrote: > On Tue, 2022-08-30 at 14:49 -0700, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > This patch adds per-error-site error codes, with error strings that > > include their file and line number. > > > > To use, change code that returns an error, e.g. > > return -ENOMEM; > > to > > return -ERR(ENOMEM); > > > > Then, errname() will return a string that includes the file and line > > number of the ERR() call, for example > > printk("Got error %s!\n", errname(err)); > > will result in > > Got error ENOMEM at foo.c:1234 > > Why? Something wrong with just using %pe ? > > printk("Got error %pe at %s:%d!\n", ERR_PTR(err), __FILE__, __LINE__); > > Likely __FILE__ and __LINE__ aren't particularly useful. That doesn't do what this patchset does. If it only did that, it wouldn't make much sense, would it? :) With this patchset, printk("Got error %pe!\n", ptr); prints out a file and line number, but it's _not_ the file/line number of the printk statement - it's the file/line number where the error originated! :)