From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7169BECAAD1 for ; Thu, 1 Sep 2022 14:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6A3E6B0078; Thu, 1 Sep 2022 10:32:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1DC6B007B; Thu, 1 Sep 2022 10:32:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C93608D0006; Thu, 1 Sep 2022 10:32:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B777C6B0078 for ; Thu, 1 Sep 2022 10:32:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 89801140F5E for ; Thu, 1 Sep 2022 14:32:29 +0000 (UTC) X-FDA: 79863757218.14.FE96AC6 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf10.hostedemail.com (Postfix) with ESMTP id 1D36CC0047 for ; Thu, 1 Sep 2022 14:32:28 +0000 (UTC) Date: Thu, 1 Sep 2022 10:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662042747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hzpqzF+cHXDydzBO/Ouha4xSMTzYETXF6uFA22HjvEI=; b=NZoXkZHKLzeUxAk3ak7Pb8vsW9ZNZzRTwKtA+BC4xdSYkJ+ynByJWkg/Sh230HugdVWRmg yoek0j7jmp5SFliaDUrwdj/qDw5fARM6MIEEXIMmkE2NnaJO1XhB2/CCfm1A1hYZKgVq4b dPipMi7tKAPAIcwcMtS9bvz5Flf6OaU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Peter Zijlstra Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 03/30] Lazy percpu counters Message-ID: <20220901143219.n7jg7cbp47agqnwn@moria.home.lan> References: <20220830214919.53220-1-surenb@google.com> <20220830214919.53220-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662042749; a=rsa-sha256; cv=none; b=rHD+Tmz46h/2KFyablbn+UyHVTARlSX4lfP6lQ6NqFjV9c7o7gUFj0NcRT2YYGCSldPjJQ UmkYdmqexkGR+s2bgpOt1+jbWKYqLTETqtx2OmiMrNeywNL6Vzcl32yARI+nBMQb+tCkQS mSTcJDeMEse82POmJt2BCzp/5KnAGiE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NZoXkZHK; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662042749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hzpqzF+cHXDydzBO/Ouha4xSMTzYETXF6uFA22HjvEI=; b=Q0BHIy0Vhk56HjI2XpZ4HWt5tgFERSIqftY6QNrambjnxChmklFALU9fKHkUseWhylLiek z4LlDpbCDL7X4FCGcc+/JmRXPlYLpsiy1a/fiIKlPQNNQ4tjW6wRCVfHAxWM/cGi66s5tN GgD+alaWQVxgrHdWK8BnTITv9cZZrnQ= X-Rspamd-Queue-Id: 1D36CC0047 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NZoXkZHK; spf=pass (imf10.hostedemail.com: domain of kent.overstreet@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: h3za8ejer7md3mcjp3g8of5wugoo5gd8 X-HE-Tag: 1662042748-733339 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 08:51:31AM +0200, Peter Zijlstra wrote: > On Tue, Aug 30, 2022 at 02:48:52PM -0700, Suren Baghdasaryan wrote: > > +static void lazy_percpu_counter_switch_to_pcpu(struct raw_lazy_percpu_counter *c) > > +{ > > + u64 __percpu *pcpu_v = alloc_percpu_gfp(u64, GFP_ATOMIC|__GFP_NOWARN); > > Realize that this is incorrect when used under a raw_spinlock_t. Can you elaborate?