[linux-next:master 3575/3976] mm/memory-tiers.c:647:35: error: use of undeclared identifier 'top_tier_adistance'

[linux-next:master 3575/3976] mm/memory-tiers.c:647:35: error: use of undeclared identifier 'top_tier_adistance'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   282342f2dc97ccf54254c5de51bcc1101229615f
commit: 2ec921a84615ee0665bcc369d40b92e2bed66cd5 [3575/3976] mm/demotion: expose memory tier details via sysfs
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220831/202208310340.bfIiSHdK-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2ec921a84615ee0665bcc369d40b92e2bed66cd5
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 2ec921a84615ee0665bcc369d40b92e2bed66cd5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/memory-tiers.c:647:35: error: use of undeclared identifier 'top_tier_adistance'
                   if (memtier->adistance_start >= top_tier_adistance)
                                                   ^
   1 error generated.


vim +/top_tier_adistance +647 mm/memory-tiers.c

   637	
   638	static ssize_t toptier_nodes_show(struct device *dev,
   639					     struct device_attribute *attr, char *buf)
   640	{
   641		int ret;
   642		nodemask_t nmask, top_tier_mask = NODE_MASK_NONE;
   643		struct memory_tier *memtier = to_memory_tier(dev);
   644	
   645		mutex_lock(&memory_tier_lock);
   646		list_for_each_entry(memtier, &memory_tiers, list) {
 > 647			if (memtier->adistance_start >= top_tier_adistance)
   648				break;
   649			nmask = get_memtier_nodemask(memtier);
   650			nodes_or(top_tier_mask, top_tier_mask, nmask);
   651		}
   652	
   653		ret = sysfs_emit(buf, "%*pbl\n", nodemask_pr_args(&top_tier_mask));
   654		mutex_unlock(&memory_tier_lock);
   655		return ret;
   656	}
   657	static DEVICE_ATTR_RO(toptier_nodes);
   658	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [linux-next:master 3575/3976] mm/memory-tiers.c:647:35: error: use of undeclared identifier 'top_tier_adistance'

[Andrew Morton]

On Wed, 31 Aug 2022 03:25:27 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   282342f2dc97ccf54254c5de51bcc1101229615f
> commit: 2ec921a84615ee0665bcc369d40b92e2bed66cd5 [3575/3976] mm/demotion: expose memory tier details via sysfs
> config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220831/202208310340.bfIiSHdK-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2ec921a84615ee0665bcc369d40b92e2bed66cd5
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 2ec921a84615ee0665bcc369d40b92e2bed66cd5
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> mm/memory-tiers.c:647:35: error: use of undeclared identifier 'top_tier_adistance'
>                    if (memtier->adistance_start >= top_tier_adistance)
>                                                    ^
>    1 error generated.

Thanks, I'll do this for now:

--- a/mm/memory-tiers.c~mm-demotion-expose-memory-tier-details-via-sysfs-fix-2
+++ a/mm/memory-tiers.c
@@ -108,7 +108,20 @@ static int top_tier_adistance;
  *
  */
 static struct demotion_nodes *node_demotion __read_mostly;
-#endif /* CONFIG_MIGRATION */
+
+/* I need a comment too */
+static inline bool i_need_a_name(struct memory_tier *memtier)
+{
+	return memtier->adistance_start >= top_tier_adistance;
+}
+
+#else	/* CONFIG_MIGRATION */
+
+static inline bool i_need_a_name(struct memory_tier *memtier)
+{
+	return false;
+}
+#endif	/* CONFIG_MIGRATION */
 
 static __always_inline nodemask_t get_memtier_nodemask(struct memory_tier *memtier)
 {
@@ -648,7 +661,7 @@ static ssize_t toptier_nodes_show(struct
 
 	mutex_lock(&memory_tier_lock);
 	list_for_each_entry(memtier, &memory_tiers, list) {
-		if (memtier->adistance_start >= top_tier_adistance)
+		if (i_need_a_name(memtier))
 			break;
 		nmask = get_memtier_nodemask(memtier);
 		nodes_or(top_tier_mask, top_tier_mask, nmask);

Aneesh, please provide suitable name and comment?