* [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers
@ 2022-08-30 8:14 Aneesh Kumar K.V
2022-08-30 15:48 ` Wei Xu
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2022-08-30 8:14 UTC (permalink / raw)
To: linux-mm, akpm
Cc: Wei Xu, Huang Ying, Yang Shi, Davidlohr Bueso, Tim C Chen,
Michal Hocko, Linux Kernel Mailing List, Hesham Almatary,
Dave Hansen, Jonathan Cameron, Alistair Popple, Dan Williams,
Johannes Weiner, jvgediya.oss, Bharata B Rao, Aneesh Kumar K.V
Based on suggestion from Wei Xu <weixugc@google.com>, having an
inclusive upper bound is found simpler.
Fixes: mm/demotion: Update node_is_toptier to work with memory tiers
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
mm/memory-tiers.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index c4bd6d052a33..c82eb0111383 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -179,7 +179,7 @@ bool node_is_toptier(int node)
toptier = true;
goto out;
}
- if (memtier->adistance_start < top_tier_adistance)
+ if (memtier->adistance_start <= top_tier_adistance)
toptier = true;
else
toptier = false;
@@ -361,7 +361,8 @@ static void establish_demotion_targets(void)
* abstract distance below the max value of this memtier
* is considered toptier.
*/
- top_tier_adistance = memtier->adistance_start + MEMTIER_CHUNK_SIZE;
+ top_tier_adistance = memtier->adistance_start +
+ MEMTIER_CHUNK_SIZE - 1;
break;
}
}
--
2.37.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers
2022-08-30 8:14 [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers Aneesh Kumar K.V
@ 2022-08-30 15:48 ` Wei Xu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Xu @ 2022-08-30 15:48 UTC (permalink / raw)
To: Aneesh Kumar K.V
Cc: Linux MM, Andrew Morton, Huang Ying, Yang Shi, Davidlohr Bueso,
Tim C Chen, Michal Hocko, Linux Kernel Mailing List,
Hesham Almatary, Dave Hansen, Jonathan Cameron, Alistair Popple,
Dan Williams, Johannes Weiner, jvgediya.oss, Bharata B Rao
On Tue, Aug 30, 2022 at 1:15 AM Aneesh Kumar K.V
<aneesh.kumar@linux.ibm.com> wrote:
>
> Based on suggestion from Wei Xu <weixugc@google.com>, having an
> inclusive upper bound is found simpler.
>
> Fixes: mm/demotion: Update node_is_toptier to work with memory tiers
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> mm/memory-tiers.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index c4bd6d052a33..c82eb0111383 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -179,7 +179,7 @@ bool node_is_toptier(int node)
> toptier = true;
> goto out;
> }
> - if (memtier->adistance_start < top_tier_adistance)
> + if (memtier->adistance_start <= top_tier_adistance)
> toptier = true;
> else
> toptier = false;
> @@ -361,7 +361,8 @@ static void establish_demotion_targets(void)
> * abstract distance below the max value of this memtier
below -> up to ? Looks good to me otherwise.
Wei
> * is considered toptier.
> */
> - top_tier_adistance = memtier->adistance_start + MEMTIER_CHUNK_SIZE;
> + top_tier_adistance = memtier->adistance_start +
> + MEMTIER_CHUNK_SIZE - 1;
> break;
> }
> }
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-30 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 8:14 [PATCH mm-unstable] mm/demotion: Make toptier_distance inclusive upper bound of toptiers Aneesh Kumar K.V
2022-08-30 15:48 ` Wei Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox