From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFEDEECAAD4 for ; Tue, 30 Aug 2022 08:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530556B0073; Tue, 30 Aug 2022 04:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF98940007; Tue, 30 Aug 2022 04:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A106B0075; Tue, 30 Aug 2022 04:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 23A646B0073 for ; Tue, 30 Aug 2022 04:00:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E58FC160F95 for ; Tue, 30 Aug 2022 08:00:20 +0000 (UTC) X-FDA: 79855511400.13.F2EB477 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 4204D2001D for ; Tue, 30 Aug 2022 08:00:19 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27U77P6p029380; Tue, 30 Aug 2022 08:00:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=EEFFMFgFDrkg8b8SpWKZOvFcIb1GGUZKKR/z+4gRc7c=; b=JqyQWFnX95QsfsOifuJcmENezMYYOZbXG5ndV+W8LDwB30CDTBlOEMPTt0xWVbhQAXgR FS+2w+19hboLajpZqBhFMOquujmjQVNTFJz2Gk95aH183xDD6z1lyAi1UxRtXS39pEk0 HaN5dsGB1CYfAkt+rNEFvcG0HSVHnFoTndFHiG3T/OAR/+T8J+IL1Ljm3dL18cVqTY4v SPyqO4IrGzlDT7tD0qc09+/T0YplEEiww9FaRANJlTRIz3KhWbCNvVNjbxrl+StPHe7z NxTql71IrwAUBQ9PR0UOhdruhBTzbGzeCA3aHaG93tKucHB0xTUfdtVvaw+Ht4mYUKcu pg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j79v0njka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Aug 2022 08:00:18 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27U6UTnG038512; Tue, 30 Aug 2022 08:00:17 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3j79q9rd2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Aug 2022 08:00:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfU7rv0t2mDKEwk+CRn0yo1fDk5fYGxXGWYv65QNHXfEKilUfUbBqCsRgPV0dBKxspIfp7dn9c4Kf7Mo/ReKZXZLZXNojVCXOWXKKVcU2/OX9xJvv1DFclGgB5o1P2DR3+5BDd/H3HgyYbs8XTaB6muBjTv26rVMMTkGMWRsEqhYTPY9au15eQlX0JkmZVJijp5ng4zQq8ibpvPLo8iG9i20DB4R7Hfi9/frUQ1bIkzqLhldjbu6NMSvbCq6tNCbAA+aBvOXXTaUbFB9g+ZUngiVMJ4N1aSc3Q5hyzP6DzNK5KRendt2wYs4duPYOaKiwvCD/Q3awNgw0no0BFTHGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EEFFMFgFDrkg8b8SpWKZOvFcIb1GGUZKKR/z+4gRc7c=; b=a391mMNTWAdkxSk9Xq5hWqTT4k2ZLflvqTWs2ZKeXbtlywbKp3DvFwP6B8iJdT0HoBB/buEoru+1XZbRWV3JHYyYjVsUE91COyh8crEFJOcb04Fru9VTSAXE3NY1xXMVfeaGHukou95U6dDVOKlMsApEAKezEoG6pa+Lv6lmPFtLzsv9h5ujqD4wziCtGBE+evfz0Arc92UuTMT51RgfMgTP82mFBuUE2YkDhIkKpmeEjul9DS13D3VilGf3oKDh2Z5Nb0gRnGYuNsotOH8e4EGnFh+6F5r0b0sXKEzL+XC/1MuxYnqiU7hGN13Lee1DVRjEKP+bykgqaNKvWkqKNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EEFFMFgFDrkg8b8SpWKZOvFcIb1GGUZKKR/z+4gRc7c=; b=TxUkdjIYLBWLv40WITrN7JpNDEoQxynOypSjIbGIk66ezC1AUQHZ4Cn8LmILaTpMMtmmVKdY/GdRJ+lXHHDCMBg+831SoPWphVziyv8DL1cRD87ntNdnAPyarO9npqpAFtEXRRs0EZQojshZMWNjG/DvkwMmfYFouBp63mllG20= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BN6PR1001MB2372.namprd10.prod.outlook.com (2603:10b6:405:2b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Tue, 30 Aug 2022 08:00:15 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::209e:de4d:68ea:c026%3]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 08:00:14 +0000 Date: Tue, 30 Aug 2022 10:59:57 +0300 From: Dan Carpenter To: Michal Hocko Cc: linux-mm@kvack.org Subject: Re: [bug report] mm: reduce noise in show_mem for lowmem allocations Message-ID: <20220830075957.GS2030@kadam> References: <20220830070205.GQ2030@kadam> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNXP275CA0017.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:19::29) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4725ec59-0d73-4df7-f1cb-08da8a5dabd5 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2372:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ysxX2kysWDKJG+uqnoD8PTA/ObjUK+Q7GTa1fOmPArBdUvNgA5KRDSvgFyrP5I+yQhl5FShxwEvJir5v2Ic+isnY2BAW/24JnHC48vywZNjC3hHFzO/2uWX153h3lakfOQB2n0lt3r7CzsOmN8jTXW+v4ea2e4Sa5M/3H2gtpNLi3EpgWrxxCYEbe6T8EpoEfcxgd8Asg4Y1dHaLOOmNPnMw9dfl+xZvdb7axditwb9DyEDwMHYR8Hdf73j1ntIviVi6PgcCXLXr404p6BpzDZ1/A6sVLSx4U30AxzRvimaYGj0qUeA6CgOFCycfe8+zEPF2PcDxPRb0yt6jE1WGvz/binjPwkRR2xk1kmYNY60mfL+NArgpyAZI2lcfhRBSSgj4tb2TzJp6TG+Fdf4UN7F/wimnVz9U0n5gL3X2DBQ3ZvEMsKmi9HUJ0/YynWj3oJWe+OctdqP+azH0qYfN3mICFG3/VPPEeYIHP2QrfM0UGaxJxxYRfWFE6E4u0Di16V8qNrR/1ITFcRdijf2a3CyxgjIMlk4kbqBaBTQj31rRi75G/OHusE4kBVbzqBqnYl4mRIl8EDuRzLOvCypz/TrXcdmsXMqZgslcHyWvPfsDxZCoAd7/TKeoCRnofgEXthcvvHUSq50tzP7M9UhM9AXbN3f1gIUmBeXo1JHlFz507LmqLZ6bUpl/iEFMAzCBNJAbUwDoymRRC3wWY5GDPnhXeMlluINs+C1e+kXGf0iUH8OVxujHet4J6LAKESRI0r5SV9xwqCbAtVthi3hQOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(396003)(376002)(136003)(39860400002)(366004)(346002)(38100700002)(6512007)(9686003)(6916009)(83380400001)(52116002)(478600001)(38350700002)(316002)(6486002)(6506007)(8936002)(33656002)(6666004)(5660300002)(66476007)(41300700001)(44832011)(4326008)(33716001)(66556008)(186003)(1076003)(26005)(8676002)(86362001)(66946007)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VFdJsEBUE/+BADvCyKipqhmvzDsH3pyiD/bywXLYi3DT60rOm+0231wD/J3p?= =?us-ascii?Q?uY2S4aRWtWwGWHlDq5r9/khkyauXu2MKN6ZqzXlQUmq67FtXroRtcYsmjrVP?= =?us-ascii?Q?JAJWVXhGCqlebcBcftEQtM4E4Zu69dN3AgIix6JZKsDsuCOujlQnyh73nDZ0?= =?us-ascii?Q?q2kk4S+SGKqWCu7eXvilI7pN8anRglqkee82655iaYP3XHEiOJuUoYyuNv13?= =?us-ascii?Q?3iW7HLV2qAIVbHnWwKDQHkTGLbIEBDrTF5qqMtG2GYvOY7QxIe29DwawEMNY?= =?us-ascii?Q?2xeNZoodPWc+YdG9/sGtvSQMwHDiL1uk/UdbShg+60+vmGP+AZNhYfJsq82j?= =?us-ascii?Q?pa/Ehk0n6FH6cqGEvbTzWKi/VDhHWU3EHbq/VNbM8nogPo7sckNYdEzkwiPm?= =?us-ascii?Q?zm5yzz4fkV0FaFan9fQm+GEHyjOQgWAXSDQIKIALAB12Y8l/JdD4qpmy1yut?= =?us-ascii?Q?oYRYc+aZBPs0eRy7jYfMatzIiovxGHS1vMLFk/Xw3Qz5JP0wxbSS3HdeNP37?= =?us-ascii?Q?lhuehxYbxzAcvNsXjmWXG5LJilfoZ0a1i9pJ1fBD3lcH7I2gdvSCMTjer6hg?= =?us-ascii?Q?o11l4byXRlhenAKhLEzdqG6WVL4GBN4n1HIzEhzO/F9wquobbMO+oHZ2O2WB?= =?us-ascii?Q?voGHeB2tEgxI5+evWzkT1PIBEF4+wTo3Sn0npsCVTH7IVdshxWsrXZkc6Ik6?= =?us-ascii?Q?/ejGByXEc3C/RUnRGOqjQ5dBY6nCO0xoRpO47zNm7/16uEv7QiWCKl+7W+e+?= =?us-ascii?Q?yNdBPCaBRa/vT58ynxvCwXa46oHZXA8ut5WN3WuGxoTZuNpOrwsELGswgkng?= =?us-ascii?Q?bwqcWuYdvrPJwLY8YYRW92L5e7E73e0MS2FKP4OjwIZ3R4uruWPesoqgBLr0?= =?us-ascii?Q?ChMlCQRmAfoddv5F+ax8atQlLzBh92n8tkAZ+5V8ZVB72d6/nkhIr6FPY4Yi?= =?us-ascii?Q?d05vOP1q9Hotad0xkDcT9GAsJp36Yb+8BW45JOmz0WuSmCQD8z6n6i8dLLK4?= =?us-ascii?Q?qdi0vclQOvmIcDtQJRz+kX9HSwd7nn4iffi7GiJbMlBx+tYPoxveXhIxksDX?= =?us-ascii?Q?bXG6mKaZPct87FRDX0SKjcHdcyxpO6CItGeQfh6MIL7j7ZjshTKiqsr2+6X/?= =?us-ascii?Q?AZLfoePXqMoTthidVkNFZIlvWjXJKcoP+DFDeuddrN2cquj5GmhEdQC39vNe?= =?us-ascii?Q?RvA+AGl9H2kM9aprztvTH46o8yqkZJwH9Q/TVIiJAHDAGks83NKLQcLXt6mk?= =?us-ascii?Q?TNrKELzzAO6Z+PCVm6NRpG2pl/qFtvD7p19+ztIwB0AycDmGAVV7wE94d7LH?= =?us-ascii?Q?EXqHL/rgKUlKE7VYdfFdhTQc58Utxhqm0ZLzioteaIdJl1YCqqmHLG+IweiO?= =?us-ascii?Q?2Wypo+/P+dDzSqPciERqkO0NjktQfvrburbYMj3rbKOaX9fvqkZfGOzSA2oR?= =?us-ascii?Q?l0OW0vbHIuyJcDUqnwTurm+ssI0DUmAuO+Hph6mgaqthLJWE2C1Q7TiGUAj+?= =?us-ascii?Q?l6LLOG6aG8lV4oJYFfNAy6xNtlZl6SavNt/zK84wyuoCz+gLPIGrG5Ejtk+t?= =?us-ascii?Q?hHVc6zH5OxThy/9YjarzVVJoulk+jCP+3PlSu8dy+ZWlNC8dP5aIxNHuhlfW?= =?us-ascii?Q?5g=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4725ec59-0d73-4df7-f1cb-08da8a5dabd5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 08:00:14.6956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JL8t7Sqa1lHVeG9c32v731QPi085jm2rXKMNWJsnSiL4pusPYnZnoH0C/N2vKUzR4H1+6F0PTKRV3PsvzAPy2l+EiM28oPlhMGgHY7p/tMY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2372 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-30_04,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208300038 X-Proofpoint-GUID: E2T4Jem-1fyV5QKhZF8M1adifQkc3zu4 X-Proofpoint-ORIG-GUID: E2T4Jem-1fyV5QKhZF8M1adifQkc3zu4 ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661846420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EEFFMFgFDrkg8b8SpWKZOvFcIb1GGUZKKR/z+4gRc7c=; b=h8v10j64sV5RpbrpGZNrmjK/M3oBBgWaKhJfMaqdMVWNhOiCrVQpcGxf5dYp/gZ+lhc+la 4sIP+Arl7ZgGuedYRj4HqZSvppVzdm9NsRrDLbQJgoq+2i0OK/1Eo9eG9pEErvbkBCuWYP cuiMSwnl1UpOiZphw00lBnlS9aN+Img= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=JqyQWFnX; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TxUkdjIY; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661846420; a=rsa-sha256; cv=pass; b=3l7vcezFGxtigbM+MXH5IijOGJuCAPy0hG2liKAp7GbRFP5CyAEdLxoxht5as0CnykS/sl MeMvBCok3A5TZZvZNXe9/Zk6rZL2fmJR1NYx0d9IQN7+hTvrhPwC/IMmX5hHUgTCjNqyrj CuRJgrvB1NstTOSDs51m/sejHGKPL1s= X-Rspam-User: X-Rspamd-Queue-Id: 4204D2001D X-Stat-Signature: p66ouhuq9gne94sruhc1nw4g5j3ojeso Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=JqyQWFnX; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=TxUkdjIY; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of dan.carpenter@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam08 X-HE-Tag: 1661846419-762837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 09:11:03AM +0200, Michal Hocko wrote: > On Tue 30-08-22 10:02:05, Dan Carpenter wrote: > > On Tue, Aug 30, 2022 at 08:46:58AM +0200, Michal Hocko wrote: > > > On Tue 30-08-22 09:30:26, Dan Carpenter wrote: > > > > Hello Michal Hocko, > > > > > > > > The patch e8fedfea3dea: "mm: reduce noise in show_mem for lowmem > > > > allocations" from Aug 23, 2022, leads to the following Smatch static > > > > checker warning: > > > > > > > > kernel/panic.c:190 panic_print_sys_info() > > > > warn: sleeping in atomic context > > > > > > What is this warning saying? > > > > > > > This is a Smatch warning. > > > > > > 189 if (panic_print & PANIC_PRINT_MEM_INFO) > > > > --> 190 show_mem(0, NULL, GFP_HIGHUSER_MOVABLE); > > > > ^^^^^^^^^^^^^^^^^^^^ > > > > This obviously seems very deliberate and a lot of weird stuff happens > > > > during panic(). But the panic() function disables preemption so > > > > shouldn't this be GFP_ATOMIC? GFP_HIGHUSER_MOVABLE has __GFP_RECLAIM > > > > and triggering swap during a panic seems bad. > > > > > > This function shouldn't ever be allocating any memory. The flag is > > > solely to infer which memory zones should be displayed. It acts as a > > > filter. Is it possible that the checker misinterprets the parameter's > > > meaning? > > > > Ah. Yes. Smatch sees every gfp_t as a sleep/no sleep marker. I > > didn't realize it wasn't used like that here. Thanks! > > OK, fair enough and I can actually see how that can turn out into a real > allocation in a distant future when the original intention has been lost > in the past. Let me re-open the discussion for that patch and CC you > there. No no. I can silence this in Smatch. I hadn't really wanted to bother because this one false positive doesn't stand out from all the other false positives. The sleeping in atomic check in Smatch is generally pretty good, but when the call tree is five or more functions deep between disabling preemption and the sleep then that's the main source of false positives. regards, dan carpenter