From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA854ECAAD1 for ; Tue, 30 Aug 2022 05:06:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B6AF940008; Tue, 30 Aug 2022 01:06:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3656E940007; Tue, 30 Aug 2022 01:06:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25504940008; Tue, 30 Aug 2022 01:06:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 127BF940007 for ; Tue, 30 Aug 2022 01:06:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D0CF7160CA8 for ; Tue, 30 Aug 2022 05:06:04 +0000 (UTC) X-FDA: 79855072248.22.2B2C160 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf05.hostedemail.com (Postfix) with ESMTP id 4EBF610001B for ; Tue, 30 Aug 2022 05:06:04 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B25A868AA6; Tue, 30 Aug 2022 07:05:59 +0200 (CEST) Date: Tue, 30 Aug 2022 07:05:59 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Subject: Re: [PATCH -next v4 1/6] Revert "frontswap: remove support for multiple ops" Message-ID: <20220830050559.GA23877@lst.de> References: <20220829132302.3367054-1-liushixin2@huawei.com> <20220829132302.3367054-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829132302.3367054-2-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661835964; a=rsa-sha256; cv=none; b=sq4mV/7c5BJ+E/W6VkT1sCtA2T1stM0cEc1xFiRkRWoTiCHkP1y3f7qRnG9HMP6ivWgPvV D/GIUb5b9y8L4VcjDuAhow76hIR0h9vWIIh+OzsB5g12iY7BWCrhzShqJ9Nt5y7l3MnOmQ ZcAsE+1J2/xUz9wTO1UvBKTB9x+0JYQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661835964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6WHeUetxkndWUeAWsbD2ot1w3EtSeROzqEICjVikAY=; b=nWe9H7DE2CtfiMozQA42OwiXmYT6ujsGOAzpMflFb03rOcd7YJM5bV58w3Te/lAM151AKo aH4rvTQTnMRlxFuh6tg9M9jdBUuuky8le42gkTdbgQECw/9JkbgxCvGcYnDxGsa/hkmRWI X6sWtmehYBhw9rOcaq8UGx3nNoSsqR0= Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: uk44m6xmrs4o6efuumc8rg3sow7kprf1 X-Rspamd-Queue-Id: 4EBF610001B X-HE-Tag: 1661835964-962587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 09:22:57PM +0800, Liu Shixin wrote: > This reverts commit 1da0d94a3ec8c5f3793b7be8538b55e60ebeefe3. Err, no, this is a way to big hammer and going in the wrong way. If we can't have a sane way to fix it, the fix is just to remove the now rather pointless fontswap abstraction entirely. I'm on vacation this week, but I'll look into it ASAP once back.