From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A34ECAAD5 for ; Mon, 29 Aug 2022 15:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95F32940009; Mon, 29 Aug 2022 11:26:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E7B4940007; Mon, 29 Aug 2022 11:26:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73ABE940009; Mon, 29 Aug 2022 11:26:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 64ABA940007 for ; Mon, 29 Aug 2022 11:26:13 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0013A1A0B63 for ; Mon, 29 Aug 2022 15:26:11 +0000 (UTC) X-FDA: 79853006142.17.B14AFFB Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf16.hostedemail.com (Postfix) with ESMTP id 6525E18003F for ; Mon, 29 Aug 2022 15:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661786771; x=1693322771; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=xYdvX1PhD3Iug/xG1oZ0ioxeY0YVxwImFkNf9/6SStg=; b=Pmddc8c1h7iiEmtqMvwUSUJVyA53GskRcTh4kQF9hdkiSx77WqSW2ljJ U9YDqUaM8b8I45qRFXige/5YZO/sTxZbJkfrqaur5qWkjDO/m+KXSTFkP +avnHJfwh+gqlck81u5P3AMGxh4QnCRDNs7ncGxzc5v1c4CFdvTj2Zdps XY9l5S8jnKHGz1FLuhJqFyin2PGzp7CZv6TDUjsxaYY/DKs4RGk9pIEq5 IpXU0pvFXyYZog/4gCTDDaLaAv9mN1IdkmBoCRQvnYidXyVPhEaxpeigu Pdvo/rY8t5FdIIbfvKKMYID4vjtRD3VInWxTrEdi2XJ1FsUHhpyErYVcg w==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="281894893" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="281894893" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 08:25:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="640973244" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga008.jf.intel.com with ESMTP; 29 Aug 2022 08:25:49 -0700 Date: Mon, 29 Aug 2022 23:21:07 +0800 From: Chao Peng To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Subject: Re: [PATCH v7 11/14] KVM: Register/unregister the guest private memory regions Message-ID: <20220829152107.GD1586678@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-12-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661786771; a=rsa-sha256; cv=none; b=evpbVjsxDywdEC9g7TvqV1lL3VWaI/OmL1IO5gluk6zpozd2IRiHYFZ8XGcswTqvBXrdfY Rf2o/IFIz0NCjwlwdE2df7QchuEMzdD/kh18mI3WzIx6YtogaZlMS4kOEIW8TWaGEQFuij L3UYUJF2Cpj7hlaxG54Lx2szEMsiwyk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Pmddc8c1; spf=none (imf16.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661786771; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+9S2j2TSedHsvSCBsZB3orIO9iT9ailfDK4zub0rMV8=; b=Aqg7oY88NryVEAbZkEYdUjaTyGMtcg3ScJqZ0tGPMmuwrrpErgQ7BCd/uOZr/mBtdb8IYR BH6lu0aUCDkHbwlDUj9d6dHvI1L1+F95tFOdBnmTrxVqHTVD5Pva0tkdIdAHWgp/D7K8RW /mtOCIK02DkTbEhLimJFQh+0Sw1f71o= Authentication-Results: imf16.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Pmddc8c1; spf=none (imf16.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=fail reason="No valid SPF" header.from=intel.com (policy=none) X-Rspamd-Server: rspam05 X-Stat-Signature: iuufak36rymnw4bhqhgikh35xosbk8s4 X-Rspamd-Queue-Id: 6525E18003F X-Rspam-User: X-HE-Tag: 1661786771-514086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 26, 2022 at 04:19:43PM +0100, Fuad Tabba wrote: > > +bool __weak kvm_arch_private_mem_supported(struct kvm *kvm) > > +{ > > + return false; > > +} > > + > > static int check_memory_region_flags(const struct kvm_user_mem_region *mem) > > { > > u32 valid_flags = KVM_MEM_LOG_DIRTY_PAGES; > > @@ -4689,6 +4729,22 @@ static long kvm_vm_ioctl(struct file *filp, > > r = kvm_vm_ioctl_set_memory_region(kvm, &mem); > > break; > > } > > +#ifdef CONFIG_HAVE_KVM_PRIVATE_MEM > > + case KVM_MEMORY_ENCRYPT_REG_REGION: > > + case KVM_MEMORY_ENCRYPT_UNREG_REGION: { > > + struct kvm_enc_region region; > > + > > + if (!kvm_arch_private_mem_supported(kvm)) > > + goto arch_vm_ioctl; > > + > > + r = -EFAULT; > > + if (copy_from_user(®ion, argp, sizeof(region))) > > + goto out; > > + > > + r = kvm_vm_ioctl_set_encrypted_region(kvm, ioctl, ®ion); > > + break; > > + } > > +#endif > > case KVM_GET_DIRTY_LOG: { > > struct kvm_dirty_log log; > > > > @@ -4842,6 +4898,7 @@ static long kvm_vm_ioctl(struct file *filp, > > r = kvm_vm_ioctl_get_stats_fd(kvm); > > break; > > default: > > +arch_vm_ioctl: > > It might be good to make this label conditional on > CONFIG_HAVE_KVM_PRIVATE_MEM, otherwise you get a warning if > CONFIG_HAVE_KVM_PRIVATE_MEM isn't defined. > > +#ifdef CONFIG_HAVE_KVM_PRIVATE_MEM > arch_vm_ioctl: > +#endif Right, as the bot already complains. Chao > > Cheers, > /fuad > > > > > > > r = kvm_arch_vm_ioctl(filp, ioctl, arg); > > } > > out: > > -- > > 2.25.1 > >