From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B66CECAAD2 for ; Mon, 29 Aug 2022 21:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9BCF6B0073; Mon, 29 Aug 2022 17:00:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4C226B0074; Mon, 29 Aug 2022 17:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3AE4940007; Mon, 29 Aug 2022 17:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A576D6B0073 for ; Mon, 29 Aug 2022 17:00:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79303A0B7F for ; Mon, 29 Aug 2022 21:00:34 +0000 (UTC) X-FDA: 79853848788.21.D26C56D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id EEB7F16005E for ; Mon, 29 Aug 2022 21:00:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E96C06105D; Mon, 29 Aug 2022 21:00:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC5CBC433C1; Mon, 29 Aug 2022 21:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661806832; bh=fqUkC9EH2QbQ4N3nK6D1pL+48iTcPXtlyjw2oH45q/4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YzLdMhsGQzY9Uo73EGzk5SeI3No3H/yNk7jOt1CK79Hn4+GmU34B45BNqijkEgJuy DriWl8f9UKgp7oNKDPPIuAntRS6ijcqsnwH6oySdBkq6g4Jyy707V4a8q6FKC3cq3q fnS4Fpjl6aJzx5MZQELGzEyfnA52DBLv2aHUmlpY= Date: Mon, 29 Aug 2022 14:00:30 -0700 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, Wei Xu , Huang Ying , Yang Shi , Davidlohr Bueso , Tim C Chen , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Johannes Weiner , jvgediya.oss@gmail.com, Bharata B Rao Subject: Re: [PATCH v2] mm/demotion: Expose memory tier details via sysfs Message-Id: <20220829140030.692cfd4dfbf7f9a8b282c951@linux-foundation.org> In-Reply-To: <20220829060745.287468-1-aneesh.kumar@linux.ibm.com> References: <20220829060745.287468-1-aneesh.kumar@linux.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YzLdMhsG; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661806834; a=rsa-sha256; cv=none; b=sDjnSAJtormLrRpNxhBxqvsFpxcG+6aPqRvebJLKCXW2mPB89KGSmYTxxge0FTN22zICu7 rA67BdlmKPaf6FsCmXd9AVC6dPw4Hm2z2OPCvlk8safCqfVKRrTI0dMEB18N77d1mkdn71 Ea9t7O3Ofofr7vlfi5j4tgvAgN7M5hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661806834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eJgpPC6tdyjXSNi8WwubpG7nW35rG6Jvu3WyoC9UMs4=; b=V+t2hQWMAJoifyoDaQ3nN/2N+3S/ek7EedhnRnKuN8JqOCi+KBtK6TPRVf1DNRpQjlaSCw TSF/rSYJKmiSw7zpBVtH+fmQaQlrP7V7miXQXy20saQ0r68g9blHoIYfJiXu5m0HY7+N3c B/Z25b38q8jmjTmQqPmnFg3lmItBnRc= X-Rspamd-Queue-Id: EEB7F16005E X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YzLdMhsG; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: r9doojwcmxfctstppr53bb7jxeg4uo35 X-HE-Tag: 1661806833-489793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 29 Aug 2022 11:37:45 +0530 "Aneesh Kumar K.V" wrote: > This patch adds /sys/devices/virtual/memory_tiering/ where all memory tier > related details can be found. All allocated memory tiers will be listed > there as /sys/devices/virtual/memory_tiering/memory_tierN/ > > The nodes which are part of a specific memory tier can be listed via > /sys/devices/virtual/memory_tiering/memory_tierN/nodes > > The abstract distance range value of a specific memory tier can be listed via > /sys/devices/virtual/memory_tiering/memory_tierN/abstract_distance > > A directory hierarchy looks like > :/sys/devices/virtual/memory_tiering$ tree memory_tier4/ > memory_tier4/ > ├── abstract_distance > ├── nodes > ├── subsystem -> ../../../../bus/memory_tiering > └── uevent > > All toptier nodes are listed via > /sys/devices/virtual/memory_tiering/toptier_nodes > > :/sys/devices/virtual/memory_tiering$ cat toptier_nodes > 0,2 > :/sys/devices/virtual/memory_tiering$ cat memory_tier4/nodes > 0,2 > :/sys/devices/virtual/memory_tiering$ cat memory_tier4/abstract_distance > 512 - 639 > > ... > > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -19,6 +19,7 @@ struct memory_tier { > * adistance_start .. adistance_start + MEMTIER_CHUNK_SIZE > */ > int adistance_start; > + struct device dev; > /* All the nodes that are part of all the lower memory tiers. */ > nodemask_t lower_tier_mask; > }; > @@ -36,6 +37,13 @@ static DEFINE_MUTEX(memory_tier_lock); > static LIST_HEAD(memory_tiers); > static struct node_memory_type_map node_memory_types[MAX_NUMNODES]; > static struct memory_dev_type *default_dram_type; > + > +#define to_memory_tier(device) container_of(device, struct memory_tier, dev) Please, only use a macro when a C function cannot be used. --- a/mm/memory-tiers.c~mm-demotion-expose-memory-tier-details-via-sysfs-fix +++ a/mm/memory-tiers.c @@ -38,7 +38,11 @@ static LIST_HEAD(memory_tiers); static struct node_memory_type_map node_memory_types[MAX_NUMNODES]; static struct memory_dev_type *default_dram_type; -#define to_memory_tier(device) container_of(device, struct memory_tier, dev) +static inline struct memory_tier *to_memory_tier(struct device *device) +{ + return container_of(device, struct memory_tier, dev); +} + static struct bus_type memory_tier_subsys = { .name = "memory_tiering", .dev_name = "memory_tier", If only so it checks the type of `device'.