From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105CFC0502A for ; Sat, 27 Aug 2022 23:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CE2494000B; Sat, 27 Aug 2022 19:00:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7561E940007; Sat, 27 Aug 2022 19:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D05694000B; Sat, 27 Aug 2022 19:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48081940007 for ; Sat, 27 Aug 2022 19:00:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 16D321412CA for ; Sat, 27 Aug 2022 23:00:49 +0000 (UTC) X-FDA: 79846894218.05.208A75A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 74A66C0023 for ; Sat, 27 Aug 2022 23:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661641247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qI/TRb7yyY9YDzUGJ2R7gXKC3BcSTndOOR+KS4v4hNo=; b=KKJPOxpPC46MqyrsesDDMxAuJY2JQ2C4GYtJCJLFakplH+cVj8sHpnL0AZmNr0/MN/yh4u E8UZI+43McYxxilBiw8bg9k6wPqQ/ZfAe/Q+3jM3Y+L5K5yTgso5Hv0rRr/MnzbtULV2sP F+qfZa4BykiQTKJXn3BPP40nbgOXqhA= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-133-VKs7hQDRMpOQgjoaOYdUKA-1; Sat, 27 Aug 2022 19:00:46 -0400 X-MC-Unique: VKs7hQDRMpOQgjoaOYdUKA-1 Received: by mail-pl1-f199.google.com with SMTP id c12-20020a170902d48c00b0017471123021so1547611plg.15 for ; Sat, 27 Aug 2022 16:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=qI/TRb7yyY9YDzUGJ2R7gXKC3BcSTndOOR+KS4v4hNo=; b=0BAcxTaPBFrzGx4V0gScySVBVIqyrcbwU9on0m8F6MCajUlexjJEQdDbkS0iotoAEz p2MbFly7s2AwQ8wCiLtsVQHGkMXuj8zUU+k1VkSpjYMm+wSE08+V8hmOBW9BpjUczG03 rDzdkbUKpZGw8b4jl7WpkS5EQR8BPewyIBo10kR5mEOEkXrCBN1caFaCp40PR1Ihqm4w rYQ03F+rkEevZ5wnxhD+ocKEit0hMow0nHyMsGA5FN81vJL0bQFXw3uJUjoA8FeADXdU //ECFEawaZKYAa1zRthfV1JZUnsVZONlMZe3VP/QvianAhTGvybfIqFiGZ85dXiIbMRH y01w== X-Gm-Message-State: ACgBeo220iLRTu/ItFZErN54MqZwWf0uz/8Nh/oRMI9Qr8tHZxdVgoet 4xB9Uv18q0eSXCDxrwiHsLdGuzGdNRLuRUNc8Zoolfdp4phnZ/KM5IuNEQtVhitqzh83KDPR5xB 41OgMOVC5SiU= X-Received: by 2002:a17:90a:4801:b0:1fa:98ec:fa2 with SMTP id a1-20020a17090a480100b001fa98ec0fa2mr10841746pjh.41.1661641245182; Sat, 27 Aug 2022 16:00:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR6vzdYchRF2TEFkGashATDOr6JPFXLJkrFtu01uhG5n3edGz2/gx1GA+3F8PPFkdA+TInAA5w== X-Received: by 2002:a17:90a:4801:b0:1fa:98ec:fa2 with SMTP id a1-20020a17090a480100b001fa98ec0fa2mr10841735pjh.41.1661641244957; Sat, 27 Aug 2022 16:00:44 -0700 (PDT) Received: from xps13.. ([240d:1a:c0d:9f00:4f2f:926a:23dd:8588]) by smtp.gmail.com with ESMTPSA id 23-20020a631257000000b0042988a04bfdsm3647844pgs.9.2022.08.27.16.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Aug 2022 16:00:44 -0700 (PDT) From: Shigeru Yoshida To: akpm@linux-foundation.org Cc: apopple@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shigeru Yoshida , Dan Carpenter Subject: [PATCH] mm/gup.c: Fix uninitialized return value on __gup_longterm_locked() Date: Sun, 28 Aug 2022 08:00:37 +0900 Message-Id: <20220827230037.78876-1-syoshida@redhat.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661641248; a=rsa-sha256; cv=none; b=8Lkkmv4vy6HtBk27GFg1LFzwkQS6aKmZfKV4GN4ON+20is+AySGLWULSPXvMI+PIQV+6mU cBDdmFcIflhrobkBYLvwS6+j9FQw/cmKySc2VyvzemB0F24/ngOAR5JUcoueRnpCcZhJxm WwNAw1za9VsjG/gJgpRqZ14EBCmfrAU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKJPOxpP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of syoshida@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=syoshida@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661641248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=qI/TRb7yyY9YDzUGJ2R7gXKC3BcSTndOOR+KS4v4hNo=; b=tPXlwQWguoUo+H7vlqvUSgORtk3lnRAaCoAtd3fMYXh4dOttr2N1SVPe8wdMqWgg8gEpGN GOR7EDag4Es8C3XUOwpuQnevmjHraowL11XSgjZQeUomWgiXBezkJfy9hfve6xHM766CkS SWeVUDwxLfHNwxJ2lgp02sTrOhWoop4= X-Rspamd-Queue-Id: 74A66C0023 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KKJPOxpP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of syoshida@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=syoshida@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: 9gypryjnyjq99j7xi17xcexu3hg9wkxj X-HE-Tag: 1661641248-556963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Shigeru Yoshida In __gup_longterm_locked(), it returns uninitialized value if __get_user_pages_locked() fails on the first iteration of the loop since rc is not initialized. This patch fixes this issue by properly returning error code if __get_user_pages_locked() fails. Fixes: 11147539df44 (mm/gup.c: Fix return value for __gup_longterm_locked()) Cc: Alistair Popple Reported-by: Dan Carpenter Signed-off-by: Shigeru Yoshida --- mm/gup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/gup.c b/mm/gup.c index ad59c796d4d3..66d8619e02ad 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2110,8 +2110,10 @@ static long __gup_longterm_locked(struct mm_struct *mm, nr_pinned_pages = __get_user_pages_locked(mm, start, nr_pages, pages, vmas, NULL, gup_flags); - if (nr_pinned_pages <= 0) + if (nr_pinned_pages <= 0) { + rc = nr_pinned_pages; break; + } rc = check_and_migrate_movable_pages(nr_pinned_pages, pages); } while (rc == -EAGAIN); memalloc_pin_restore(flags); -- 2.37.2