From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE0DECAAD1 for ; Sat, 27 Aug 2022 21:24:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 670E86B0073; Sat, 27 Aug 2022 17:24:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62110940007; Sat, 27 Aug 2022 17:24:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50F1D6B0075; Sat, 27 Aug 2022 17:24:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 42C816B0073 for ; Sat, 27 Aug 2022 17:24:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 12D9340810 for ; Sat, 27 Aug 2022 21:24:09 +0000 (UTC) X-FDA: 79846650618.12.EA93BB0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 8CCF9140045 for ; Sat, 27 Aug 2022 21:24:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8E0BB807EB; Sat, 27 Aug 2022 21:24:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF142C433D6; Sat, 27 Aug 2022 21:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661635445; bh=fXm1bSisSqGSY59/IcPlbBIAN4KpPKVMt1s0HfiiqZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TOjPeSlXP0tsnvP0jKEqd31BB9DQ4JUN2Mk4n0dAGwdwP41RLy6jJ3+wjPXLIWucE HvHhHf6FRQejJBP4KvFlJG3RJ7dqzNd5O3u6jMl7hHaO8obYaKOH84sMYJRhipKa51 WsqViPetJNdaD1+XvnJf/G8bWQEh45dcWkQ0ZTPFp4snycbTd/sH9hunfXAXpUKs7c tVkCZKW6oUf+qR1s7nepZrXE7dVbt8xkPLuwf3wTmA81pG6jFHYaG4oBUjXLLfpQ2O tvo33aTHaH2II/ad1jfposZntyhGKbl1fvVjySmk+IcfE2M+9njfa4To5LI4zLmjs0 lCUOEAANikG5w== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH v2 1/2] mm/damon: simplify the parameter passing for 'check_accesses' Date: Sat, 27 Aug 2022 21:24:01 +0000 Message-Id: <20220827212401.50416-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1661590971-20893-2-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661635448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+nQKsH4khWL4raKf1iuuQeFjj5jS1nXqys23R+GSyRk=; b=MGDEnBsYrySqB9u/rzlZT0H3/c0sTlr56ds5oCkIRyr1vp55+jFrrYB5n5fd7muqawJxZd /ehYYUkOWgwLr6T3UYuRZ6OE140CvThcio1nxahORpgVfW6jP0gn+bDeHxetoyrJ+S4I1C Gzs2ueY/u55teRBZvo+IQH04CDXswx0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TOjPeSlX; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661635448; a=rsa-sha256; cv=none; b=Zsj9H/gfC7z7xStsk7hQlGleMCucQH/B38APiS6c1Wd5xT2lg3at8Pw7NA1PfM6DFzjskW IbeqD6IyTNGxGyeEb/Is5or+k+S2oeN/ojSkjXkBMbKFWk8g3/+RrrfVhxya0VqlQhScMH KgWkzr3XtG5C1YwSQtDKorFDezrWUOk= X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TOjPeSlX; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-Stat-Signature: 8racxwqpta8p87rjqwnwzn6yyhur4e6t X-Rspamd-Queue-Id: 8CCF9140045 X-HE-Tag: 1661635448-273784 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Sat, 27 Aug 2022 17:02:50 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The parameter 'struct damon_ctx *ctx' isn't used in the functions > __damon_{p,v}a_check_access(), so we can remove it and simplify the > parameter passing. > > Signed-off-by: Kaixu Xia Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/paddr.c | 5 ++--- > mm/damon/vaddr.c | 6 +++--- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index dc131c6a5403..6b0d9e6aa677 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -166,8 +166,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) > return result.accessed; > } > > -static void __damon_pa_check_access(struct damon_ctx *ctx, > - struct damon_region *r) > +static void __damon_pa_check_access(struct damon_region *r) > { > static unsigned long last_addr; > static unsigned long last_page_sz = PAGE_SIZE; > @@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx) > > damon_for_each_target(t, ctx) { > damon_for_each_region(r, t) { > - __damon_pa_check_access(ctx, r); > + __damon_pa_check_access(r); > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > } > } > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 3c7b9d6dca95..e481f81c3efb 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -532,8 +532,8 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, > * mm 'mm_struct' for the given virtual address space > * r the region to be checked > */ > -static void __damon_va_check_access(struct damon_ctx *ctx, > - struct mm_struct *mm, struct damon_region *r) > +static void __damon_va_check_access(struct mm_struct *mm, > + struct damon_region *r) > { > static struct mm_struct *last_mm; > static unsigned long last_addr; > @@ -568,7 +568,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) > if (!mm) > continue; > damon_for_each_region(r, t) { > - __damon_va_check_access(ctx, mm, r); > + __damon_va_check_access(mm, r); > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > } > mmput(mm); > -- > 2.27.0