From: Andrew Morton <akpm@linux-foundation.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>, Jan Kara <jack@suse.cz>,
Logan Gunthorpe <logang@deltatee.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user pages
Date: Sat, 27 Aug 2022 17:12:20 -0700 [thread overview]
Message-ID: <20220827171220.fa2f21f6b22c6d3047857381@linux-foundation.org> (raw)
In-Reply-To: <4c6903d4-0612-5097-0005-4a9420890826@nvidia.com>
On Sat, 27 Aug 2022 16:59:32 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> Anyway, I'll change my patch locally for now, to this:
>
> static inline void dio_w_unpin_user_pages(struct page **pages,
> unsigned long npages)
> {
> /* Careful, release_pages() uses a smaller integer type for npages: */
> if (WARN_ON_ONCE(npages > (unsigned long)INT_MAX))
> return;
>
> release_pages(pages, (int)npages);
> }
Well, it might be slower. release_pages() has a ton of fluff.
As mentioned, the above might be faster if the pages tend
to have page_count()==1??
next prev parent reply other threads:[~2022-08-28 0:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 8:36 [PATCH 0/6] convert most filesystems to pin_user_pages_fast() John Hubbard
2022-08-27 8:36 ` [PATCH 1/6] mm/gup: introduce pin_user_page() John Hubbard
2022-08-29 12:07 ` David Hildenbrand
2022-08-29 19:33 ` John Hubbard
2022-08-30 12:17 ` David Hildenbrand
2022-08-30 21:42 ` John Hubbard
2022-08-31 0:06 ` John Hubbard
2022-08-27 8:36 ` [PATCH 2/6] block: add dio_w_*() wrappers for pin, unpin user pages John Hubbard
2022-08-27 22:27 ` Andrew Morton
2022-08-27 23:59 ` John Hubbard
2022-08-28 0:12 ` Andrew Morton [this message]
2022-08-28 0:31 ` John Hubbard
2022-08-28 1:07 ` John Hubbard
2022-08-27 8:36 ` [PATCH 3/6] iov_iter: new iov_iter_pin_pages*() routines John Hubbard
2022-08-27 22:46 ` Al Viro
2022-08-27 22:48 ` John Hubbard
2022-08-27 8:36 ` [PATCH 4/6] block, bio, fs: convert most filesystems to pin_user_pages_fast() John Hubbard
2022-08-27 8:36 ` [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages John Hubbard
2022-08-27 22:48 ` Al Viro
2022-08-27 23:55 ` John Hubbard
2022-08-28 0:38 ` Al Viro
2022-08-28 0:39 ` Al Viro
2022-08-28 0:46 ` John Hubbard
2022-08-29 4:59 ` John Hubbard
2022-08-29 16:08 ` Jan Kara
2022-08-29 19:59 ` John Hubbard
2022-08-31 9:43 ` Jan Kara
2022-08-31 18:02 ` John Hubbard
2022-09-01 0:38 ` Al Viro
2022-09-01 9:06 ` Jan Kara
2022-08-27 8:36 ` [PATCH 6/6] fuse: convert direct IO paths to use FOLL_PIN John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827171220.fa2f21f6b22c6d3047857381@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jhubbard@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox