From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFBFECAAD5 for ; Sat, 27 Aug 2022 22:13:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34FA0940008; Sat, 27 Aug 2022 18:13:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D71B940007; Sat, 27 Aug 2022 18:13:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 178AB940008; Sat, 27 Aug 2022 18:13:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 03C38940007 for ; Sat, 27 Aug 2022 18:13:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2BFF120224 for ; Sat, 27 Aug 2022 22:13:09 +0000 (UTC) X-FDA: 79846774098.09.C76EDF6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 755B440050 for ; Sat, 27 Aug 2022 22:13:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91BCF60EB2; Sat, 27 Aug 2022 22:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8451BC433B5; Sat, 27 Aug 2022 22:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661638387; bh=4j9dWv3SalI9XL4QHA6egNN0lDV1LYcP+fce7U59F+g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pTkckR3QSqI9EkRpQV/OQuwsYmSdo2Z4DWMItgvPyVBMkFcsWh4PAmeYpAA4I5i89 tMun4/ptY47kdq7YIcsFy2kYQ7u8QCRAQE3P1qNgDznZHGR6edqLLr+94FsUH8pAC/ 6hK0d4lnxyCUAbRCCKJFJ8T7IaEw1lE5NICP8M2Q= Date: Sat, 27 Aug 2022 15:13:06 -0700 From: Andrew Morton To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Nathan Chancellor , "Christoph Hellwig" , , , Kefeng Wang , Konrad Rzeszutek Wilk Subject: Re: [PATCH -next v3 0/5] Delay the initializaton of zswap Message-Id: <20220827151306.879ec27ea7314a543c5f60f6@linux-foundation.org> In-Reply-To: <20220827104600.1813214-1-liushixin2@huawei.com> References: <20220827104600.1813214-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661638389; a=rsa-sha256; cv=none; b=LE7tcYdi6P+aqAVPmqieBDG9E61nJzxWd7lQn8A6QNdhJUuI1rD58jckMPEZ3ZuME6FVPt uMSyzovzCPn5xq0fRzawbm8pRVK0IltjAkLOZVkYF2qnm/s5D1XkfQggvt/KhDz3xFcPzy uQgENwBHn90fiKvzVJrdPKdBicRKOt4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pTkckR3Q; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661638389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vuh++y0dVWXizgfL+6jqjx/m+ospQ9y7nNdrBAZwWkQ=; b=66R8X0Mrx1Y/giz2eVFnr/YCSVDj+p40lC33jwm5Nng08b7zH9F4F2qeSQVfJU3s0YTqak DGDCQyJcHtErpw4PXg3CpqOoN6UwJeWjpd4l+Iw0Drsj7XpbZTNOiSNe9nPQGwLApXqJ0n i8OF47fI35euxtldT+OyLtAuFoQ3KG0= X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pTkckR3Q; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam10 X-Stat-Signature: fm7r1ybwhk3gird4bzi6kaq47jybj68j X-Rspamd-Queue-Id: 755B440050 X-HE-Tag: 1661638389-116763 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 27 Aug 2022 18:45:55 +0800 Liu Shixin wrote: > In the initialization of zswap, about 18MB memory will be allocated for > zswap_pool. Since not all users use zswap, the memory may be wasted. Save > the memory for these users by delaying the initialization of zswap to > first enablement. > > v2->v3: Fix frontswap_ops NULL reported by Nathan and add init for online > swap device in backend register. > v1->v2: Change init_zswap to zswap_init suggested by Andrew. Thanks. Konrad, could you please take a look for the frontswap changes?