From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15146C0502C for ; Sat, 27 Aug 2022 05:50:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4506940007; Sat, 27 Aug 2022 01:50:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F4856B0074; Sat, 27 Aug 2022 01:50:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BC01940007; Sat, 27 Aug 2022 01:50:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7DEE96B0073 for ; Sat, 27 Aug 2022 01:50:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52C61140236 for ; Sat, 27 Aug 2022 05:50:52 +0000 (UTC) X-FDA: 79844298744.11.F1D3D22 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf08.hostedemail.com (Postfix) with ESMTP id 30D7F160035 for ; Sat, 27 Aug 2022 05:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661579451; x=1693115451; h=date:from:to:cc:subject:message-id:mime-version; bh=iTIDnPUVNynQy5bkUrHHmocR0AYMrXJJvvAZPIRVHbM=; b=YO4G6J9HvP36FmbeJf7TSF3WS3VYQAXQN71EvBXp8jBwbw3mhBjvhLWL WkyFadjLyNpg6GKgQU1oldGVKV4FzJkkAV51YQVPWKrHyzlTJTl3xEbIp JSQ0kJjHgydn+7lGpiBIF8B7KKRmYeIbgrq3MXBW9hus2v0DGGqdMjuhF ya0ox2psHj7PXBlHfE27Ic8WCQLFW3reoIac/YHimBA30QWTamL2dA2b9 wpivTin/nr5pAJXWHdqAVmUL505ZNBYSgD8tKOxDftroXaEokUjeY0l8Z yXLNgZ2ZihdD3Czb1So5+jht34ya0mW+F1XOFhYANa8Pt9sjxFZsWDNon w==; X-IronPort-AV: E=McAfee;i="6500,9779,10451"; a="358605268" X-IronPort-AV: E=Sophos;i="5.93,267,1654585200"; d="scan'208";a="358605268" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2022 22:50:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,267,1654585200"; d="scan'208";a="753097141" Received: from lkp-server01.sh.intel.com (HELO 71b0d3b5b1bc) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 26 Aug 2022 22:50:39 -0700 Received: from kbuild by 71b0d3b5b1bc with local (Exim 4.96) (envelope-from ) id 1oRoiN-00012p-0e; Sat, 27 Aug 2022 05:50:39 +0000 Date: Sat, 27 Aug 2022 13:50:32 +0800 From: kernel test robot To: Roi Dayan Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Saeed Mahameed , Mark Bloch , Maor Dickman Subject: [linux-next:master 2212/3682] drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false Message-ID: <202208271304.MimlzZvl-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=YO4G6J9H; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661579452; a=rsa-sha256; cv=none; b=iQGMEmiP62PlAmKBqw8t+J/pL9QRMTFFcEREQpkGiH5itsEidJpTqVyDTI0q4/sET1woxa Va/PGKRLmVF9tntf1ze739pDe/vlpDnRVe/OBtpPeyb1l3l9WXlF4KvYECt2XQPXH6Paxi 0a+2w/hqZ8vb6TQ4LP/Jkh7PSC6xZ3U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661579452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=e8/mfvif8nLtVzrvoqORx5LC/yY3aVLDV84hLpUaphk=; b=WyJovaTTuMr/9wiaxYhcaTAtQZKNfc4QZkR4X8DvQjccx/VQW+XkPur7E/PvFVi8gfEUOy tX5k7vvLKseIJAB5n2vhoYpJxjxPLMslfSwHUsjSSRM3tFOmajNlG3AV7hgT3oYeuHgGzI hWHhb8zBwodOgKrQjNsbjMJS5PUppSU= X-Rspam-User: X-Stat-Signature: q6wnikcidejwsg6bduqq999fpz85oehg X-Rspamd-Queue-Id: 30D7F160035 Authentication-Results: imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=YO4G6J9H; spf=pass (imf08.hostedemail.com: domain of lkp@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam09 X-HE-Tag: 1661579450-908479 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 8d0c42c9e80791e8baba2932d2cbd2dcead50d47 commit: 430e2d5e2a982e6f86866762e6d6eb78191f9677 [2212/3682] net/mlx5: E-Switch, Move send to vport meta rule creation config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220827/202208271304.MimlzZvl-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=430e2d5e2a982e6f86866762e6d6eb78191f9677 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout 430e2d5e2a982e6f86866762e6d6eb78191f9677 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ drivers/net/ethernet/mellanox/mlxsw/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:489:9: note: uninitialized use occurs here return err; ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:481:2: note: remove the 'if' if its condition is always true if (IS_ERR(flow_rule)) { ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:474:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated. vim +481 drivers/net/ethernet/mellanox/mlx5/core/en_rep.c 465 466 static int 467 mlx5e_rep_add_meta_tunnel_rule(struct mlx5e_priv *priv) 468 { 469 struct mlx5_eswitch *esw = priv->mdev->priv.eswitch; 470 struct mlx5e_rep_priv *rpriv = priv->ppriv; 471 struct mlx5_eswitch_rep *rep = rpriv->rep; 472 struct mlx5_flow_handle *flow_rule; 473 struct mlx5_flow_group *g; 474 int err; 475 476 g = esw->fdb_table.offloads.send_to_vport_meta_grp; 477 if (!g) 478 return 0; 479 480 flow_rule = mlx5_eswitch_add_send_to_vport_meta_rule(esw, rep->vport); > 481 if (IS_ERR(flow_rule)) { 482 err = PTR_ERR(flow_rule); 483 goto out; 484 } 485 486 rpriv->send_to_vport_meta_rule = flow_rule; 487 488 out: 489 return err; 490 } 491 -- 0-DAY CI Kernel Test Service https://01.org/lkp