From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D0CAECAAD4 for ; Sat, 27 Aug 2022 01:43:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CBDF940009; Fri, 26 Aug 2022 21:43:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57B9D940007; Fri, 26 Aug 2022 21:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4699D940009; Fri, 26 Aug 2022 21:43:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 35692940007 for ; Fri, 26 Aug 2022 21:43:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EE8D280573 for ; Sat, 27 Aug 2022 01:43:30 +0000 (UTC) X-FDA: 79843675380.05.75FE2AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id A13128002F for ; Sat, 27 Aug 2022 01:43:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BE8161CE3; Sat, 27 Aug 2022 01:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C968FC433D7; Sat, 27 Aug 2022 01:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1661564609; bh=ZRrgfPWyUv61JlX8iDzy2PZiGjGRvRzl+FOAReOkttk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OHZOEdZr+3pm7ImsHzxQeWDoenMwByLK5b8Zm/YlaJS5271UR1A+xNersydHjlUmf MI1ICUUvwa/mumTeArajp/5smKe6mwi+1kXabJE/O+0FmnqOXQ+/npI5PwUOVX4YgW 6SF2IwHvaK92VxJ1JnElSB8HB7RIUGcYhrSD752g= Date: Fri, 26 Aug 2022 18:43:28 -0700 From: Andrew Morton To: Nathan Chancellor Cc: Liu Shixin , Seth Jennings , Dan Streetman , Vitaly Wool , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/3] mm/zswap: delay the initializaton of zswap until the first enablement Message-Id: <20220826184328.3bce63050a1f82e9242580df@linux-foundation.org> In-Reply-To: References: <20220825142037.3214152-1-liushixin2@huawei.com> <20220825142037.3214152-3-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661564610; a=rsa-sha256; cv=none; b=ezlmiBeE7ohhRqaeaMZH33kUgtZs6wA3fqXd6I6ynhduI62ktLHLQ10syDSW/31tH6ZW8k 8SDJ+nligvtPhyfjoqUSJZwjYIq8n9CBKKbANjGLijeucUAGP/vvBKaPEgYo39h2BNce23 aBpmc1pkM6nWvnte0W4JdfDn2NvPQHM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OHZOEdZr; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661564610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nW4xOXtK1LsAwF21QsqD0QLA/0ZBSGG7E4iecoHOTP8=; b=aXEhkPhcSDczSbWN1mAVaiheh1Dqsr9HukkN+RxBZLl/t04GmmBQqOne7wpY29/+V8Kf8k dPMb727h+vm75Vm4xspu+pmMITP++h0a1yzLD3zU7zeJXNZvRongR6aNXe8obuwjG1qqyd 6NIEpaGN04wffRMRMu7TgIn46LRQXaY= X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OHZOEdZr; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam10 X-Stat-Signature: 7rj661cfyw8i4fgghhithhr6bxpuiidg X-Rspamd-Queue-Id: A13128002F X-HE-Tag: 1661564610-760281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 26 Aug 2022 13:25:41 -0700 Nathan Chancellor wrote: > Hi Liu, > > On Thu, Aug 25, 2022 at 10:20:36PM +0800, Liu Shixin wrote: > > In the initialization of zswap, about 18MB memory will be allocated for > > zswap_pool in my machine. Since not all users use zswap, the memory may be > > wasted. Save the memory for these users by delaying the initialization of > > zswap to first enablement. > > > > ... > > This change is in -next as commit 22100432cf14 ("mm/zswap: delay the > initializaton of zswap until the first enablement"). I just bisected my > arm64 test system running Fedora failing to boot due to that commit, > with the following stack trace: > Thanks. Sorry. I dropped the series.