From: Andrew Morton <akpm@linux-foundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Liu Shixin <liushixin2@huawei.com>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 2/3] mm/zswap: delay the initializaton of zswap until the first enablement
Date: Fri, 26 Aug 2022 18:43:28 -0700 [thread overview]
Message-ID: <20220826184328.3bce63050a1f82e9242580df@linux-foundation.org> (raw)
In-Reply-To: <YwksRZPIfXmlOmHR@dev-arch.thelio-3990X>
On Fri, 26 Aug 2022 13:25:41 -0700 Nathan Chancellor <nathan@kernel.org> wrote:
> Hi Liu,
>
> On Thu, Aug 25, 2022 at 10:20:36PM +0800, Liu Shixin wrote:
> > In the initialization of zswap, about 18MB memory will be allocated for
> > zswap_pool in my machine. Since not all users use zswap, the memory may be
> > wasted. Save the memory for these users by delaying the initialization of
> > zswap to first enablement.
> >
>
> ...
>
> This change is in -next as commit 22100432cf14 ("mm/zswap: delay the
> initializaton of zswap until the first enablement"). I just bisected my
> arm64 test system running Fedora failing to boot due to that commit,
> with the following stack trace:
>
Thanks. Sorry. I dropped the series.
next prev parent reply other threads:[~2022-08-27 1:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 14:20 [PATCH -next 0/3] Delay the initializaton of zswap Liu Shixin
2022-08-25 14:20 ` [PATCH -next 1/3] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Liu Shixin
2022-08-25 14:20 ` [PATCH -next 2/3] mm/zswap: delay the initializaton of zswap until the first enablement Liu Shixin
2022-08-26 2:01 ` Andrew Morton
2022-08-26 20:25 ` Nathan Chancellor
2022-08-27 1:43 ` Andrew Morton [this message]
2022-08-27 2:01 ` Kefeng Wang
2022-08-27 10:21 ` Liu Shixin
2022-08-25 14:20 ` [PATCH -next 3/3] mm/zswap: skip confusing print info Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826184328.3bce63050a1f82e9242580df@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=nathan@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox