From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5961ECAAA3 for ; Fri, 26 Aug 2022 17:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FABE6B0074; Fri, 26 Aug 2022 13:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AB226B0075; Fri, 26 Aug 2022 13:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07224940007; Fri, 26 Aug 2022 13:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E7A566B0074 for ; Fri, 26 Aug 2022 13:08:26 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B95671609A7 for ; Fri, 26 Aug 2022 17:08:26 +0000 (UTC) X-FDA: 79842377412.31.3E3D8E3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 2B75C1C0020 for ; Fri, 26 Aug 2022 17:08:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4F526B830A9; Fri, 26 Aug 2022 17:08:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69C1CC433C1; Fri, 26 Aug 2022 17:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661533702; bh=JNWgzqw2tKu/IX/8pc1hZ71PjLuc8vnbXaaTYzYOVqo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rDfBAJ8bVPWABbCjjYIv+k1fEpTx6a0eLEdqz6XZPoY4zq1SYEerpdmETH7OYZt9M skgKatTSN3AEbor1Jpr5W4kAg2K6F/3J41YYTw6WdXJTffyFhCkAq0pH+Haqp52TCj cBvv1jI+l6WqHrm7h+021WQI8cG0F9ml5IKlfAKV4oqMzejBdSdbC9naewR1liiSc5 h6m3rHVBLI7u5INQH6nCWf2ol7XuKMpMKQA4SpQBJ48A/ZGBD/x28RAmYIHyfFjwwG e5j1wkbTWkitMUR/gUjdTHiyQ/41Z1kHRD7psMqHbb9DjwJshs20F/R46RFYK7CJR3 R0zOBzVXNl8kQ== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH 1/2] mm/damon: simplify the parameter passing for 'check_accesses' Date: Fri, 26 Aug 2022 17:08:18 +0000 Message-Id: <20220826170818.50050-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1661502678-19336-2-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rDfBAJ8b; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661533705; a=rsa-sha256; cv=none; b=t/s300fYW4Z6rTgjF1fE1xg6aQ81hEyCOv2aAhPboG3dfNW8kcSAsjLR7Ew8y08qzfDjPd u9DrJH5i8Iw/fj1MEDexzjgvm1umkter/GV4ioebanFHCCK427tTZzm9cZayaErRI892Hq jEG1WB8UpNyQj1/WVHyMYRJlslK7PEw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661533705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/vDAcEqCptB8t1pA3A1u7PFgBCWmpDgbpRvi9i9mGjA=; b=Qq1prgi//QXPfNTayiJW7J8Pdth9VDANAq4FJONMtBorQ5141+BF4udWranJZz0p8pTfht pj0m5pi5Srklw/WJUI4w4h6wDBt79H3GUvnyMGz464ZyRUi3Yh7fRuorlTDPVus06TyfXh rpglq0oAeCHQRKAlbFKo0NWzBhZ/sB4= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rDfBAJ8b; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam07 X-Stat-Signature: nbdtkapafc7p3ywwp1o4hxxeq7qz3doc X-Rspamd-Queue-Id: 2B75C1C0020 X-HE-Tag: 1661533705-488166 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Fri, 26 Aug 2022 16:31:17 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The parameter 'struct damon_ctx *ctx' is unnecessary in damon > 'check_accesses' callback operation, so we can remove it. Thank you for the finding, but this wording is not 100% perfect, strictly speaking. The callback operations indeed use the parameter, but the internal functions called by the callbacks (__damon_{p,v}a_check_access()) aren't. Could you please update the message? > > Signed-off-by: Kaixu Xia > --- > mm/damon/paddr.c | 5 ++--- > mm/damon/vaddr.c | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index dc131c6a5403..6b0d9e6aa677 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -166,8 +166,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) > return result.accessed; > } > > -static void __damon_pa_check_access(struct damon_ctx *ctx, > - struct damon_region *r) > +static void __damon_pa_check_access(struct damon_region *r) > { > static unsigned long last_addr; > static unsigned long last_page_sz = PAGE_SIZE; > @@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx) > > damon_for_each_target(t, ctx) { > damon_for_each_region(r, t) { > - __damon_pa_check_access(ctx, r); > + __damon_pa_check_access(r); > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > } > } > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 3c7b9d6dca95..c8c2f306bb6d 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -532,8 +532,7 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, > * mm 'mm_struct' for the given virtual address space > * r the region to be checked > */ > -static void __damon_va_check_access(struct damon_ctx *ctx, > - struct mm_struct *mm, struct damon_region *r) > +static void __damon_va_check_access(struct mm_struct *mm, struct damon_region *r) I still prefer 80 columns rule[1]. Could you please break this line? [1] https://docs.kernel.org/process/coding-style.html#breaking-long-lines-and-strings > { > static struct mm_struct *last_mm; > static unsigned long last_addr; > @@ -568,7 +567,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) > if (!mm) > continue; > damon_for_each_region(r, t) { > - __damon_va_check_access(ctx, mm, r); > + __damon_va_check_access(mm, r); > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > } > mmput(mm); > -- > 2.27.0 Thanks, SJ