From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F43ECAA2D for ; Thu, 25 Aug 2022 16:06:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C46F66B0074; Thu, 25 Aug 2022 12:06:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6496B0075; Thu, 25 Aug 2022 12:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A97EC940007; Thu, 25 Aug 2022 12:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9928E6B0074 for ; Thu, 25 Aug 2022 12:06:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5C7C3160335 for ; Thu, 25 Aug 2022 16:06:54 +0000 (UTC) X-FDA: 79838593548.11.9023A9E Received: from dog.birch.relay.mailchannels.net (dog.birch.relay.mailchannels.net [23.83.209.48]) by imf27.hostedemail.com (Postfix) with ESMTP id F14A140014 for ; Thu, 25 Aug 2022 16:06:51 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E809C5010C8; Thu, 25 Aug 2022 16:06:49 +0000 (UTC) Received: from pdx1-sub0-mail-a201 (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2A41A501198; Thu, 25 Aug 2022 16:06:49 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1661443609; a=rsa-sha256; cv=none; b=sbkVwbMWptZkRbJ7TzmKNWXybDGaCPt0JhxS/10JwOso9+sBYV1hRWFQ6V7klWclCTxakR 4wrVapl2kLqwKmuANhbS4cEuNP0TrnKZpIZOPTgWLC90c8R0im6rL4r3entt1NcrDQyk9e LNdqdiER5E6acj9vKTvefV4A3HFm1toTh341bbWR5F4W8+ZYzQI9Yz6Lyvdrz6dbJ7BXgN bKAEEEWeB5eAoZc5x/LxjRkDQZKLA5ntvskSzPuHX1igFWMusfQdympDPVrTXzvYha/z0E TECuD2qqRjFCsSXdJlW/x38lgVQPOf5+8BX4K5V2sd6zah5x3g1+WEXPZKmVpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1661443609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anopUDp5ozStsOp7m/DsKCZ3eEuLLawyiGqKJA3EYfo=; b=lGt2FG4gSrVInOeojCUUTARhFwV7wqdut9UVpfq4CHQCCuSSH0YcLwQxMv/HDKSJ516rVe Feqkhxq2v6qlp6ljPjBLaPFLxk30Dq0l4tYP4iVH6W+vBXno0YNy6zh/xjBsW4sXzL2uYu VjLFN1WPvd8CjUhfHLv2XgaFAYZFXzAGSgSdpoHq83KLPeof0dehKUHqPdnX/iNdWZj+KN TzqFeCm306oyckPIFIBf7vvCUuoyDMbBMiFnafQAddrc5C1/q6Qgq2sPLM4xPF5R/vj0dC hfUPyFuW5yF1lrn/7TgYRz8sdBfncfiDcI1Sg3JG/iljCBpwUwtGNbje3LK1lQ== ARC-Authentication-Results: i=1; rspamd-75b4464bd-zzmqr; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Coil-Power: 71a32de35b4d361d_1661443609470_570315058 X-MC-Loop-Signature: 1661443609470:3773033028 X-MC-Ingress-Time: 1661443609470 Received: from pdx1-sub0-mail-a201 (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.147.32 (trex/6.7.1); Thu, 25 Aug 2022 16:06:49 +0000 Received: from offworld (unknown [104.36.31.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a201 (Postfix) with ESMTPSA id 4MD7BV3bTyz8T; Thu, 25 Aug 2022 09:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1661443603; bh=anopUDp5ozStsOp7m/DsKCZ3eEuLLawyiGqKJA3EYfo=; h=Date:From:To:Cc:Subject:Content-Type; b=FCqflbpmhi7z3AuP4xA5X4muM6qXt/oe/drsE4vIXd663b2lVCrikVJQX2BSzgOIp ovWp/KS8Gb6VnLzKAhntjltZ2MFkpmIuiYY/nDimA+jQvbEmR7HITtmArfn3GgBJLy LiE+L92SLXCdojqBXF0A3DWMYormLFC8KbMbBf+soq4lIBVJ4JOnmezbBDf1ZCIh+U 90MpeWwMbC7jwb+rMn0QJN5kV2gipxlvjqrFc2et00AlOoKVkjhIg1caQfqIosM2zw mAaSQB9lDufTsOuKhLdmmOTIiD3QtO63pNqDPwcZVBZAo2+6Zh82WAfJ6R2CVOGGZT lu5QcLjQtmHPg== Date: Thu, 25 Aug 2022 08:48:30 -0700 From: Davidlohr Bueso To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "Matthew Wilcox (Oracle)" Subject: Re: [PATCH v13 36/70] xtensa: remove vma linked list walks Message-ID: <20220825154830.jb46malqyy3qme3e@offworld> Mail-Followup-To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "Matthew Wilcox (Oracle)" References: <20220822150128.1562046-1-Liam.Howlett@oracle.com> <20220822150128.1562046-37-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220822150128.1562046-37-Liam.Howlett@oracle.com> User-Agent: NeoMutt/20220429 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661443612; a=rsa-sha256; cv=pass; b=HbInGPnycM/qGk8sUE2JCwESusO+RaN63vkNYt8VavDt5cy6W3HoN1K5g1t+H6mJdyxy4J GY1fI1DIheCgeu5oPHs17fLkqBBzE30d7rs5LJJQcrP4zQc0raZRW01pM2F8VXQp94Cxr/ 1Foa7lB1bOe31iJ1PAsYbPRacfCyVS0= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=FCqflbpm; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.48 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661443612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anopUDp5ozStsOp7m/DsKCZ3eEuLLawyiGqKJA3EYfo=; b=Q7rZql2aSfeu4hyt5usV3dAd3KDlM1b9GpPF+Ui2a/YJWwJfFmp0IMRuzqAO84M9jcDiwg oRAgZBa2aHTio4dDrywhWIB71f1kZxdmxwsDahApZDQf59ajbm0Cs/IE5VuGeRP8q8Id+8 9FThatmx5mxgEO75pKP1qb8u/FJCcB0= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=FCqflbpm; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf27.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.48 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: aqggwe89frwpiia7wgx53pziq18d6azf X-Rspamd-Queue-Id: F14A140014 X-HE-Tag: 1661443611-864964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.365524, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 22 Aug 2022, Liam Howlett wrote: >From: "Matthew Wilcox (Oracle)" > >Use the VMA iterator instead. Since VMA can no longer be NULL in the >loop, then deal with out-of-memory outside the loop. This means a >slightly longer run time in the failure case (-ENOMEM) - it will run to >the end of the VMAs before erroring instead of in the middle of the loop. I don't see anyone minding this. > >Signed-off-by: Matthew Wilcox (Oracle) >Signed-off-by: Liam R. Howlett Reviewed-by: Davidlohr Bueso