From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361C0C00140 for ; Wed, 24 Aug 2022 11:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52B806B0073; Wed, 24 Aug 2022 07:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DAE4940008; Wed, 24 Aug 2022 07:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A37C940007; Wed, 24 Aug 2022 07:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 285626B0073 for ; Wed, 24 Aug 2022 07:07:42 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EB473160237 for ; Wed, 24 Aug 2022 11:07:41 +0000 (UTC) X-FDA: 79834210722.29.2637C04 Received: from outbound-smtp40.blacknight.com (outbound-smtp40.blacknight.com [46.22.139.223]) by imf19.hostedemail.com (Postfix) with ESMTP id 3EE011A0010 for ; Wed, 24 Aug 2022 11:07:41 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp40.blacknight.com (Postfix) with ESMTPS id 83A1E1C3B9C for ; Wed, 24 Aug 2022 12:07:39 +0100 (IST) Received: (qmail 30511 invoked from network); 24 Aug 2022 11:07:39 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 24 Aug 2022 11:07:38 -0000 Date: Wed, 24 Aug 2022 12:07:35 +0100 From: Mel Gorman To: Michal Hocko Cc: Andrew Morton , Patrick Daly , David Hildenbrand , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mm/page_alloc: Fix race condition between build_all_zonelists and page allocation Message-ID: <20220824110722.erwcy44uidd6enpm@techsingularity.net> References: <20220824094901.rbpkackn2qmt36hg@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661339261; a=rsa-sha256; cv=none; b=4yiNq5AtKkzykwwtoBDvGjaM8lD7dH10fQ6HNynzOfDPiMwIZyKjDMWtEdB9bCh1pE9RCF SyxX/seXWJR13Z27KvKe56cCCb+KlKxoqmeh4aruxNUHo0dVW6yzCSeqccq8YbN8j2Eiwl v9f/4KVMvS8Y+aSL6/xbz4T2r4xBBa0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.223 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661339261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cn4ic4MiWYwROzMjeViDe/CWzXzn7fIyHiL9nL+mkxc=; b=Y95xboIjM1fqgy9AXRiotoTmldYgFe5F11z9osfu+CxCC7wLftziCFzmw2x+8K876BqRsL E7JUb79Lue540TIDth+Z3Ef4/uhBK8B/jNZpoij7wvRIHCYAi9KvMhHqqIxV5v6Ue7m/pg jUL+UT+xKleAo9K5LbWIx2SCUZmRs6o= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3EE011A0010 X-Stat-Signature: x8bm3jrwjmeifwksp7et4hkkumeh5p5f Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.223 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspam-User: X-HE-Tag: 1661339261-445368 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 12:10:11PM +0200, Michal Hocko wrote: > On Wed 24-08-22 10:49:01, Mel Gorman wrote: > > +static unsigned int zonelist_iter_begin(void) > > +{ > > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE)) > > + return 0; > > + > > + return read_seqbegin(&zonelist_update_seq); > > +} > > + > > +static unsigned int check_retry_zonelist(unsigned int seq) > > +{ > > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE)) > > + return seq; > > + > > + return read_seqretry(&zonelist_update_seq, seq); > > +} > > these should be negated Yey, last minute changes that are rushed. V2 shortly. -- Mel Gorman SUSE Labs