From: Mel Gorman <mgorman@techsingularity.net>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Patrick Daly <quic_pdaly@quicinc.com>,
David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mm/page_alloc: Fix race condition between build_all_zonelists and page allocation
Date: Wed, 24 Aug 2022 12:07:35 +0100 [thread overview]
Message-ID: <20220824110722.erwcy44uidd6enpm@techsingularity.net> (raw)
In-Reply-To: <YwX5A3xWjAJ7WTWU@dhcp22.suse.cz>
On Wed, Aug 24, 2022 at 12:10:11PM +0200, Michal Hocko wrote:
> On Wed 24-08-22 10:49:01, Mel Gorman wrote:
> > +static unsigned int zonelist_iter_begin(void)
> > +{
> > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE))
> > + return 0;
> > +
> > + return read_seqbegin(&zonelist_update_seq);
> > +}
> > +
> > +static unsigned int check_retry_zonelist(unsigned int seq)
> > +{
> > + if (IS_ENABLED(CONFIG_MEMORY_HOTREMOVE))
> > + return seq;
> > +
> > + return read_seqretry(&zonelist_update_seq, seq);
> > +}
>
> these should be negated
Yey, last minute changes that are rushed. V2 shortly.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2022-08-24 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 9:49 Mel Gorman
2022-08-24 10:10 ` Michal Hocko
2022-08-24 11:07 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824110722.erwcy44uidd6enpm@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=quic_pdaly@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox