From: Zhouyi Zhou <zhouzhouyi@gmail.com>
To: akpm@linux-foundation.org, nathan@kernel.org,
ndesaulniers@google.com, trix@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Cc: Zhouyi Zhou <zhouzhouyi@gmail.com>
Subject: [PATCH linux-next] mm: fix used but uninitialized variable
Date: Wed, 24 Aug 2022 13:56:37 +0800 [thread overview]
Message-ID: <20220824055637.10676-1-zhouzhouyi@gmail.com> (raw)
In function walk_hugetlb_range, the local variable err may
be used uninitialzed when:
ops->pte_hole in side of "else if (ops->pte_hole)" is false.
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
---
Dear mm Developers:
When I build kernel using "make CC=clang-14"
the compiler complains following:
CC mm/pagewalk.o
mm/pagewalk.c:318:12: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
else if (ops->pte_hole)
^~~~~~~~~~~~~
mm/pagewalk.c:321:7: note: uninitialized use occurs here
if (err)
^~~
mm/pagewalk.c:318:8: note: remove the 'if' if its condition is always true
else if (ops->pte_hole)
^~~~~~~~~~~~~~~~~~
mm/pagewalk.c:311:10: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 error generated.
make[1]: *** [scripts/Makefile.build:250: mm/pagewalk.o] Error 1
make: *** [Makefile:2006: mm] Error 2
I initialize that variable outside of the for loop because we can assign 0 to err
only once in this function.
After my fix, I can compile the kernel.
Many Thanks
Zhouyi
--
mm/pagewalk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index 54b2a1beeeb3..b6eb330e8ecd 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -306,9 +306,9 @@ static int walk_hugetlb_range(unsigned long addr, unsigned long end,
unsigned long hmask = huge_page_mask(h);
unsigned long sz = huge_page_size(h);
const struct mm_walk_ops *ops = walk->ops;
+ int err = 0;
for (; addr < end; addr = next) {
- int err;
pte_t *pte = huge_pte_offset(walk->mm, addr & hmask, sz);
next = hugetlb_entry_end(h, addr, end);
--
2.34.1
next reply other threads:[~2022-08-24 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 5:56 Zhouyi Zhou [this message]
2022-08-24 6:10 ` Christophe Leroy
2022-08-24 6:41 ` Zhouyi Zhou
2022-08-24 6:49 ` Christophe Leroy
2022-08-24 8:10 ` Zhouyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824055637.10676-1-zhouzhouyi@gmail.com \
--to=zhouzhouyi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox