From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8896C32772 for ; Tue, 23 Aug 2022 17:31:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B044940007; Tue, 23 Aug 2022 13:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45FF16B0074; Tue, 23 Aug 2022 13:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32726940007; Tue, 23 Aug 2022 13:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23B056B0073 for ; Tue, 23 Aug 2022 13:31:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6AB21A1660 for ; Tue, 23 Aug 2022 17:31:58 +0000 (UTC) X-FDA: 79831550316.30.B58E71E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 588C9160032 for ; Tue, 23 Aug 2022 17:31:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 391BD336D9; Tue, 23 Aug 2022 17:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661275917; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k0ks80j7Oad7m+qauu8Z4TAZTDJEgaZRum5ZNUCrL30=; b=BmFTIqCkILUYsistd/v/t7Wcameutnc6Uh9zOCOf8JiWKdWZ6Ajxyag5Vfq+mAm0hMDRTI YfLrlgi4viQHLwp1CtNqoahnMDfvcntiGAJXFEKd/yTEdyuX/9D3Hf3/DCfuzoEV5YTOKG GXzFYzN8tLbokoMi4obQN1l0IOuQXg0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661275917; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k0ks80j7Oad7m+qauu8Z4TAZTDJEgaZRum5ZNUCrL30=; b=VOQyCer4+nqwPdtU2qYRvacNJcaJjDV3YzIpYwxM1zcz/LIgk1uPCD2aN1aIJkgfVtMLaz 2vIf0jsKUE6wJLAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE03713A89; Tue, 23 Aug 2022 17:31:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zWchOQwPBWOiTAAAMHmgww (envelope-from ); Tue, 23 Aug 2022 17:31:56 +0000 Date: Tue, 23 Aug 2022 19:26:42 +0200 From: David Sterba To: "Vishal Moola (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] Convert to filemap_get_folios_contig() Message-ID: <20220823172642.GJ13489@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Vishal Moola (Oracle)" , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220816175246.42401-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816175246.42401-1-vishal.moola@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661275918; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k0ks80j7Oad7m+qauu8Z4TAZTDJEgaZRum5ZNUCrL30=; b=e6EyDJ9NR/gNPofsKdVxnipWeVNpZDQoe/asQuVFD8XiEcqLBGX5VApaehGLcRgIIO3qTF Sr/3t6KIPhDOwNnCRBP5nxvOfmgaqkpfv0RAfngBlZ9TFUmvuPBJGavWdFlLkkFXuscE1J V7ULCTFAHXd97ic7lahr5YGKsmy75ko= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BmFTIqCk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VOQyCer4; spf=pass (imf08.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661275918; a=rsa-sha256; cv=none; b=1/q5epxGGVIhH6AyDRQ/38rryvR5FrgDdr48023Q2H+SRV27HeXyv/D1gsHCyXQMv2ng9o l1z4K+R8++D7Ve18s3Jm5ferGvjWiMleWjWZplMwZs1grc7WKm16XGVMnUTO9NSAfVa2TE GYLGoVAnyxTyAEIG6/RpRLhXVgfp/rc= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 588C9160032 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BmFTIqCk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VOQyCer4; spf=pass (imf08.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=dsterba@suse.cz; dmarc=none X-Stat-Signature: 7qbuxedpeqsfrksntio8517e9sxcpaag X-HE-Tag: 1661275918-883070 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 16, 2022 at 10:52:39AM -0700, Vishal Moola (Oracle) wrote: > This patch series replaces find_get_pages_contig() with > filemap_get_folios_contig(). I've run xfstests on btrfs. I've also > tested the ramfs changes. I ran some xfstests on nilfs2, and its > seemingly fine although more testing may be beneficial. > --- > > v2: > - Removed an unused label in nilfs2 > > Vishal Moola (Oracle) (7): > filemap: Add filemap_get_folios_contig() > btrfs: Convert __process_pages_contig() to use > filemap_get_folios_contig() > btrfs: Convert end_compressed_writeback() to use filemap_get_folios() > btrfs: Convert process_page_range() to use filemap_get_folios_contig() > nilfs2: Convert nilfs_find_uncommited_extent() to use > filemap_get_folios_contig() > ramfs: Convert ramfs_nommu_get_unmapped_area() to use > filemap_get_folios_contig() > filemap: Remove find_get_pages_contig() > > fs/btrfs/compression.c | 26 ++++++------ > fs/btrfs/extent_io.c | 33 +++++++-------- > fs/btrfs/subpage.c | 2 +- > fs/btrfs/tests/extent-io-tests.c | 31 +++++++------- I've tested the whole branch in my fstest setup, no issues found and did a light review of the code changes, looks ok as well. How do you want get the patches merged? As it's an API conversion I can ack it and let it go via the mm tree. So far there are no conflicts with our btrfs development patches, I assume it'll be a clean merge in the future too. > fs/nilfs2/page.c | 39 ++++++++---------- > fs/ramfs/file-nommu.c | 50 ++++++++++++---------- > include/linux/pagemap.h | 4 +- > mm/filemap.c | 71 +++++++++++++++++++------------- > 8 files changed, 134 insertions(+), 122 deletions(-) > > -- > 2.36.1