From: David Sterba <dsterba@suse.cz>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-nilfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Convert to filemap_get_folios_contig()
Date: Tue, 23 Aug 2022 19:26:42 +0200 [thread overview]
Message-ID: <20220823172642.GJ13489@twin.jikos.cz> (raw)
In-Reply-To: <20220816175246.42401-1-vishal.moola@gmail.com>
On Tue, Aug 16, 2022 at 10:52:39AM -0700, Vishal Moola (Oracle) wrote:
> This patch series replaces find_get_pages_contig() with
> filemap_get_folios_contig(). I've run xfstests on btrfs. I've also
> tested the ramfs changes. I ran some xfstests on nilfs2, and its
> seemingly fine although more testing may be beneficial.
> ---
>
> v2:
> - Removed an unused label in nilfs2
>
> Vishal Moola (Oracle) (7):
> filemap: Add filemap_get_folios_contig()
> btrfs: Convert __process_pages_contig() to use
> filemap_get_folios_contig()
> btrfs: Convert end_compressed_writeback() to use filemap_get_folios()
> btrfs: Convert process_page_range() to use filemap_get_folios_contig()
> nilfs2: Convert nilfs_find_uncommited_extent() to use
> filemap_get_folios_contig()
> ramfs: Convert ramfs_nommu_get_unmapped_area() to use
> filemap_get_folios_contig()
> filemap: Remove find_get_pages_contig()
>
> fs/btrfs/compression.c | 26 ++++++------
> fs/btrfs/extent_io.c | 33 +++++++--------
> fs/btrfs/subpage.c | 2 +-
> fs/btrfs/tests/extent-io-tests.c | 31 +++++++-------
I've tested the whole branch in my fstest setup, no issues found and
did a light review of the code changes, looks ok as well.
How do you want get the patches merged? As it's an API conversion I can
ack it and let it go via the mm tree. So far there are no conflicts with
our btrfs development patches, I assume it'll be a clean merge in the
future too.
> fs/nilfs2/page.c | 39 ++++++++----------
> fs/ramfs/file-nommu.c | 50 ++++++++++++----------
> include/linux/pagemap.h | 4 +-
> mm/filemap.c | 71 +++++++++++++++++++-------------
> 8 files changed, 134 insertions(+), 122 deletions(-)
>
> --
> 2.36.1
next prev parent reply other threads:[~2022-08-23 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 17:52 Vishal Moola (Oracle)
2022-08-16 17:52 ` [PATCH v2 1/7] filemap: Add filemap_get_folios_contig() Vishal Moola (Oracle)
2022-08-16 17:52 ` [PATCH v2 2/7] btrfs: Convert __process_pages_contig() to use filemap_get_folios_contig() Vishal Moola (Oracle)
2022-08-22 18:32 ` Vishal Moola
2022-08-23 20:35 ` David Sterba
2022-08-16 17:52 ` [PATCH v2 3/7] btrfs: Convert end_compressed_writeback() to use filemap_get_folios() Vishal Moola (Oracle)
2022-08-23 20:36 ` David Sterba
2022-08-16 17:52 ` [PATCH v2 4/7] btrfs: Convert process_page_range() to use filemap_get_folios_contig() Vishal Moola (Oracle)
2022-08-23 20:38 ` David Sterba
2022-08-16 17:52 ` [PATCH v2 5/7] nilfs2: Convert nilfs_find_uncommited_extent() " Vishal Moola (Oracle)
2022-08-17 4:33 ` Ryusuke Konishi
2022-08-17 20:35 ` Vishal Moola
2022-08-16 17:52 ` [PATCH v2 6/7] ramfs: Convert ramfs_nommu_get_unmapped_area() " Vishal Moola (Oracle)
2022-08-16 17:52 ` [PATCH v2 7/7] filemap: Remove find_get_pages_contig() Vishal Moola (Oracle)
2022-08-23 17:26 ` David Sterba [this message]
2022-08-23 18:02 ` [PATCH v2 0/7] Convert to filemap_get_folios_contig() Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823172642.GJ13489@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox