From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38079C32774 for ; Tue, 23 Aug 2022 15:32:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4F666B0073; Tue, 23 Aug 2022 11:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FF556B0074; Tue, 23 Aug 2022 11:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EE33940007; Tue, 23 Aug 2022 11:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7BB3B6B0073 for ; Tue, 23 Aug 2022 11:32:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 48CF7161585 for ; Tue, 23 Aug 2022 15:32:05 +0000 (UTC) X-FDA: 79831248210.30.82BE508 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E789D40005 for ; Tue, 23 Aug 2022 15:32:04 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4145615F7; Tue, 23 Aug 2022 15:32:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0870AC433D6; Tue, 23 Aug 2022 15:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661268723; bh=kv7ZNDv1FBguuVmkE95CjI4JtqYhHJBmXuAD/LbhowE=; h=From:To:Cc:Subject:Date:From; b=lobSX5e6t4xjH5/Am6fGj9FTN7qbOtqS8ZtVc0h1dp4mZoJSzj0Mxq9yx2ugCllno xKQSzJzK555RV247wINMtB4xxRKfX7zz8EDFdUp7CGSJbgie6ljkBvpypjs8MJzdPq q3GdOx+3EaFaTFK7t19ORqo0uShAxluFSlyXktTyC4xieZYigLgrYzhUgY3xwW2Kae 0Rpsn04UI7bOEjiQqL2xbBJhRSrKyTmlEo1p9/krFguIgY3UMDs1lNE2EIC4IEhEF+ GwpJA6wWSvXow0CX3SS/AClKr9eQneE9QLY89H+ojUJuqH+05JsoCORV74M1a08AjZ zBl4bgT0sh1PQ== From: Nathan Chancellor To: Andrew Morton Cc: Nick Desaulniers , Tom Rix , Rolf Eike Beer , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev, Nathan Chancellor Subject: [PATCH -next] mm: pagewalk: Restore err initialization in walk_hugetlb_range() Date: Tue, 23 Aug 2022 08:30:56 -0700 Message-Id: <20220823153055.2517764-1-nathan@kernel.org> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lobSX5e6; spf=pass (imf01.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661268725; a=rsa-sha256; cv=none; b=8fOijWe0VQACmNIA8Da2R7y/5shCBcNYD4UPPdQ7SeeSa4XbErlROf5uLa/J2/j/45vvM2 xLz/NAy0w8N+nSTmQx1gwPfWpzSMziDrIJXiGTBn0bcgVTDw8IAmNc/LsOiV47HrhwlWdv 9yo0f/r0+AybVKpcu7fWEFCtNg6mesk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661268725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=N9chMNull63xEzUPCmHnHlCcZKXmjmDjwBuBsaT9on8=; b=nRQlWDw/jJXig1sL7IYIkdRXS2/7dqhnyYABVuA1nAYf9A2qgg986rnUkeTWGhEueTi5fY e7jSTR4rEC5/GysWxhn+9G6N6kz6JXNwwdF0VPRELUn4kjiYLvYv/55uyI7s49C10uJzDg 4IYvXLbvOzJUo4XyWuwpPZcR51yviqY= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lobSX5e6; spf=pass (imf01.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Queue-Id: E789D40005 X-Rspamd-Server: rspam05 X-Stat-Signature: f8idq5oznyikb75h4jjf1ket773t6heg X-HE-Tag: 1661268724-696202 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Clang warns: mm/pagewalk.c:318:12: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] else if (ops->pte_hole) ^~~~~~~~~~~~~ mm/pagewalk.c:321:7: note: uninitialized use occurs here if (err) ^~~ mm/pagewalk.c:318:8: note: remove the 'if' if its condition is always true else if (ops->pte_hole) ^~~~~~~~~~~~~~~~~~ mm/pagewalk.c:311:10: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 error generated. Restore the initialization of err to zero so that it cannot be used uninitialized. Fixes: 9ce1db56225a ("mm: pagewalk: make error checks more obvious") Link: https://github.com/ClangBuiltLinux/linux/issues/1694 Signed-off-by: Nathan Chancellor --- I am sure that SHA is not stable and I expect this to be squashed into the original change. mm/pagewalk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 54b2a1beeeb3..76e5ccda8c88 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -308,7 +308,7 @@ static int walk_hugetlb_range(unsigned long addr, unsigned long end, const struct mm_walk_ops *ops = walk->ops; for (; addr < end; addr = next) { - int err; + int err = 0; pte_t *pte = huge_pte_offset(walk->mm, addr & hmask, sz); next = hugetlb_entry_end(h, addr, end); base-commit: d711de4adbec4cb0b8769bcae971b13293e6d311 -- 2.37.2