From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH v2 3/6] mm, hwpoison: fix extra put_page() in soft_offline_page()
Date: Tue, 23 Aug 2022 11:23:43 +0800 [thread overview]
Message-ID: <20220823032346.4260-4-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220823032346.4260-1-linmiaohe@huawei.com>
When hwpoison_filter() refuses to soft offline a page, the page refcnt
incremented previously by MF_COUNT_INCREASED would have been consumed
via get_hwpoison_page() if ret <= 0. So the put_ref_page() here will
put the extra one. Remove it to fix the issue.
Fixes: 9113eaf331bf ("mm/memory-failure.c: add hwpoison_filter for soft offline")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
---
mm/memory-failure.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index ecd42d717c6f..1d79e693f1b9 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2575,8 +2575,6 @@ int soft_offline_page(unsigned long pfn, int flags)
if (hwpoison_filter(page)) {
if (ret > 0)
put_page(page);
- else
- put_ref_page(ref_page);
mutex_unlock(&mf_mutex);
return -EOPNOTSUPP;
--
2.23.0
next prev parent reply other threads:[~2022-08-23 3:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 3:23 [PATCH v2 0/6] A few fixup patches for memory-failure Miaohe Lin
2022-08-23 3:23 ` [PATCH v2 1/6] mm, hwpoison: fix page refcnt leaking in try_memory_failure_hugetlb() Miaohe Lin
2022-08-23 3:23 ` [PATCH v2 2/6] mm, hwpoison: fix page refcnt leaking in unpoison_memory() Miaohe Lin
2022-08-23 3:23 ` Miaohe Lin [this message]
2022-08-23 3:23 ` [PATCH v2 4/6] mm, hwpoison: fix possible use-after-free in mf_dax_kill_procs() Miaohe Lin
2022-08-24 0:36 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-23 3:23 ` [PATCH v2 5/6] mm, hwpoison: kill procs if unmap fails Miaohe Lin
2022-08-23 3:23 ` [PATCH v2 6/6] mm, hwpoison: avoid trying to unpoison reserved page Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823032346.4260-4-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox