From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE89C28D13 for ; Tue, 23 Aug 2022 01:25:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E9D68D0003; Mon, 22 Aug 2022 21:25:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 898F48D0001; Mon, 22 Aug 2022 21:25:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 739CF8D0003; Mon, 22 Aug 2022 21:25:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 644F48D0001 for ; Mon, 22 Aug 2022 21:25:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 393B516133B for ; Tue, 23 Aug 2022 01:25:45 +0000 (UTC) X-FDA: 79829115450.19.283E771 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf02.hostedemail.com (Postfix) with ESMTP id EAB1E80028 for ; Tue, 23 Aug 2022 01:25:44 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id o14-20020a17090a0a0e00b001fabfd3369cso13114386pjo.5 for ; Mon, 22 Aug 2022 18:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=zUw74NM1PF7THinMe6GlF9fUaFjzhhz/u/PvpW+nALE=; b=Q64HD9FubVrlP5FmJOhxKQUOt96oa1y4u811xQjDNizh82sETFqtDd7YBhlyq7Fdxb rLbPDmVH9HGNC5K/UDeLYv14kfMyzYjVa50MOJ3QGeHCfs4+qrFqcTtzZArm4uraIU/C Nvrv9grRvmRE9oXrd0tzcZWKDezpB1lWXwmfxeu/1emkEXRpVPM/7arbKBomI1miyiS1 hy+2xHiijPE8GCpoe5wjF/dscpP7+aowXMXjkAsfFbEH43jZ108/WVH0r9AZlzcMQqx9 hVVjlHJU7iqLQKQKcheYNF9PR/qe1ORY2lIlJGzxRCAvGY1+/1jjiSLaSTUkLSyqVi90 uW+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=zUw74NM1PF7THinMe6GlF9fUaFjzhhz/u/PvpW+nALE=; b=R9KlW4Diq00LDEx/0OuWlug3QeXbbgtpAqVVYNVMCcgEFB8BMRLivrjFoXdJeTXREn seK5d46yM5fHHbCry7Cx/sWob08Outp0AAL+hdWTZPgasRntdfxMrMlxEKA6fGrNYR3d oWMoDscztPjzzBRosXO7N6Sp6Zzan3SbDEZGyWWY84h+711aocuY4HSLvfbHynfqBfp2 uTPS5a3IGstVTQP9IX7VLDPbCwMYmaidaNA41Cjih4yFVBj3ZpETA7uV+8S3cfr5F3Fp tq2IFd1hIy+XmOn+ZaDON2mhGZP2Y2bN2f10C0WLOoPHey6wCRlGOthd+T/QtXHAgxzr P0IQ== X-Gm-Message-State: ACgBeo3GVSsW0V4GGajUFS/8xiRNgi166hHsT9dUaIzfoxAyfLhwriEt F+YhonAcGv4hFRJtVk0Go9Y= X-Google-Smtp-Source: AA6agR6cK3+6tkV4eQf/7WDt9r9QaUp4zK5IzLni0B+GqaZ9vscYfOKokN6RflRUU0B5j2K2m/fZsQ== X-Received: by 2002:a17:902:9886:b0:172:bb36:70f1 with SMTP id s6-20020a170902988600b00172bb3670f1mr21126201plp.139.1661217943863; Mon, 22 Aug 2022 18:25:43 -0700 (PDT) Received: from localhost ([192.55.55.51]) by smtp.gmail.com with ESMTPSA id d10-20020a17090ab30a00b001fb53587166sm1055886pjr.28.2022.08.22.18.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Aug 2022 18:25:43 -0700 (PDT) Date: Mon, 22 Aug 2022 18:25:41 -0700 From: Isaku Yamahata To: Michael Roth Cc: Sean Christopherson , "Gupta, Pankaj" , "Kirill A . Shutemov" , Chao Peng , "Nikunj A. Dadhania" , Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , mhocko@suse.com, Muchun Song , bharata@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-fsdevel@vger.kernel.org, isaku.yamahata@gmail.com Subject: Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory Message-ID: <20220823012541.GA2147148@ls.amr.corp.intel.com> References: <422b9f97-fdf5-54bf-6c56-3c45eff5e174@amd.com> <1407c70c-0c0b-6955-10bb-d44c5928f2d9@amd.com> <1136925c-2e37-6af4-acac-be8bed9f6ed5@amd.com> <1b02db9d-f2f1-94dd-6f37-59481525abff@amd.com> <20220815130411.GA1073443@chaop.bj.intel.com> <20220816122457.2fjyd4uz5hp5cani@box.shutemov.name> <20220817152719.g7pgu34syekzkha5@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220817152719.g7pgu34syekzkha5@amd.com> ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q64HD9Fu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661217944; a=rsa-sha256; cv=none; b=cl/T56PmkJhqdYHrPy4qS2D99tC6wdcErGzspCYqAY9CWmuBJMAoeDugXV4EwSih7Ay4IY WREH1Bi/NFwmU0IlrxSQTsJ4r2R5CTW4CkMl9b9J9GOwb3+Cr6xVmkfdkCTjcHYFHfcRkq flwYIrg+9ka062HjVtFGjRWMp6np5RM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661217944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zUw74NM1PF7THinMe6GlF9fUaFjzhhz/u/PvpW+nALE=; b=lmw9sktnzji9Via8OJbzlqfyWXTOCGg84U8R+4dHHGoQYDemaY9D5XriJJCFkgvCZEtbjH vMzRewI4XFODRwLHAM37EiW1pAQ8M9po4Z1v+Fuc3sgYvw+FZBjS8YLPoXBWQzND830QXb QjTZ/SHeWNCdXO5P4lRsbTWVs3ZLuGk= X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Q64HD9Fu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com X-Stat-Signature: gkw8poxxmu8xibm57h4k4y6yod4xgxdx X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EAB1E80028 X-HE-Tag: 1661217944-424695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 17, 2022 at 10:27:19AM -0500, Michael Roth wrote: > > I think the best approach is to turn KVM_TDX_INIT_MEM_REGION into a generic > > vCPU-scoped ioctl() that allows userspace to pre-map guest memory. Supporting > > initializing guest private memory with a source page can be implemented via a > > flag. That also gives KVM line of sight to in-place "conversion", e.g. another > > flag could be added to say that the dest is also the source. > > So is this proposed ioctl only intended to handle the initial encrypted > payload, and the KVM_MEMORY_ENCRYPT_{REG,UNREG}_REGION ioctls would > still be used for conversions post-boot? Yes. It is called before running any vcpu. At run time (after running vcpus), KVM_MEMORY_ENCRYPT_{REG,UNREG}_REGION is used. -- Isaku Yamahata