From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF2EC28D13 for ; Mon, 22 Aug 2022 20:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36F146B0073; Mon, 22 Aug 2022 16:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E6E8D0001; Mon, 22 Aug 2022 16:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197276B0075; Mon, 22 Aug 2022 16:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 09B246B0073 for ; Mon, 22 Aug 2022 16:22:10 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 878FB120A7D for ; Mon, 22 Aug 2022 20:22:09 +0000 (UTC) X-FDA: 79828350378.20.5CB34BE Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 4CA11400D9 for ; Mon, 22 Aug 2022 20:18:46 +0000 (UTC) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27MEtvgg031489; Mon, 22 Aug 2022 20:18:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=+7caGdRcRgncf+AjtJ2YQhEg+Vjd7SRu2KkT7Cxd0cM=; b=eo/X/Av1mIqGA0+TDJ6lsl9RjzBgBVimoIuqp8HrJgH8eNWT/yGyTbTByyvfcekhjHjK +aNL0M8x6Z9J5yBmdLQuqsK+KIPhpH9N1cxC1PfuMrPSpdVat2/vv0su6Fqwl4fP6V4G L0eZmPymE/6lfzFNBUVO5krB3bDuUSjVHEK95EYJoLue5c9NTaEYh9WDty+1OvvjkS+s MF0bKmH3QTonbxpSlaukqoTWK+esa4trR0d5oLhoPm2KU1aS6HNvL++HxOEJbE8uILYP bkh94U0Oz7wGzPvLMRJUyMumRm/rw3kHYWmJKuvu/srjjgWheL3Lm/dNLloPmU90nEa8 nQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j2vwp5nm7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 20:18:45 +0000 Received: from pps.filterd (NALASPPMTA05.qualcomm.com [127.0.0.1]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 27MKIiFs031824; Mon, 22 Aug 2022 20:18:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 3j4dvg8j67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 20:18:44 +0000 Received: from NALASPPMTA05.qualcomm.com (NALASPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27MKIilP031815; Mon, 22 Aug 2022 20:18:44 GMT Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (PPS) with ESMTPS id 27MKIiZn031814 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Aug 2022 20:18:44 +0000 Received: from hu-pdaly-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 22 Aug 2022 13:18:43 -0700 Date: Mon, 22 Aug 2022 13:18:42 -0700 From: Patrick Daly To: Mel Gorman CC: Michal Hocko , , , David Hildenbrand , Juergen Gross Subject: Re: Race condition in build_all_zonelists() when offlining movable zone Message-ID: <20220822201842.GA29260@hu-pdaly-lv.qualcomm.com> References: <20220817034250.GB2473@hu-pdaly-lv.qualcomm.com> <20220817104028.uin7cmkb4qlpgfbi@suse.de> <20220817112647.z7wenwjpyt3hphtk@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220817112647.z7wenwjpyt3hphtk@suse.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: t5--kQEiZW60rv1YuVwzagfSmnXPEJ2x X-Proofpoint-ORIG-GUID: t5--kQEiZW60rv1YuVwzagfSmnXPEJ2x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-22_12,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxscore=0 clxscore=1015 mlxlogscore=679 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208220083 ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="eo/X/Av1"; spf=pass (imf01.hostedemail.com: domain of quic_pdaly@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_pdaly@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661199526; a=rsa-sha256; cv=none; b=8bFrPDJBCmHeQt1ddp+mLNnSJx0Dx/L2Tj86iclIMw9IQvkyR8vmHifwyA5Pt1V8AEIcKZ nFggO79Y27lmvmN277zyzrd9IShmgHkA/DgnQjDpdV4M2w5F6kHKB3BsVTtI66bOkSbUNw hZwn/fFPf6hOtSeqlPR/D33b+ihLpNo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661199526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+7caGdRcRgncf+AjtJ2YQhEg+Vjd7SRu2KkT7Cxd0cM=; b=7roBNHP3kH5cIWxmYTKaJxCvY1/fkMz9Ce6jSf7ACu8ue7ojlmWIKpJ37kNJU5Nao4T5Mc Fd0KqjCWSCgk7Rj7AJLSA3SzgipJ93zjyXwI5YsC2TZ41e1Fhi5vVUJwNDQqdo3jl5AEu0 gIW/9bchWd2ES6vWijRcWr9SX/Dz4qE= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="eo/X/Av1"; spf=pass (imf01.hostedemail.com: domain of quic_pdaly@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_pdaly@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4CA11400D9 X-Stat-Signature: qbo5exekse4h1jhnj7snreu5y5p5es85 X-HE-Tag: 1661199526-252539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 17, 2022 at 12:26:47PM +0100, Mel Gorman wrote: > Patrick, as you have a hotplug test that removes a full zone, would you > like to test? I haven't boot tested it on v5.15 but it applies cleanly > and compiles at least. > Hi Mel/Michal Thanks for the patch. I did not see any re-occurance of the original issue, or any stability issues linked to the new code. --Patrick