From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008D7C00140 for ; Sun, 21 Aug 2022 23:32:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51E1D6B0073; Sun, 21 Aug 2022 19:32:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC6D8E0002; Sun, 21 Aug 2022 19:32:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 395868E0001; Sun, 21 Aug 2022 19:32:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26ACF6B0073 for ; Sun, 21 Aug 2022 19:32:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F24DD408BA for ; Sun, 21 Aug 2022 23:32:58 +0000 (UTC) X-FDA: 79825202436.08.32C10C6 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by imf05.hostedemail.com (Postfix) with ESMTP id EF7BE10003C for ; Sun, 21 Aug 2022 23:32:57 +0000 (UTC) Received: from dread.disaster.area (pa49-195-4-169.pa.nsw.optusnet.com.au [49.195.4.169]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 024CE62D65C; Mon, 22 Aug 2022 09:32:54 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1oPuR1-00FxHU-PQ; Mon, 22 Aug 2022 09:32:51 +1000 Date: Mon, 22 Aug 2022 09:32:51 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Shiyang Ruan , Dan Williams , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "hch@infradead.org" , "jane.chu@oracle.com" Subject: Re: [PATCH] xfs: on memory failure, only shut down fs after scanning all mappings Message-ID: <20220821233251.GI3600936@dread.disaster.area> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=6302c0a8 a=FOdsZBbW/tHyAhIVFJ0pRA==:117 a=FOdsZBbW/tHyAhIVFJ0pRA==:17 a=kj9zAlcOel0A:10 a=biHskzXt2R4A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=1mAKx1ogGfV0O7zOtsIA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661124778; a=rsa-sha256; cv=none; b=tE4Iq3xmbhrkq3CGAIJTieimV9ljXi2kyrGCL0k5hSq2TJynx/RNEqI5F4rCNFtyWpgD58 MyQEJ6iyQ7jKChgBczb53NsmDX82/BqyuHE9KEbCVuFDsbDfsiVxF1AB4/MOSumQG77jEB CtglnzLp8Ef5Utxu+58cH1y8GxrBHas= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 211.29.132.246) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661124778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kzyt/wRxEfrQuP5jq1fruRNc8SB2mj/v9wR++sBxqaY=; b=B2CMVykkfXgR0krfgTlTMX0K0s2P3G4OUa+vVAv5Ofbq62j+QEQieiXceq76ZlFOD7c7AP MuNK9LijrDfkrIeu2QHbVbqrbLfxHnpF2aBh5WeBSvYX9423AC6Wujk1Wuk8faE9RJ0Op+ c0opRaw5Z8j15vs60AvuW1eJD2Cvii4= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EF7BE10003C Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 211.29.132.246) smtp.mailfrom=david@fromorbit.com X-Stat-Signature: oo4ru8oir9n44kdaiy4dykai9unmp4ig X-Rspam-User: X-HE-Tag: 1661124777-260468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 18, 2022 at 10:00:17AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > xfs_dax_failure_fn is used to scan the filesystem during a memory > failure event to look for memory mappings to revoke. Unfortunately, if > it encounters an rmap record for filesystem metadata, it will shut down > the filesystem and the scan immediately. This means that we don't > complete the mapping revocation scan and instead leave live mappings to > failed memory. Fix the function to defer the shutdown until after we've > finished culling mappings. > > While we're at it, add the usual "xfs_" prefix to struct failure_info, > and actually initialize mf_flags. > > Signed-off-by: Darrick J. Wong Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com