From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <corbet@lwn.net>, <mcgrof@kernel.org>, <keescook@chromium.org>,
<yzaikin@google.com>, <songmuchun@bytedance.com>,
<mike.kravetz@oracle.com>, <osalvador@suse.de>, <rppt@kernel.org>,
<surenb@google.com>, <mawupeng1@huawei.com>, <jsavitz@redhat.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
<wangkefeng.wang@huawei.com>
Subject: [PATCH v2 1/2] mm: Cap zone movable's min wmark to small value
Date: Fri, 19 Aug 2022 17:30:24 +0800 [thread overview]
Message-ID: <20220819093025.105403-2-mawupeng1@huawei.com> (raw)
In-Reply-To: <20220819093025.105403-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
Since min_free_kbytes is based on gfp_zone(GFP_USER) which does not include
zone movable. However zone movable will get its min share in
__setup_per_zone_wmarks() which does not make any sense.
And like highmem pages, __GFP_HIGH and PF_MEMALLOC allocations usually
don't need movable pages, so there is no need to assign min pages for zone
movable.
Let's cap pages_min for zone movable to a small value here just link
highmem pages.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e5486d47406e..ff644205370f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8638,7 +8638,7 @@ static void __setup_per_zone_wmarks(void)
/* Calculate total number of !ZONE_HIGHMEM pages */
for_each_zone(zone) {
- if (!is_highmem(zone))
+ if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE)
lowmem_pages += zone_managed_pages(zone);
}
@@ -8648,7 +8648,7 @@ static void __setup_per_zone_wmarks(void)
spin_lock_irqsave(&zone->lock, flags);
tmp = (u64)pages_min * zone_managed_pages(zone);
do_div(tmp, lowmem_pages);
- if (is_highmem(zone)) {
+ if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) {
/*
* __GFP_HIGH and PF_MEMALLOC allocations usually don't
* need highmem pages, so cap pages_min to a small
--
2.25.1
next prev parent reply other threads:[~2022-08-19 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 9:30 [PATCH v2 0/2] watermark related improvement on zone movable Wupeng Ma
2022-08-19 9:30 ` Wupeng Ma [this message]
2022-08-24 8:10 ` [PATCH v2 1/2] mm: Cap zone movable's min wmark to small value David Hildenbrand
2022-08-25 0:49 ` mawupeng
2022-08-19 9:30 ` [PATCH v2 2/2] mm: sysctl: Introduce per zone watermark_scale_factor Wupeng Ma
2022-08-24 7:27 ` [PATCH v2 0/2] watermark related improvement on zone movable mawupeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819093025.105403-2-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jsavitz@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox