From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62020C00140 for ; Thu, 18 Aug 2022 22:33:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1B8C8E0001; Thu, 18 Aug 2022 18:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCAE48D0002; Thu, 18 Aug 2022 18:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C925A8E0001; Thu, 18 Aug 2022 18:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BDB268D0002 for ; Thu, 18 Aug 2022 18:33:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 994A4A1D2B for ; Thu, 18 Aug 2022 22:33:05 +0000 (UTC) X-FDA: 79814165130.07.978BAC0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id B1354101B0E for ; Thu, 18 Aug 2022 22:09:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8FB1EB82312; Thu, 18 Aug 2022 17:23:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDD72C433D6; Thu, 18 Aug 2022 17:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660843405; bh=n+Zh5soEiKsYTavc5xpB5hD5bHQyBWVCiz9gxj6eumY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uzRzyMDttnWkLveGuhV3m6MbEQeEFkChs0X3xIiXlnuxoRvx928i6qTBRVQTOWuUC 3hEcEcVuS/ZO/7HTLRXXZrvg6u46R1FYIahF29qSBcwASDb31qK6k+daIrcxf2OrwR uZZ2E6zfM4+Lg0qBBpc47yrzhdNaAT4kH12vupPrysE8Feesz8ijiavPFdCuhd4lF8 C/fGYfQwR5sS5zj9U/ruBzwIVbj6Y1t6IdMa+cE/xDdVmMIedkG47b/jOx3rnxHS0I 1lRuRnuMcReC08JKkmZ6tefikIBX3j02YFnbSl4Fh58iL0SPC4uGAp+gazGHqceVi0 owAqaZlZa7Nxw== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg Date: Thu, 18 Aug 2022 17:23:22 +0000 Message-Id: <20220818172322.51705-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220818105732.34492-3-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660860580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xm1MV0Ef+/c8yV+ZS/YPVWUM2N4T6X3tBBl5WHX4kzU=; b=HHdWybaNDgRqyyp4ulehO3L/1XAdrKSjpzTIUtHq6VBWZ3OhLDDqir6upMh5FpLRCqw2dw dfw9SI7pxeABkFHTHqZWUlOKuWPRMtPFP2X7BTfL24irPIZYoHVzAcn/uV6c8XOCQNI9q4 3YMOUi+DS7DZ793WtOnwI24byyjwevc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uzRzyMDt; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660860580; a=rsa-sha256; cv=none; b=ycQ+kXUs8VRf/dKX51pt+UfGNQIJKz0QD+bZ60VhSkcA8GwwQ9FcGl37oFxj44jRdaG1Ys QlagPk+yrnUWeyKa0he+xo0TgPMu7w+r3IZBLlQfKYO9W8UwAQm4KMPbQcNT7at+f8HBH6 VqafKeBViYM98wAbljP4AiLc1lwvOUU= X-Stat-Signature: forty9uweyfpecy95q9wkcffukcdjwed X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uzRzyMDt; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B1354101B0E X-HE-Tag: 1660860580-645571 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao wrote: > The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of > 'damon_addr_range', so, there no need to redefine it, just use struct of > 'damon_addr_range' instead. Reducing code is always good, thanks. However, I think the type of the 'start' and 'end' fields of 'struct damon_addr_range' might be changed in a future. It's very unlikely, though. Also, we might add some more fields to the struct in a future. After all, the purpose of 'struct damon_addr_range' is not saving the 'start' and 'end' fields of 'struct resource'. I'd like to avoid making any possible dependency here, sorry. Thanks, SJ [...]