From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25736C00140 for ; Thu, 18 Aug 2022 21:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D1C08D0002; Thu, 18 Aug 2022 17:25:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A0F8D0001; Thu, 18 Aug 2022 17:25:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FA478D0002; Thu, 18 Aug 2022 17:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D8208D0001 for ; Thu, 18 Aug 2022 17:25:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2B13DA1A9D for ; Thu, 18 Aug 2022 21:25:49 +0000 (UTC) X-FDA: 79813995618.29.3A3C926 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id EB28640420 for ; Thu, 18 Aug 2022 21:06:28 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55BB261630; Thu, 18 Aug 2022 16:47:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E37F9C433D6; Thu, 18 Aug 2022 16:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660841244; bh=TOzmBUEyJkFq8BX4F3WOSMODGQe0Ba5ENH0sx85QamI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LLH25lEpgr2dMgoKRLVa5sV7uD7QbcSjlsoML0BE3YJgHOw4bNv18wV4xwemwNYk9 6AJSWHFQ3vI+SyxlslrKJMcJZvFMtVZTC/PToXpElifvn3YClsfz2AoPwJGPTBN3+Q Y01N1HFicGjAzSz2/d0KuYOtCW88ctTocyT+GOMUapTOtnTdjAJs/hPv56bFWXeYe0 o1MJU2aAX0xWqoM50OayLwwNOACLQr1oTMuKIT9PdbQhW+5tbGpWjpeYWdTUEa64Gp F/f53FsfZZxzfwALuucn9/9j3vkb227bGsx4kUb+w44cVfy0naZIkS8mlZAiTyUqME ZZFxmfPs/e4jA== From: SeongJae Park To: Baolin Wang Cc: sj@kernel.org, akpm@linux-foundation.org, muchun.song@linux.dev, mike.kravetz@oracle.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/damon: replace pmd_huge() with pmd_trans_huge() for THP Date: Thu, 18 Aug 2022 16:47:22 +0000 Message-Id: <20220818164722.51448-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660856789; a=rsa-sha256; cv=none; b=eAYdMqn0dAvVGVAEnt36g03MHt0fvy7BcsRm1qpV2V4NUp48wqFb/nWS+B1i4JgYhze9cK 73I/TxirzDncRFqgfLYKTRVMzlRf/iC7ZiXeRUnpIDbKboHmGsw4S2CrL2GzbUMTx1HFWJ kGuERyOhUvm7gAaLm3Cn8j/Pi2HGHZE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LLH25lEp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660856789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=64jyYKbiHwigXyDTu3oq+4Khg+BRvXJOJwAy8Ko++yY=; b=Gaj2jcBaqMs7KXiF8QVG34t0mmbWy/ubYakfv4yA7jft94xZI6Jq3wZdbrPUf1vEePL1GA cjlU2RS5K7vvhqrYu0n1lbppWIrbixkHyWyVX4o1DSDgC6MUtoZ3ANxAciAGeEAjyqLuYo 1fDuKoaQYmIfEPQ1XqlWvwVLh2OqMU4= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LLH25lEp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Stat-Signature: hnqad6dyeepaicdorqseuktn8g395y8w X-Rspamd-Queue-Id: EB28640420 X-Rspamd-Server: rspam12 X-HE-Tag: 1660856788-639639 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baolin, On Thu, 18 Aug 2022 15:37:44 +0800 Baolin Wang wrote: > The pmd_huge() is usually used to indicate if a pmd level hugetlb, > however a pmd mapped huge page can only be THP in damon_mkold_pmd_entry() > or damon_young_pmd_entry(), so replacing pmd_huge() with pmd_trans_huge() > in this case to make code more readable according to the discussion [1]. Thanks to Baolin and Muchun for the discussion and this patch! > > [1] https://lore.kernel.org/all/098c1480-416d-bca9-cedb-ca495df69b64@linux.alibaba.com/ > > Signed-off-by: Baolin Wang Reviewed-by: SeongJae Park Thanks, SJ [...]