From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 6/6] mm, hwpoison: avoid trying to unpoison reserved page
Date: Thu, 18 Aug 2022 21:00:16 +0800 [thread overview]
Message-ID: <20220818130016.45313-7-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220818130016.45313-1-linmiaohe@huawei.com>
For reserved pages, HWPoison flag will be set without increasing the page
refcnt. So we shouldn't even try to unpoison these pages and thus decrease
the page refcnt unexpectly. Add a PageReserved() check to filter this case
out and remove the below unneeded zero page (zero page is reserved) check.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory-failure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 5f9615a86296..c831c41bb092 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2355,7 +2355,7 @@ int unpoison_memory(unsigned long pfn)
goto unlock_mutex;
}
- if (PageSlab(page) || PageTable(page))
+ if (PageSlab(page) || PageTable(page) || PageReserved(page))
goto unlock_mutex;
ret = get_hwpoison_page(p, MF_UNPOISON);
@@ -2386,7 +2386,7 @@ int unpoison_memory(unsigned long pfn)
freeit = !!TestClearPageHWPoison(p);
put_page(page);
- if (freeit && !(pfn == my_zero_pfn(0) && page_count(p) == 1)) {
+ if (freeit) {
put_page(page);
ret = 0;
}
--
2.23.0
next prev parent reply other threads:[~2022-08-18 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:00 [PATCH 0/6] A few fixup patches for hugetlb Miaohe Lin
2022-08-18 13:00 ` [PATCH 1/6] mm, hwpoison: fix page refcnt leaking in try_memory_failure_hugetlb() Miaohe Lin
2022-08-19 5:20 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 2/6] mm, hwpoison: fix page refcnt leaking in unpoison_memory() Miaohe Lin
2022-08-19 5:21 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 3/6] mm, hwpoison: fix extra put_page() in soft_offline_page() Miaohe Lin
2022-08-19 5:21 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 4/6] mm, hwpoison: fix possible use-after-free in mf_dax_kill_procs() Miaohe Lin
2022-08-19 5:23 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-19 7:32 ` Miaohe Lin
2022-08-18 13:00 ` [PATCH 5/6] mm, hwpoison: kill procs if unmap fails Miaohe Lin
2022-08-19 5:24 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-19 7:37 ` Miaohe Lin
2022-08-19 8:18 ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` Miaohe Lin [this message]
2022-08-19 5:24 ` [PATCH 6/6] mm, hwpoison: avoid trying to unpoison reserved page HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:05 ` [PATCH 0/6] A few fixup patches for hugetlb Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818130016.45313-7-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox