linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linmiaohe@huawei.com>
Subject: [PATCH 1/6] mm, hwpoison: fix page refcnt leaking in try_memory_failure_hugetlb()
Date: Thu, 18 Aug 2022 21:00:11 +0800	[thread overview]
Message-ID: <20220818130016.45313-2-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220818130016.45313-1-linmiaohe@huawei.com>

When hwpoison_filter() refuses to hwpoison a hugetlb page, the refcnt of
the page would have been incremented if res == 1. Using put_page() to fix
the refcnt leaking in this case.

Fixes: 405ce051236c ("mm/hwpoison: fix race between hugetlb free/demotion and memory_failure_hugetlb()")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/memory-failure.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index e48f6f6a259d..22840cd5fe59 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -1860,8 +1860,10 @@ static int try_memory_failure_hugetlb(unsigned long pfn, int flags, int *hugetlb
 
 	if (hwpoison_filter(p)) {
 		hugetlb_clear_page_hwpoison(head);
-		res = -EOPNOTSUPP;
-		goto out;
+		unlock_page(head);
+		if (res == 1)
+			put_page(head);
+		return -EOPNOTSUPP;
 	}
 
 	/*
-- 
2.23.0



  reply	other threads:[~2022-08-18 20:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 13:00 [PATCH 0/6] A few fixup patches for hugetlb Miaohe Lin
2022-08-18 13:00 ` Miaohe Lin [this message]
2022-08-19  5:20   ` [PATCH 1/6] mm, hwpoison: fix page refcnt leaking in try_memory_failure_hugetlb() HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 2/6] mm, hwpoison: fix page refcnt leaking in unpoison_memory() Miaohe Lin
2022-08-19  5:21   ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 3/6] mm, hwpoison: fix extra put_page() in soft_offline_page() Miaohe Lin
2022-08-19  5:21   ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 4/6] mm, hwpoison: fix possible use-after-free in mf_dax_kill_procs() Miaohe Lin
2022-08-19  5:23   ` HORIGUCHI NAOYA(堀口 直也)
2022-08-19  7:32     ` Miaohe Lin
2022-08-18 13:00 ` [PATCH 5/6] mm, hwpoison: kill procs if unmap fails Miaohe Lin
2022-08-19  5:24   ` HORIGUCHI NAOYA(堀口 直也)
2022-08-19  7:37     ` Miaohe Lin
2022-08-19  8:18       ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:00 ` [PATCH 6/6] mm, hwpoison: avoid trying to unpoison reserved page Miaohe Lin
2022-08-19  5:24   ` HORIGUCHI NAOYA(堀口 直也)
2022-08-18 13:05 ` [PATCH 0/6] A few fixup patches for hugetlb Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818130016.45313-2-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox