From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C4AC00140 for ; Thu, 18 Aug 2022 04:41:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18F328D0001; Thu, 18 Aug 2022 00:41:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13FC96B0074; Thu, 18 Aug 2022 00:41:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 007988D0001; Thu, 18 Aug 2022 00:41:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E706C6B0073 for ; Thu, 18 Aug 2022 00:41:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A6AA7AC235 for ; Thu, 18 Aug 2022 04:41:30 +0000 (UTC) X-FDA: 79811464740.27.4D6790D Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf31.hostedemail.com (Postfix) with ESMTP id 564BB201DB for ; Thu, 18 Aug 2022 04:41:30 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id r22so405432pgm.5 for ; Wed, 17 Aug 2022 21:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=vBRqm9P3PucMWPQft7rdPQr1jzE78rWkm5My0QOmYqo=; b=UCQPCkZxgSVgVfRvBD0lBiCJunMG+AZUrfKK6u3u6vnAu8eN28E04dT7SORQZDT/VM geGH1MvNA8tLwbmpRVGFoYKnjvPZwZC5qqcwyGIc9K4Qur/gDNaayEpYMhGFdnxYfWxF eQ/VY6GbHcM2BV3Zl1TwZFSNOAWDstV+t2e3HMxeSbbtAQYAAIC6gWlk8t7RX+H8MKWq AjuvHOKJO/KH9jqWv1uwDRKFw6yCvW/qsEjgb3Kcri68s4VYK664rvNBFtgAubzsUut+ QoD4UyyjK+RFDsMPOokQ2YSz4OnQ9a7r/9/G7bAil8/StmX0pYp8aLW5CnHvmbOSTxZN t+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=vBRqm9P3PucMWPQft7rdPQr1jzE78rWkm5My0QOmYqo=; b=AadEFHE3tEGmZqYoHbT8gPEhDEoiXbJjKCXh09Vf/SKSkEutnVBhbgLG2ukTumI1O/ TpmnrWYSGroz1dwj3/8kSB3Uq0x3nfqb6v2zmQ55/gnU70AF5oWv8gObnoOK0UZvm6x9 pTkRmXeOnWRBLV1sdPIhbW4oGtPYG30jVVwN1xvta9EFm0ZLOjXEjaN8rGyLYUKbkPj6 NQ04VoSaAlQq5aEdSGTT6hoFSdgXZQZfX+JqMRSYoopvpfTfPLFm82AbbOglB9ZDSSjA QUC4wVb+WgSeuxF2mKl1jO+9vjXJyLxA4US9BJ0Q0qJelHb5WMCO2Kp7VxUIM7Q+a8Jd mopQ== X-Gm-Message-State: ACgBeo3m9m0tVRzxJyxQ9N3vU54NTt40+KqazRrwIdXuj08C/h8+aY5l Ylv3Ywn3PujL0aAZumQD7hA= X-Google-Smtp-Source: AA6agR7ueq3jiFzDIJuD4hrbZTfz4hqe2+zWTcQBHHHcnXdOG0+5px+2XucU7nxCfUvB3L77RDBKfQ== X-Received: by 2002:a63:6b81:0:b0:41c:3a8c:b4fe with SMTP id g123-20020a636b81000000b0041c3a8cb4femr1186114pgc.84.1660797689286; Wed, 17 Aug 2022 21:41:29 -0700 (PDT) Received: from localhost ([2406:7400:63:e947:599c:6cd1:507f:801e]) by smtp.gmail.com with ESMTPSA id r12-20020aa7962c000000b0052e988c1630sm411044pfg.138.2022.08.17.21.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 21:41:28 -0700 (PDT) Date: Thu, 18 Aug 2022 10:11:23 +0530 From: Ritesh Harjani To: Alexander Atanasov Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nadav Amit , VMware PV-Drivers Reviewers , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang , Andrew Morton , kernel@openvz.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] Make place for common balloon code Message-ID: <20220818044123.q5yzdaszcxl7mcl6@riteshh-domain> References: <20220816094117.3144881-1-alexander.atanasov@virtuozzo.com> <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816094117.3144881-2-alexander.atanasov@virtuozzo.com> ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UCQPCkZx; spf=pass (imf31.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660797689; a=rsa-sha256; cv=none; b=5gdkExJ9v469wnrtRRYwh+a7AkVZYw7g/jSiIKvBo5xGtKJuQ8rbpt7LFtg1CAvfr5IiSZ w2/SAPOWLXDmHkLnK6/vgdLZ/B6lhUrN7JH6MR5a5rJxGNObFNeHko7jZE9DjB1OtI9d/D PsGowUABxC3YeSc7ndrqftOuafTdCsU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660797689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vBRqm9P3PucMWPQft7rdPQr1jzE78rWkm5My0QOmYqo=; b=77JH4uf/w1OezZEd+fZ4BJZ6nZPtQSbM3w9/1P3dxQhO4Ffwz4VI7OBGTvPpby1A6qDDT/ x8KtkZOqNFD8iYgiS2me4bVyYyP701Ol/t2N6PdlM/kVTtdqqw5lRoAZiLkaB8njDsH5TO SF4pLgKVaJsc+4c/eAr4gWUrXzTy+yk= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UCQPCkZx; spf=pass (imf31.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: wed85ebjks46xw7m343upcgdspxkcnqo X-Rspamd-Queue-Id: 564BB201DB X-Rspamd-Server: rspam05 X-HE-Tag: 1660797690-65229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22/08/16 12:41PM, Alexander Atanasov wrote: > File already contains code that is common along balloon > drivers so rename it to reflect its contents. > mm/balloon_compaction.c -> mm/balloon_common.c > > Signed-off-by: Alexander Atanasov > --- > MAINTAINERS | 4 ++-- > arch/powerpc/platforms/pseries/cmm.c | 2 +- > drivers/misc/vmw_balloon.c | 2 +- > drivers/virtio/virtio_balloon.c | 2 +- > include/linux/{balloon_compaction.h => balloon_common.h} | 2 +- > mm/Makefile | 2 +- > mm/{balloon_compaction.c => balloon_common.c} | 4 ++-- > mm/migrate.c | 2 +- > mm/vmscan.c | 2 +- I think we don't need balloon headers in above two files at all. I don't see any references of balloon functions in them. I guess this commit removed it - commit b1123ea6d3b3da25af5c8a9d843bd07ab63213f4 Author: Minchan Kim Date: Tue Jul 26 15:23:09 2016 -0700 mm: balloon: use general non-lru movable page feature Now, VM has a feature to migrate non-lru movable pages so balloon doesn't need custom migration hooks in migrate.c and compaction.c. Instead, this patch implements the page->mapping->a_ops-> {isolate|migrate|putback} functions. With that, we could remove hooks for ballooning in general migration functions and make balloon compaction simple. Since I don't often look into this side of code, it's better to confirm :) -ritesh