From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DDAC32772 for ; Wed, 17 Aug 2022 21:14:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0228E8D0002; Wed, 17 Aug 2022 17:14:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F14616B0074; Wed, 17 Aug 2022 17:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDC0E8D0002; Wed, 17 Aug 2022 17:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CAB546B0073 for ; Wed, 17 Aug 2022 17:14:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 944BF4095E for ; Wed, 17 Aug 2022 21:14:01 +0000 (UTC) X-FDA: 79810337040.27.5F759EE Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf02.hostedemail.com (Postfix) with ESMTP id 3F13480039 for ; Wed, 17 Aug 2022 21:14:01 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-3360c0f0583so18620527b3.2 for ; Wed, 17 Aug 2022 14:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=URg+UMQZgJAJZD19p4gwvvadtL6QiS5A6GMenmjwJgY=; b=SRObGBGBG2sRxe2+tGmXszzXIzti/OIGxkLLhYH/K9EzOKWGAOSbFZcnNiSbSrfEH1 IS03Ciz5Y5XLkip4EtQzvRPLpihmjrh/kzWkFvimmx1y/IMQfU8uz8sSVeXI70UajTdv VEPUBCb/EaS6GLIE9GpsLB+ouvqg5iovDF9cmXOrKm9tsHMfQ1Jfued6B9TLqONuxlcz 5jswcGo+LoYU8w3wK6e6vvrXw1U2Oher3+46zQDHkwPj5fzemLZ+5CSQF5b46ZC9+djo UXjXOpcwSjExip49HwmqLqdjoPKWC+gXaUHyhunxTTeeKEN9pJGOodbr+X2YitB8bnA2 k7EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=URg+UMQZgJAJZD19p4gwvvadtL6QiS5A6GMenmjwJgY=; b=IpLIHSOaoLfuPyqLAVoW9sS+EEB4ZiZ6PDbnpme1FX/Nazg/I8jBltR2F01Zbkjf+w UvIduioErICteo6bxrkgVJrWoSjOxstNS3/dDwIzvBXKOVqGV0/BHDiVaxKDAmAm9Myh 4/IwW9ZfO3Tc+AUeI1JSy2tLJmbnhnKcBr55eJo6mep0t0z7p+tB1wHhgUdM2R0oDhdr 61aG8xDEUPzHFzuhw8R1qnL2xY7Mje2yihjQX0j+PyblDXhIbAp4zaLHwbhhjSyNrq87 37040Kh8Qp8Uoiq+tewYAC8ErsNSUMVhhn3j1iaWVSdpsiceeddFsbepH3hcw4cFqMnX q56Q== X-Gm-Message-State: ACgBeo06kSO31Ozm0NgGSJyx7ks8KlbX5g3xsDjHiEl1gRg6iETlR1cw dQ0821VYyn/st6irb7QsFQiXJdHBcOh1A0Fj18sM X-Google-Smtp-Source: AA6agR6WBtTNLco5wa8t9uk8XSJjuDXXNwRdbOpIyGssHp2EbU6D8jDQ4yBgt9G5ppX7ffVKK3xkGU+G4y+8VrFU7KYb X-Received: from ajr0.svl.corp.google.com ([2620:15c:2d4:203:2f41:f176:4bac:b729]) (user=axelrasmussen job=sendgmr) by 2002:a81:ad58:0:b0:329:5b1:106e with SMTP id l24-20020a81ad58000000b0032905b1106emr10097ywk.371.1660770840476; Wed, 17 Aug 2022 14:14:00 -0700 (PDT) Date: Wed, 17 Aug 2022 14:13:56 -0700 Message-Id: <20220817211356.273019-1-axelrasmussen@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: [PATCH] selftests/vm: fix inability to build any vm tests From: Axel Rasmussen To: Andrew Morton , Shuah Khan , Guillaume Tucker Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Axel Rasmussen Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SRObGBGB; spf=pass (imf02.hostedemail.com: domain of 3GFr9Yg0KCN8BYFMSBTNVTTFOHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--axelrasmussen.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3GFr9Yg0KCN8BYFMSBTNVTTFOHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--axelrasmussen.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660770840; a=rsa-sha256; cv=none; b=GS4IshPilO4DewckgXvaUitLrk2TNz0aIqj+z2gfp9Yo/j/xmLT7hA6YXmXgl5tjUN9ihz YO86nQwZhWXCVpQDf+MKrUVFkM8roBtgJVmkQHYQnd4Mrksqlxpouda+5OS55IsBb433le UEp6eVjahtnmv2KFqifwRmSgBE+sKuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660770840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=URg+UMQZgJAJZD19p4gwvvadtL6QiS5A6GMenmjwJgY=; b=F6dR8A27l5trJVbsKefrw9bn9cLyLRkWI9UB26Ohg+KVyK72sSGWmftow+RyX+UtZZen/q 8azLuyvPXfIEeF84Vm5InFOdL3lDRpNOvDRP82r9Ep1mXmg0xQf5HjoDogb32K+4ZIgQJ0 n3Ku05ON0w6BB1x68CIChn/i3BTUaZY= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SRObGBGB; spf=pass (imf02.hostedemail.com: domain of 3GFr9Yg0KCN8BYFMSBTNVTTFOHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--axelrasmussen.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3GFr9Yg0KCN8BYFMSBTNVTTFOHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--axelrasmussen.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Stat-Signature: mgg5k3kbs5jdprbc14k8nyknpzfyj35u X-Rspamd-Queue-Id: 3F13480039 X-Rspamd-Server: rspam05 X-HE-Tag: 1660770841-674445 X-Bogosity: Ham, tests=bogofilter, spamicity=0.124796, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When we stopped using KSFT_KHDR_INSTALL, a side effect is we also changed the value of `top_srcdir`. This can be seen by looking at the code removed by: 49de12ba06ef ("selftests: drop KSFT_KHDR_INSTALL make target"): (Note though that this commit didn't break this, technically the one before it did since that's the one that stopped KSFT_KHDR_INSTALL from being used, even though the code was still there.) Previously lib.mk reconfigured `top_srcdir` when KSFT_KHDR_INSTALL was being used. Now, that's no longer the case. As a result, the path to gup_test.h in vm/Makefile was wrong, and since it's a dependency of all of the vm binaries none of them could be built. Instead, we'd get an "error" like: make[1]: *** No rule to make target '/[...]/tools/testing/selftests/vm/compaction_test', needed by 'all'. Stop. If we specify the path of gup_test.h relatively using selfdir instead, now it is found correctly, and things work again. Fixes: f2745dc0ba3d ("selftests: stop using KSFT_KHDR_INSTALL") Signed-off-by: Axel Rasmussen --- tools/testing/selftests/vm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index d9fa6a9ea584..f2a12494f2d8 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 # Makefile for vm selftests -LOCAL_HDRS += $(selfdir)/vm/local_config.h $(top_srcdir)/mm/gup_test.h +LOCAL_HDRS += $(selfdir)/vm/local_config.h $(selfdir)/../../../mm/gup_test.h include local_config.mk -- 2.37.1.595.g718a3a8f04-goog