From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE62C25B08 for ; Wed, 17 Aug 2022 15:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DB6A6B0073; Wed, 17 Aug 2022 11:48:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28ACD8D0001; Wed, 17 Aug 2022 11:48:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1799E6B0075; Wed, 17 Aug 2022 11:48:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 050606B0073 for ; Wed, 17 Aug 2022 11:48:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C6C901A16D4 for ; Wed, 17 Aug 2022 15:48:38 +0000 (UTC) X-FDA: 79809517116.29.48CE64D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 511FC4019B for ; Wed, 17 Aug 2022 15:48:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A7B85B81E0D; Wed, 17 Aug 2022 15:48:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26772C433C1; Wed, 17 Aug 2022 15:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660751314; bh=AHeZfy/Nxh85RKgqk8hL9JaiFYeWKnNM/yiUeuArn60=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BtXfFWzsCJkDcjy2yOzYGhRdcGusJrTQhO8VRzdx5/NBDr4bqcyLOnZm+gVi/kq8R 7xpEIDDriJXwmkzaJaBW0UfxrqCSA9Cv5jaZ1CFMVlpWKKTWL67YUk5B5xNdDK2llZ UGQFwn2z0wli5tDoM2zTwWdzcxCGqLVdB886By5U= Date: Wed, 17 Aug 2022 08:48:33 -0700 From: Andrew Morton To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi , Oscar Salvador Subject: Re: [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path Message-Id: <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> In-Reply-To: <20220817081408.513338-1-ying.huang@intel.com> References: <20220817081408.513338-1-ying.huang@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660751317; a=rsa-sha256; cv=none; b=J9MxB8NiXikrWR17RzdJaEKjetp3MG7gImtn1xICfD+17X4aSagAJQwbcy/LbumREtnPab P7OphAIxYFNTTRlqb3X97q3l2K5SfqLM57k2T2HPOwEcrSfxpHmoglQsoim4sbuCmpSPNN kvzaEE7ubr0eTFieakW54dAtyN43i2s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BtXfFWzs; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660751317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WpyAJTVrfZCL2h1isVm7JNN8VN0Fv44rHjgYEWg7qik=; b=dCtxXpA+gWn55fwHVGImkIWgKjrnnk/rK5PnQq2lJCxTSAgYyGn6D2xKu9x9MAGLdj5jk8 jOwquByqsmXP0aRAiL6K902OKSt4RCaUOC2nZ4RUPz4xGBQxIA6UoCpGQ9BydeKjkKh8dx tVvB489DfUFx2doW2KMWhEQcuC6F2Zg= X-Stat-Signature: o3uerxctjkngipqzxpk1rpc4kkamojy6 X-Rspamd-Queue-Id: 511FC4019B Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BtXfFWzs; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1660751317-199881 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 17 Aug 2022 16:14:00 +0800 Huang Ying wrote: > error-inject.patch, test-migrate.c, and test-migrate.sh are as below. > It turns out that error injection is an important tool to fix bugs in > error path. Indeed, and thanks for doing this. Did you consider lib/*inject*.c? If so, was it unsuitable?