From: Huang Ying <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Huang Ying <ying.huang@intel.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Oscar Salvador <osalvador@suse.de>, Zi Yan <ziy@nvidia.com>,
Yang Shi <shy828301@gmail.com>
Subject: [PATCH -V3 7/8] migrate_pages(): fix failure counting for retry
Date: Wed, 17 Aug 2022 16:14:07 +0800 [thread overview]
Message-ID: <20220817081408.513338-8-ying.huang@intel.com> (raw)
In-Reply-To: <20220817081408.513338-1-ying.huang@intel.com>
After 10 retries, we will give up and the remaining pages will be
counted as failure in nr_failed and nr_thp_failed. We should count
the failure in nr_failed_pages too. This is done in this patch.
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages")
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Yang Shi <shy828301@gmail.com>
---
mm/migrate.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 81daa4dd3bb6..55fbf9669431 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1413,6 +1413,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
int thp_retry = 1;
int nr_failed = 0;
int nr_failed_pages = 0;
+ int nr_retry_pages = 0;
int nr_succeeded = 0;
int nr_thp_succeeded = 0;
int nr_thp_failed = 0;
@@ -1433,6 +1434,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
for (pass = 0; pass < 10 && (retry || thp_retry); pass++) {
retry = 0;
thp_retry = 0;
+ nr_retry_pages = 0;
list_for_each_entry_safe(page, page2, from, lru) {
/*
@@ -1506,7 +1508,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
nr_failed++;
}
- nr_failed_pages += nr_subpages;
+ nr_failed_pages += nr_subpages + nr_retry_pages;
/*
* There might be some subpages of fail-to-migrate THPs
* left in thp_split_pages list. Move them back to migration
@@ -1522,6 +1524,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
thp_retry++;
else
retry++;
+ nr_retry_pages += nr_subpages;
break;
case MIGRATEPAGE_SUCCESS:
nr_succeeded += nr_subpages;
@@ -1548,6 +1551,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
if (!no_subpage_counting)
nr_failed += retry;
nr_thp_failed += thp_retry;
+ nr_failed_pages += nr_retry_pages;
/*
* Try to migrate subpages of fail-to-migrate THPs, no nr_failed
* counting in this round, since all subpages of a THP is counted
--
2.30.2
next prev parent reply other threads:[~2022-08-17 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 8:14 [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path Huang Ying
2022-08-17 8:14 ` [PATCH -V3 1/8] migrate: fix syscall move_pages() return value for failure Huang Ying
2023-07-26 10:15 ` Ryan Roberts
2023-07-28 0:57 ` Alistair Popple
2023-07-28 8:45 ` Ryan Roberts
2022-08-17 8:14 ` [PATCH -V3 2/8] migrate_pages(): remove unnecessary list_safe_reset_next() Huang Ying
2022-08-17 8:14 ` [PATCH -V3 3/8] migrate_pages(): fix THP failure counting for -ENOMEM Huang Ying
2022-08-17 8:14 ` [PATCH -V3 4/8] migrate_pages(): fix failure counting for THP subpages retrying Huang Ying
2022-08-17 8:14 ` [PATCH -V3 5/8] migrate_pages(): fix failure counting for THP on -ENOSYS Huang Ying
2022-08-17 8:14 ` [PATCH -V3 6/8] migrate_pages(): fix failure counting for THP splitting Huang Ying
2022-08-17 8:14 ` Huang Ying [this message]
2022-08-17 8:14 ` [PATCH -V3 8/8] mm: migrate: Do not retry 10 times for the subpages of fail-to-migrate THP Huang Ying
2022-08-17 15:48 ` [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path Andrew Morton
2022-08-18 0:51 ` Huang, Ying
2022-09-20 2:43 ` Huang, Ying
2022-09-21 0:52 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817081408.513338-8-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox