From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103CAC00140 for ; Mon, 15 Aug 2022 05:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C02F8D0007; Mon, 15 Aug 2022 01:41:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86EC58D0003; Mon, 15 Aug 2022 01:41:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736638D0007; Mon, 15 Aug 2022 01:41:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 60E088D0003 for ; Mon, 15 Aug 2022 01:41:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2BC4A1C6673 for ; Mon, 15 Aug 2022 05:41:36 +0000 (UTC) X-FDA: 79800729792.17.6F41FCA Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf11.hostedemail.com (Postfix) with ESMTP id 55A5340004 for ; Mon, 15 Aug 2022 05:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660542095; x=1692078095; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=B2uWyyHRSzgByKXaC+wjLJswLcAS9PxLK4BBhJ8umn8=; b=NBseCxRg3VSIp4bcEFTPMh+HzjCn5BlZuz1Td3zDcooKl1nM1wuXGcGT +72A8r2DZSBbNXqMCS2DeV/FHl946ZJeyLV+iK/yE/FMR0C+iV/3pPzTy 8WFBsx5lED1WvEOhws4qGCw2nkUOSYkpVDzthUxcIzku1YdtdDZ+ITbK9 ZRXRBrqzQBYETdTDN9bTfg1e9WoukOek5+flu40MaOVzbZQlf44RLG4ks ImK0YQkyd2FD/BjWlWV/0P4xutlWo9ZfwKk+Gv14IO45HSMBm195XdKPf Yq93DaTM4Vo3kx3lZqtfVIuwFS0tTe5J/QqoQA+3eFGQ8cOck2GRmylXp Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="317876203" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="317876203" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 22:41:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="639536842" Received: from lkp-server02.sh.intel.com (HELO 3d2a4d02a2a9) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 14 Aug 2022 22:41:28 -0700 Received: from kbuild by 3d2a4d02a2a9 with local (Exim 4.96) (envelope-from ) id 1oNSqu-0000oz-0t; Mon, 15 Aug 2022 05:41:28 +0000 Date: Mon, 15 Aug 2022 13:41:02 +0800 From: kernel test robot To: Zach O'Keefe , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , linux-api@vger.kernel.org, Axel Rasmussen , James Houghton , Hugh Dickins , Yang Shi , Miaohe Lin , David Hildenbrand , David Rientjes , Matthew Wilcox , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Chris Kennelly , "Kirill A. Shutemov" , Minchan Kim , Patrick Xia , Zach O'Keefe Subject: Re: [PATCH mm-unstable 3/9] mm/madvise: add file and shmem support to MADV_COLLAPSE Message-ID: <202208151331.uxreCJWj-lkp@intel.com> References: <20220812012843.3948330-4-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220812012843.3948330-4-zokeefe@google.com> ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=NBseCxRg; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660542095; a=rsa-sha256; cv=none; b=dpWUVdNt0sk2FNc+U7SffS4xQRJCKw/f8o0YoGmuWuveh96QGj80OgmymbhSZZZFcBLo+O 0aihbIIWXihDcKYgYgkzDEmxPfYFIoOCY+y7jfyQJvcRswvkSYExisBKbybjr8kZdsEhvB kjb2a/mOrQcMsauB3kHaO/CU3GSQJz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660542095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+SP6asFgL04LSOhaYTqe9ilNdQeIO8n8VIh3YcdLzWU=; b=6LLLlDR3n9z8mEk6AzYczfNRQw/MVCNdBTs/4oI/UITi8iKXv3JzAdeYcKgafRqMwMfGxw hv2rN9teEjiY8Lg4+DY2Ib6zJAQpLQ3EdCBgv5Ea1NklIqHSivUdzHFBigV4rgYIzr1jUe Yw7Ppz8awqXgYw6MlxbP87izOhWXX4U= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=NBseCxRg; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com X-Stat-Signature: fph7dtcaz1o8uss5tc9n3jxy3bbbi5wi X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 55A5340004 X-HE-Tag: 1660542095-228417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220815/202208151331.uxreCJWj-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/dff08746d6f7b9387b94360b66bd9db644542991 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 git checkout dff08746d6f7b9387b94360b66bd9db644542991 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/khugepaged.c: In function 'set_huge_pmd': >> mm/khugepaged.c:1403:13: error: assignment of read-only variable 'vmf' 1403 | vmf = (struct vm_fault) { | ^ vim +/vmf +1403 mm/khugepaged.c 1393 1394 /* hpage must be locked, and mmap_lock must be held in write */ 1395 static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, 1396 pmd_t *pmdp, struct page *hpage) 1397 { 1398 struct vm_fault vmf; 1399 1400 VM_BUG_ON(!PageTransHuge(hpage)); 1401 mmap_assert_write_locked(vma->vm_mm); 1402 > 1403 vmf = (struct vm_fault) { 1404 .vma = vma, 1405 .address = addr, 1406 .flags = 0, 1407 .pmd = pmdp, 1408 }; 1409 1410 if (do_set_pmd(&vmf, hpage)) 1411 return SCAN_FAIL; 1412 1413 get_page(hpage); 1414 return SCAN_SUCCEED; 1415 } 1416 -- 0-DAY CI Kernel Test Service https://01.org/lkp