From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14365C3F6B0 for ; Mon, 15 Aug 2022 17:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 736656B0073; Mon, 15 Aug 2022 13:53:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BEDB6B0075; Mon, 15 Aug 2022 13:53:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 538E28D0001; Mon, 15 Aug 2022 13:53:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 407376B0073 for ; Mon, 15 Aug 2022 13:53:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 20C951A055A for ; Mon, 15 Aug 2022 17:53:03 +0000 (UTC) X-FDA: 79802573046.17.6076AAD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 8366D40049 for ; Mon, 15 Aug 2022 17:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660585980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=15DarLJ2UNtljDu/NGD1MWWRNaKZ/jpeSOvRGy2XtIg=; b=gp0efAlEU1uL5BpcAk/WjsEdBLO1aEJLIV1IJTSxTuHYIzBVikB+JI0SffcDjVEh2SR4E7 timDeKsbntLf5wPSBX3OFQnXUwta7bJhInfNaqvUAo047ZrRY1lziF+bgkAhVUhnt0ER5+ c+8kFJrfks08VcTZULv4WT5+cKxF5wI= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-580-v31RFSxLP9CrJ5lZIKULHA-1; Mon, 15 Aug 2022 13:52:59 -0400 X-MC-Unique: v31RFSxLP9CrJ5lZIKULHA-1 Received: by mail-il1-f199.google.com with SMTP id a13-20020a921a0d000000b002e5f544ee47so438526ila.9 for ; Mon, 15 Aug 2022 10:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc; bh=15DarLJ2UNtljDu/NGD1MWWRNaKZ/jpeSOvRGy2XtIg=; b=Z+RL49AtPSxRHna/yOm5uPK8ux7HSh4CxByoa78Fttgs++dkCWlcEmAZzO9F7i/7X9 bZoXma8E9aKxybinUtYpmb1p9ZaR+5Lsjaa9qBMmTh5yt9fagPGTzbBx0ZUplAQT1hij N33sNwY0+teJS+LBX/eXWEKeM3n9/NNQNovGIlew82pay+RDn/aZ5Rp7tiAEXm1ADUWf KQGYIez0Mn1hvsjewC8rPRclM6SHc+6rWF06m18moelBI+U7T4VrbAMqilHoxuem+EP9 89wvFRG96isoGaDyZjrjBswHydIx0KHI9flRYdci0hFsCDlYDhe6oNklfK2UFdYBWKNo szgg== X-Gm-Message-State: ACgBeo1RqaoS5rExEq7Yj7/apGkvEg4SLy9Ec2K/rP1s03mlPQkJoow/ wplitwkNafedvbebkYW8ns0n+SS4jp7Bfr+MfpK16Ic1muuIFOlSZXMpuHXqnjr/ZSaTWbOAdpG J/Awl9cF3kro= X-Received: by 2002:a05:6638:3042:b0:341:d6bc:7bcb with SMTP id u2-20020a056638304200b00341d6bc7bcbmr7980398jak.258.1660585977761; Mon, 15 Aug 2022 10:52:57 -0700 (PDT) X-Google-Smtp-Source: AA6agR5i405dJBqXB2wpppUqalkB8ihdyscxF3U7r8/rlm/W+0QAFhdvG9A3oewmE0CBh6DjjHAFNA== X-Received: by 2002:a05:6638:3042:b0:341:d6bc:7bcb with SMTP id u2-20020a056638304200b00341d6bc7bcbmr7980385jak.258.1660585977539; Mon, 15 Aug 2022 10:52:57 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id i19-20020a02b693000000b0034340aa5ecdsm3614653jam.23.2022.08.15.10.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 10:52:57 -0700 (PDT) Date: Mon, 15 Aug 2022 11:52:55 -0600 From: Alex Williamson To: Yishai Hadas , Cc: , , jason Gunthorpe , "maor Gottlieb" , "kvm@vger.kernel.org" , Subject: Re: Bug report: vfio over kernel 5.19 - mm area Message-ID: <20220815115255.60eaee8b.alex.williamson@redhat.com> In-Reply-To: <0e8a0d16-3c6f-a649-44b3-ab960801d90f@nvidia.com> References: <3391f2e5-149a-7825-f89e-8bde3c6d555d@nvidia.com> <20220615080228.7a5e7552.alex.williamson@redhat.com> <0e8a0d16-3c6f-a649-44b3-ab960801d90f@nvidia.com> Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660585982; a=rsa-sha256; cv=none; b=2z9NgrBsTAOR67yjkhRKvGiim8KTbvG0jeI4irifFBTghSxpg+6CzbY+Dl/bp9E4vbuQwJ jxSLXgMPbkxHzBysGt+HfoXZmWpa4lID6fJnk0aS5PBQrxBRJPrgGD8mRI98E29IZ55VXo 7U4u1RvLEvtwzb5sBTqMIvcbQQzVLj0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp0efAlE; spf=pass (imf11.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660585982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=15DarLJ2UNtljDu/NGD1MWWRNaKZ/jpeSOvRGy2XtIg=; b=sYOY1DHZ0ovAvKcYaeyZdx6FU6DhhyzTkX4SUwf7tFN0Qb0/fiKfeUesbXBxmv5W3mVk5g JhKAabBdb8EMr1DjittTz06b3h5LE8LzEPqfy+Al7LNPr1mV35AsEtcY+H7d5Vjytrh62b y+aUUXlSQyXuS8WH7YIQMrVzgLw2+ic= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8366D40049 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gp0efAlE; spf=pass (imf11.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: nastotzzdd947m1z499txwhs7wyfbdmi X-HE-Tag: 1660585980-775594 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 15 Aug 2022 18:46:40 +0300 Yishai Hadas wrote: > On 15/06/2022 17:02, Alex Williamson wrote: > > On Wed, 15 Jun 2022 13:52:10 +0300 > > Yishai Hadas wrote: > > > >> Adding some extra relevant people from the MM area. > >> > >> On 15/06/2022 13:43, Yishai Hadas wrote: > >>> Hi All, > >>> > >>> Any idea what could cause the below break in 5.19 ? we run QEMU and > >>> immediately the machine is stuck. > >>> > >>> Once I run, echo l > /proc/sysrq-trigger could see the below task > >>> which seems to be stuck.. > >>> > >>> This basic flow worked fine in 5.18. > > Spent Friday bisecting this and posted this fix: > > > > https://lore.kernel.org/all/165490039431.944052.12458624139225785964.stgit@omen/ > > > > I expect you're hotting the same. Thanks, > > > > Alex > > Alex, > > It seems that we got the same bug again in V6.0 RC1 .. > > The below code [1] from commit [2], put back the 'is_zero_pfn()' under > the !(..) and seems buggy. > > I would expect the below fix for that [3]. > > Alex Sierra, > > Can you please review the below suggested fix for your patch and send a > patch for RC2 accordingly ? > https://lore.kernel.org/all/166015037385.760108.16881097713975517242.stgit@omen/ It's in the mm tree, hopefully it'll get pushed in an early rc. Thanks, Alex