From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083BEC25B06 for ; Mon, 15 Aug 2022 01:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5794B8D0001; Sun, 14 Aug 2022 21:24:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527D96B0074; Sun, 14 Aug 2022 21:24:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EEA68D0001; Sun, 14 Aug 2022 21:24:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2CF6A6B0073 for ; Sun, 14 Aug 2022 21:24:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F2A181A0501 for ; Mon, 15 Aug 2022 01:24:11 +0000 (UTC) X-FDA: 79800081102.01.B90AF7F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf31.hostedemail.com (Postfix) with ESMTP id 874462006B for ; Mon, 15 Aug 2022 01:24:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C299B80B97; Mon, 15 Aug 2022 01:24:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DD38C433C1; Mon, 15 Aug 2022 01:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660526648; bh=iEndjKkMdlVw3ow/e1CXMvAAMn4Hvk9j70OKtvk/4ZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z6lF0ACRn6zF/AnUUFkmpTuID0aajPFO/7Fyr1T0S+zIXY5BPHSJW9C4bhDxtFcTz 7JONjBjpc3WmLnlUcKykB2o52mtJpZLJ0o/Wwc1D0DL8CqK+i3Tnn5ycvHhX6P+aDy RKnbYMSgqOapC8r5VV8AyhPBdD+xtk3GL1CotGuI= Date: Sun, 14 Aug 2022 18:24:07 -0700 From: Andrew Morton To: Mel Gorman Cc: Chuyi Zhou , linux-mm@kvack.org Subject: Re: [PATCH v3] mm/compaction: fix set skip in fast_find_migrateblock Message-Id: <20220814182407.5bc022265a66221de1796466@linux-foundation.org> In-Reply-To: <20220719082854.GB3563@techsingularity.net> References: <20220713062009.597255-1-zhouchuyi@bytedance.com> <20220713082814.bed234e00d7f5ceb3858352a@linux-foundation.org> <20220714115020.GA3563@techsingularity.net> <3529e159-8c22-5d67-5e5d-c912784df9a0@bytedance.com> <20220719082854.GB3563@techsingularity.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660526651; a=rsa-sha256; cv=none; b=vZv/JpFDN0B2E66lG9VKJLY5bf75y1Ar4fLhFgPzssA8jJ5KVqVmRwkzsBOBgBa1u89DjC Jk34Tu6TVPx0ZLfw6CI8/RyQAt687D83S7IwMPlPnn+KwEswTVrIiXbO4WhLFdVKNXXcDV R8gYHK7C8+Ql1JLvrtFzpJDGiy7HXkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660526651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kH/IZv+H1gCmO7MNZt80iZyxTWdA8UrOBmFS+657MTM=; b=Fz9TRyh+ZP4TTLDDmqvJj68chz5smYxVI+2bxgE20NDwZ19VpG11/4pb1Jyw6Oe2GUZlU0 87xw9K8sJs8gbSpqhf6zD2MorGO5WOY78nVk/taanQ0LGemjclELse4k2ozyUCUn767sj9 KTDyQJVQahjXREcAkLfd1OPEnXH4l80= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=z6lF0ACR; spf=pass (imf31.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: ctsdfftwspkjhz1k8qngm1n9qktgjpi7 X-Rspamd-Queue-Id: 874462006B Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=z6lF0ACR; spf=pass (imf31.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1660526651-480211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 19 Jul 2022 09:28:54 +0100 Mel Gorman wrote: > The return block indeed may not be aligned. It could simply be a > restart. The changelog could still do with a little clarification but > your patch is still fine. I'm not seeing a v4 so I merged the v3. It would be great if someone could please send along an updated changelog?