From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C99C25B0F for ; Mon, 15 Aug 2022 00:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A40528D0001; Sun, 14 Aug 2022 20:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF296B0074; Sun, 14 Aug 2022 20:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DE418D0001; Sun, 14 Aug 2022 20:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7F16C6B0073 for ; Sun, 14 Aug 2022 20:17:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D206804D5 for ; Mon, 15 Aug 2022 00:17:57 +0000 (UTC) X-FDA: 79799914194.17.26AEA3D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id B21851401B3 for ; Mon, 15 Aug 2022 00:17:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B9D2BCE0BAA; Mon, 15 Aug 2022 00:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4757C433C1; Mon, 15 Aug 2022 00:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660522672; bh=1asjCdG2YjeCaG6oCo5BXz+9uNtqjJ1F5D1TkIiGuOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nBClIhA5cHZDJ9j5x3vyso3d6VXaxu4thzAY4HdiugFYbzG7vrh25SMcRQKKFEDFF GHZBvZcsL5TYxY7fHw9BKpiMFczLvMMZxLaywLXFaKoD8aqlHhvVl2137iRYf0etIY /+x7FLmZg3RTiPSPgwBOx7J3V0zvFQYfJE4+f6a0= Date: Sun, 14 Aug 2022 17:17:50 -0700 From: Andrew Morton To: Chao Xu Cc: , Subject: Re: [PATCH] mm: remove duplicate mm_types.h and unnecessary declare Message-Id: <20220814171750.858b89dca1042fd46ec2fc94@linux-foundation.org> In-Reply-To: <20220727151527.8054-1-Chao.Xu9@zeekrlife.com> References: <20220727151527.8054-1-Chao.Xu9@zeekrlife.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660522677; a=rsa-sha256; cv=none; b=aFIVxam2kD2/NiOnBkmeeTtAtd6T0z4KSUK1rJiFnNCqV5luN2FFsbSn0kTj2hJ3eVfQMQ HhI12LWp68tM+HmM4eAwREQ5vFR82MWXahaayIt32iXTcjAyUhS0U8P8G0CBjJxeZT34E+ hifC8ME0H+JJ93l0mUIftw9EviXHAuA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nBClIhA5; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660522677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1MPApOErtBvlGafFLYRXW9HTnHKdnvyiX/aAmBKwZ6Y=; b=2hg6hDCEbaMEETLYUVN3tB/QmARWzL0WUSt+yd7PjZlRIMiS9X4iLTVWIoKzUzrpUBXLfB xGENjCEn1m1llTrivy5PmDUAqqr9mmDjaBqPhUSZjA2we242tVSieQNiIOm6D55mkI0p9r 3sdScNBLjrpI9p5u92kXl44WcostkeY= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B21851401B3 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nBClIhA5; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: r7d7jg85wmib3y87k4ne7i1gpxyhzma9 X-Rspam-User: X-HE-Tag: 1660522676-836206 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Jul 2022 23:15:27 +0800 Chao Xu wrote: > mm_types.h have already in page-flags.h. Duplicated import > header file and struct page declare is not needed. It's better to (as much as possible) explicitly include the needed headers, rather than reply upon nested includes which might change in the future. This isn't theoretical. We regularly get build breakage when rework of one header exposes unexpected dependencies within another file.