From: Andrew Morton <akpm@linux-foundation.org>
To: Chao Xu <Chao.Xu9@zeekrlife.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: remove duplicate mm_types.h and unnecessary declare
Date: Sun, 14 Aug 2022 17:17:50 -0700 [thread overview]
Message-ID: <20220814171750.858b89dca1042fd46ec2fc94@linux-foundation.org> (raw)
In-Reply-To: <20220727151527.8054-1-Chao.Xu9@zeekrlife.com>
On Wed, 27 Jul 2022 23:15:27 +0800 Chao Xu <Chao.Xu9@zeekrlife.com> wrote:
> mm_types.h have already in page-flags.h. Duplicated import
> header file and struct page declare is not needed.
It's better to (as much as possible) explicitly include the needed headers,
rather than reply upon nested includes which might change in the future.
This isn't theoretical. We regularly get build breakage when rework of
one header exposes unexpected dependencies within another file.
prev parent reply other threads:[~2022-08-15 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 15:15 Chao Xu
2022-08-15 0:17 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220814171750.858b89dca1042fd46ec2fc94@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Chao.Xu9@zeekrlife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox