linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Haiyue Wang <haiyue.wang@intel.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, david@redhat.com,
	linmiaohe@huawei.com, ying.huang@intel.com,
	songmuchun@bytedance.com, naoya.horiguchi@linux.dev,
	alex.sierra@amd.com, Haiyue Wang <haiyue.wang@intel.com>
Subject: [PATCH v2 3/3] mm: handling Non-LRU pages returned by follow_page
Date: Sun, 14 Aug 2022 22:05:34 +0800	[thread overview]
Message-ID: <20220814140534.363348-4-haiyue.wang@intel.com> (raw)
In-Reply-To: <20220814140534.363348-1-haiyue.wang@intel.com>

Add the missed put_page handling for handling Non-LRU pages returned by
follow_page with FOLL_GET flag set.

This is the second patch for fixing the commit
3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages")

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 mm/huge_memory.c |  2 +-
 mm/ksm.c         | 10 ++++++++++
 mm/migrate.c     |  6 +++++-
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 2ee6d38a1426..b2ba17c3dcd7 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2966,7 +2966,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start,
 		if (IS_ERR_OR_NULL(page))
 			continue;
 
-		if (!is_transparent_hugepage(page))
+		if (is_zone_device_page(page) || !is_transparent_hugepage(page))
 			goto next;
 
 		total++;
diff --git a/mm/ksm.c b/mm/ksm.c
index fe3e0a39f73a..1360bb52ada6 100644
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -477,6 +477,10 @@ static int break_ksm(struct vm_area_struct *vma, unsigned long addr)
 				FOLL_GET | FOLL_MIGRATION | FOLL_REMOTE);
 		if (IS_ERR_OR_NULL(page))
 			break;
+		if (is_zone_device_page(page)) {
+			put_page(page);
+			break;
+		}
 		if (PageKsm(page))
 			ret = handle_mm_fault(vma, addr,
 					      FAULT_FLAG_WRITE | FAULT_FLAG_REMOTE,
@@ -562,10 +566,13 @@ static struct page *get_mergeable_page(struct rmap_item *rmap_item)
 	page = follow_page(vma, addr, FOLL_GET);
 	if (IS_ERR_OR_NULL(page))
 		goto out;
+	if (is_zone_device_page(page))
+		goto out_putpage;
 	if (PageAnon(page)) {
 		flush_anon_page(vma, page, addr);
 		flush_dcache_page(page);
 	} else {
+out_putpage:
 		put_page(page);
 out:
 		page = NULL;
@@ -2313,6 +2320,8 @@ static struct rmap_item *scan_get_next_rmap_item(struct page **page)
 				cond_resched();
 				continue;
 			}
+			if (is_zone_device_page(*page))
+				goto next_page;
 			if (PageAnon(*page)) {
 				flush_anon_page(vma, *page, ksm_scan.address);
 				flush_dcache_page(*page);
@@ -2327,6 +2336,7 @@ static struct rmap_item *scan_get_next_rmap_item(struct page **page)
 				mmap_read_unlock(mm);
 				return rmap_item;
 			}
+next_page:
 			put_page(*page);
 			ksm_scan.address += PAGE_SIZE;
 			cond_resched();
diff --git a/mm/migrate.c b/mm/migrate.c
index 5d304de3950b..fee12cd2f294 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1675,6 +1675,9 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
 	if (!page)
 		goto out;
 
+	if (is_zone_device_page(page))
+		goto out_putpage;
+
 	err = 0;
 	if (page_to_nid(page) == node)
 		goto out_putpage;
@@ -1869,7 +1872,8 @@ static void do_pages_stat_array(struct mm_struct *mm, unsigned long nr_pages,
 			goto set_status;
 
 		if (page) {
-			err = page_to_nid(page);
+			err = !is_zone_device_page(page) ? page_to_nid(page)
+							 : -ENOENT;
 			if (foll_flags & FOLL_GET)
 				put_page(page);
 		} else {
-- 
2.37.2



  parent reply	other threads:[~2022-08-14 14:05 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  8:49 [PATCH v1] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-13 23:28 ` Andrew Morton
2022-08-14  6:20   ` Wang, Haiyue
2022-08-14  6:49     ` Wang, Haiyue
2022-08-14 14:05 ` [PATCH v2 0/3] fix follow_page related issues Haiyue Wang
2022-08-14 14:05   ` [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-14 16:30     ` David Hildenbrand
2022-08-15  1:02       ` Wang, Haiyue
2022-08-14 14:05   ` [PATCH v2 2/3] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-14 14:05   ` Haiyue Wang [this message]
2022-08-14 16:34     ` [PATCH v2 3/3] mm: handling Non-LRU pages returned by follow_page David Hildenbrand
2022-08-15  1:03       ` Wang, Haiyue
2022-08-15  1:03 ` [PATCH v3 0/2] fix follow_page related issues Haiyue Wang
2022-08-15  1:03   ` [PATCH v3 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15  1:59     ` Huang, Ying
2022-08-15  2:10       ` Wang, Haiyue
2022-08-15  2:15         ` Wang, Haiyue
2022-08-15  2:51           ` Huang, Ying
2022-08-15  1:03   ` [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15  1:39     ` Huang, Ying
2022-08-15  1:46       ` Wang, Haiyue
2022-08-15  1:59 ` [PATCH v4 0/2] fix follow_page related issues Haiyue Wang
2022-08-15  1:59   ` [PATCH v4 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15  4:28     ` Alistair Popple
2022-08-15  4:40       ` Wang, Haiyue
2022-08-15  5:16         ` Alistair Popple
2022-08-15  5:20           ` Wang, Haiyue
2022-08-15  5:35             ` Alistair Popple
2022-08-15  5:37               ` Wang, Haiyue
2022-08-15  1:59   ` [PATCH v4 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15  7:02 ` [PATCH v5 0/2] fix follow_page related issues Haiyue Wang
2022-08-15  7:02   ` [PATCH v5 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-15  7:40     ` Huang, Ying
2022-08-15  7:02   ` [PATCH v5 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-15  7:50     ` Huang, Ying
2022-08-15 14:28     ` Felix Kuehling
2022-08-16  0:00     ` Alistair Popple
2022-08-16  1:12       ` Wang, Haiyue
2022-08-16  2:45         ` Alistair Popple
2022-08-16  2:20 ` [PATCH v6 0/2] fix follow_page related issues Haiyue Wang
2022-08-16  2:21   ` [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on following huge page Haiyue Wang
2022-08-16  8:54     ` Baolin Wang
2022-08-17  0:58     ` Andrew Morton
2022-08-17  3:31       ` Wang, Haiyue
2022-08-17  5:43         ` Andrew Morton
2022-08-17  5:47           ` Wang, Haiyue
2022-08-17 17:26           ` Mike Kravetz
2022-08-17 21:58             ` Mike Kravetz
2022-08-18  0:32               ` Wang, Haiyue
2022-08-19 11:22             ` Michael Ellerman
2022-08-19 16:55               ` Mike Kravetz
2022-08-26 13:07                 ` Michael Ellerman
2022-08-18 11:51           ` Gerald Schaefer
2022-08-18 11:57             ` Gerald Schaefer
2022-08-17  2:12     ` Miaohe Lin
2022-08-16  2:21   ` [PATCH v6 2/2] mm: fix the handling Non-LRU pages returned by follow_page Haiyue Wang
2022-08-16  4:42     ` Alistair Popple
2022-08-17  2:34     ` Miaohe Lin
2022-08-23 10:07       ` David Hildenbrand
2022-08-23 13:26         ` Wang, Haiyue
2022-08-23 13:27           ` David Hildenbrand
2022-08-23 13:29             ` Wang, Haiyue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220814140534.363348-4-haiyue.wang@intel.com \
    --to=haiyue.wang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.sierra@amd.com \
    --cc=david@redhat.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@linux.dev \
    --cc=songmuchun@bytedance.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox