From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80CDCC00140 for ; Fri, 12 Aug 2022 15:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 067CF6B0078; Fri, 12 Aug 2022 11:48:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 018448E0002; Fri, 12 Aug 2022 11:48:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21FB8E0001; Fri, 12 Aug 2022 11:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D066E6B0078 for ; Fri, 12 Aug 2022 11:48:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 95C3B81CD6 for ; Fri, 12 Aug 2022 15:48:47 +0000 (UTC) X-FDA: 79791373494.22.8FC1E8B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 0D0D880190 for ; Fri, 12 Aug 2022 15:48:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C0FBB8246D; Fri, 12 Aug 2022 15:48:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDBE9C433D6; Fri, 12 Aug 2022 15:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660319323; bh=cvTUSPVXoJaKfemksKrV/He9kW2/6kMVns4u0Rjwb4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUYmnY7lanhhpzrJoziQyLihzTxMt1xP5p04ujfx9cyJTKP8DcRnUv3+Bak3+/Gfd HNHcoqnH2AYZ2+ZlCtR5LuNDF22Uq5TfeYgta0c6W56u5j8b2yHddNaFDilRT+KCVQ 6CpsM9ZSQyDzWs27m6VDnF2ZhuoJJjhZn8tuGX4MUSQJz1emqpFfUC3mkxgXokTXBe j4Qv8zDzfv8vHJtWyOrkVruGH8U3Fa+Q4wzcwtwHbQP2BWMXtkPEM6gap1robX1Y8a 4U3/01qg7xdenf+PK2QRF+msgtnwAmS1TeiO7U9MMhhwG4KANZZHCKWA3SSETVCOOI 9ytSxCl8WKlQQ== From: SeongJae Park To: xiakaixu1987@gmail.com Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation Date: Fri, 12 Aug 2022 15:48:41 +0000 Message-Id: <20220812154841.116570-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1660290073-26347-1-git-send-email-kaixuxia@tencent.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660319326; a=rsa-sha256; cv=none; b=TH9WnneirNp+y0jdRszCIV+UGvQWYfLt1tmZs4K+VR/Rts8z5UzMblyC+Hws9iZnwvegZq vna06mpkPQ2uNv7pgmsOVYOwtrrot06IR69wSn9xW1M3pRjCL2BTWGmt5StOBlLX+ZTrYG 62Rnc/4WKrP8NaXZgXTT9AqG1KNpIFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660319326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hqEf11FJbSRO12gzNjyGGnzzu3Dh13mZ7Ss/ZM/qt3w=; b=F1eh8ZY96h4fa4Zg8FKWhda6lN+qPDHu1GHUhXA9E7fVyZdquCWIebWUfrCGUnRcNjip0H ZJVlrt82xA3D2VQAzJM7u3yt6Vm2Fm+LmePtRDGkTxBMxRsAjBYgeKKsvDEQrNqIadD3vo mV7bvZqvJVbGfm/eFrNyjkmw7MTFQXU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QUYmnY7l; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: i1uxiuge847fjhibtbxe59bhzedzhwxp X-Rspamd-Queue-Id: 0D0D880190 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QUYmnY7l; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1660319325-783103 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000321, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kaixu, On Fri, 12 Aug 2022 15:41:13 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The parameter 'struct damon_target *t' is unnecessary in damon region > split operation, so we can remove it. Good finding. But, 't' is used while 'ctx' is unused in 'damon_split_region_at()' and 'damon_split_regions_of'. Below code change is also removing 'ctx', not 't'. Could you please update the commit message for that? Also, please fix the kernel test robot reported issues together: https://lore.kernel.org/damon/202208121823.8YTRPB1J-lkp@intel.com/ Thanks, SJ [...]