From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869D1C25B0F for ; Fri, 12 Aug 2022 08:21:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABD406B0073; Fri, 12 Aug 2022 04:21:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6CAA6B0075; Fri, 12 Aug 2022 04:21:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B6C8E0001; Fri, 12 Aug 2022 04:21:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 835636B0073 for ; Fri, 12 Aug 2022 04:21:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5071B1608DA for ; Fri, 12 Aug 2022 08:21:03 +0000 (UTC) X-FDA: 79790245206.07.F71307C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id DFB7C40197 for ; Fri, 12 Aug 2022 08:21:02 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF11060BA0; Fri, 12 Aug 2022 08:21:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E563C433D7; Fri, 12 Aug 2022 08:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660292461; bh=uAdZ2mX9autS/TPR3fwjWPumvc0LXFJUv+fe7PHSj5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXGP1rYB3XPG3JK+tTB4qp9MTOdoPA+XUGl1ueCLJaBe7UQGhA4fk9gJpsUCOTR90 GXEGs/Pr/rhCcgoW0Fz61plmIqrwiE0dCbtHTOvClIiHWKXYdpukSiVejlbYv+V/nR 5y668gf1B2AiKQqBMgwZXTOmZ/S+CfjOhtbX6CYqZ2pHYSNriai3gmaC99TNTEKWgF SC6Z0TYJOgadBtiLWQS2EE4HHHaj240DZh8TZho9AKlKxoQDgMx5UmFSUJrQFPnTEt tyhYP2gLWArYX8S9nnLzbebo+Y7bgk+rXIAeqvAZWca1VvqKJpdptpv5BxJLDp8sH8 f5a+hZ9T4a80A== Date: Fri, 12 Aug 2022 10:20:56 +0200 From: Christian Brauner To: Hugh Dickins Cc: Andrew Morton , "Darrick J. Wong" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/shmem: tmpfs fallocate use file_modified() Message-ID: <20220812082056.2khjud7dme3yc6nn@wittgenstein> References: <39c5e62-4896-7795-c0a0-f79c50d4909@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39c5e62-4896-7795-c0a0-f79c50d4909@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660292463; a=rsa-sha256; cv=none; b=zIomhLahsklVBaI2bL9zND/KWAXRf+/xZ514dE6QTQIDS8n6QGKtSZPJrIG/hattPfE4Al MTjTAh0DO7yE7JQqnx0cJ/s5GVhWNbFsCiQX5ifbd3ZVzkMpGMK5mJ97/sSE0WIAYJxNSN 8//4TDVPi1ykjV8GSxFT2ByHPCVRekU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660292463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nmbAxGSz0nfEZBst3j9kqs3YCEVr0RBEuyo9uhx6QzY=; b=TSKkdP8Yf4HKQuGv+Ne1nMaI3F/ogDAN40HILklHaWMiqJIeviaNN/LAhzTOBn+V1nV9gs IS5W7aa2kJRQrmsQyhzgb8FbmHk/wY4NNvgB1UYAj1GhfRlVa+BQ29YTDoQitcsLmrlnvq o2e7mupPC/F1WXd6FSwWcW5h1AUvwkc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IXGP1rYB; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: gawnn36cz54hw63ucywbfm6x431puruy X-Rspamd-Queue-Id: DFB7C40197 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IXGP1rYB; spf=pass (imf12.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1660292462-926198 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 10, 2022 at 09:55:36PM -0700, Hugh Dickins wrote: > 5.18 fixed the btrfs and ext4 fallocates to use file_modified(), as xfs > was already doing, to drop privileges: and fstests generic/{683,684,688} > expect this. There's no need to argue over keep-size allocation (which > could just update ctime): fix shmem_fallocate() to behave the same way. > > Signed-off-by: Hugh Dickins > --- Looks good to me, Acked-by: Christian Brauner (Microsoft)