linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Wei Xu <weixugc@google.com>, Huang Ying <ying.huang@intel.com>,
	Yang Shi <shy828301@gmail.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Tim C Chen <tim.c.chen@intel.com>,
	Michal Hocko <mhocko@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Hesham Almatary <hesham.almatary@huawei.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Alistair Popple <apopple@nvidia.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	jvgediya.oss@gmail.com, Bharata B Rao <bharata@amd.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: [PATCH v14 10/10] lib/nodemask: Optimize node_random for nodemask with single NUMA node
Date: Fri, 12 Aug 2022 11:27:09 +0530	[thread overview]
Message-ID: <20220812055710.357820-11-aneesh.kumar@linux.ibm.com> (raw)
In-Reply-To: <20220812055710.357820-1-aneesh.kumar@linux.ibm.com>

The most common case for certain node_random usage (demotion nodemask) is with
nodemask weight 1. We can avoid calling get_random_init() in that case and
always return the only node set in the nodemask.

A simple test as below
  before = rdtsc_ordered();
  for (i= 0; i < 100; i++) {
      rand = node_random(&nmask);
  }
  after = rdtsc_ordered();

Without fix after - before : 16438
With fix after - before : 816

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
 include/linux/nodemask.h | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
index 4b71a96190a8..ac5b6a371be5 100644
--- a/include/linux/nodemask.h
+++ b/include/linux/nodemask.h
@@ -504,12 +504,21 @@ static inline int num_node_state(enum node_states state)
 static inline int node_random(const nodemask_t *maskp)
 {
 #if defined(CONFIG_NUMA) && (MAX_NUMNODES > 1)
-	int w, bit = NUMA_NO_NODE;
+	int w, bit;
 
 	w = nodes_weight(*maskp);
-	if (w)
+	switch (w) {
+	case 0:
+		bit = NUMA_NO_NODE;
+		break;
+	case 1:
+		bit = first_node(*maskp);
+		break;
+	default:
 		bit = bitmap_ord_to_pos(maskp->bits,
-			get_random_int() % w, MAX_NUMNODES);
+					get_random_int() % w, MAX_NUMNODES);
+		break;
+	}
 	return bit;
 #else
 	return 0;
-- 
2.37.1



  parent reply	other threads:[~2022-08-12  5:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  5:56 [PATCH v14 00/10] mm/demotion: Memory tiers and demotion Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 01/10] mm/demotion: Add support for explicit memory tiers Aneesh Kumar K.V
2022-08-16  8:28   ` huang ying
2022-08-12  5:57 ` [PATCH v14 02/10] mm/demotion: Move memory demotion related code Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 03/10] mm/demotion: Add hotplug callbacks to handle new numa node onlined Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 04/10] mm/demotion/dax/kmem: Set node's abstract distance to MEMTIER_DEFAULT_DAX_ADISTANCE Aneesh Kumar K.V
2022-08-15  2:25   ` Huang, Ying
2022-08-15  2:39   ` Huang, Ying
2022-08-16  5:09     ` Aneesh Kumar K V
2022-08-16  7:28       ` huang ying
2022-08-16  8:12         ` Bharata B Rao
2022-08-16  8:26           ` huang ying
2022-08-16 14:45             ` Bharata B Rao
2022-08-17  1:02               ` Huang, Ying
2022-08-12  5:57 ` [PATCH v14 05/10] mm/demotion: Build demotion targets based on explicit memory tiers Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 06/10] mm/demotion: Add pg_data_t member to track node memory tier details Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 07/10] mm/demotion: Drop memtier from memtype Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 08/10] mm/demotion: Demote pages according to allocation fallback order Aneesh Kumar K.V
2022-08-12  5:57 ` [PATCH v14 09/10] mm/demotion: Update node_is_toptier to work with memory tiers Aneesh Kumar K.V
2022-08-12  5:57 ` Aneesh Kumar K.V [this message]
2022-08-15  2:49 ` [PATCH v14 00/10] mm/demotion: Memory tiers and demotion Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220812055710.357820-11-aneesh.kumar@linux.ibm.com \
    --to=aneesh.kumar@linux.ibm.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=bharata@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave@stgolabs.net \
    --cc=hannes@cmpxchg.org \
    --cc=hesham.almatary@huawei.com \
    --cc=jvgediya.oss@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shy828301@gmail.com \
    --cc=tim.c.chen@intel.com \
    --cc=weixugc@google.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox