From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647C4C25B0D for ; Thu, 11 Aug 2022 15:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD4546B0073; Thu, 11 Aug 2022 11:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D84598E0002; Thu, 11 Aug 2022 11:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4CB98E0001; Thu, 11 Aug 2022 11:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B2F436B0073 for ; Thu, 11 Aug 2022 11:38:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A8D9A5D3F for ; Thu, 11 Aug 2022 15:38:09 +0000 (UTC) X-FDA: 79787717898.18.AD4A112 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 84C0D4017A for ; Thu, 11 Aug 2022 15:38:07 +0000 (UTC) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id B797E5FD04; Thu, 11 Aug 2022 18:38:05 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1660232285; bh=5w4LerBx6pluL5hWSjCUy6U5aknGE0ymDNztcNBibbY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Tckq2EtgEiZUvdQAO1p+MllsNXNcoXG7HQ7THmKvR8j80dK3KOQ+fqTct2640cvSc 1ufqAlnlY3OqHDKZVJEjQVLcLuA3A5qnsl7RklR+VXCYgWnQ3nh4p1XqsgYwcoSb+Y MKt/B0cRILv39RTH9wpxae0Ao7FKbIsYnejEcvGA199wEj9m/TjZIjofStB3Rzk1jR bwFbr9rjxv/mp/gDQRd2j+um3vc21AMSWnt2foacexSb9tUspZDlN/LoWbsRr3tgNQ fdQjcAdA4E56wjml1fYDBPBOQNYeUFPgIfy5flVYZEJHTqyj9UpuDyZtPQt+vHIZzd jTACYe0T/BzAQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Thu, 11 Aug 2022 18:38:04 +0300 (MSK) From: Alexey Romanov To: , , , CC: , , , Alexey Romanov Subject: [PATCH v1 0/2] tidy up zsmalloc implementation Date: Thu, 11 Aug 2022 18:37:53 +0300 Message-ID: <20220811153755.16102-1-avromanov@sberdevices.ru> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/08/11 13:20:00 #20096813 X-KSMG-AntiVirus-Status: Clean, skipped ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660232288; a=rsa-sha256; cv=none; b=Vr+Y35r12xujD5h3rDCRtDNfFU/YW03iVIVRu0/lTY0Mox0G7XVsxo1356KrzWyOV+Ceq0 uTWYQrHw9bOv6Rcl4c6UTQ9WumoE9hQ6yOaXU6osUENM9OjqxEt+dFFyGTwsfukl6jsy5p 0gXqKTsY3y3ftCdMH713Vfi1fsVkEBM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=Tckq2Etg; spf=pass (imf04.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660232288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5w4LerBx6pluL5hWSjCUy6U5aknGE0ymDNztcNBibbY=; b=nDjZWF3hZwXDcotY81JgqPZoDq/9XMDgg4kQd3Z0HzVCFdZj0qMkKFoqkuEnifaOp86GLl cp2eHrOVvwsMmpoluOHMAliZNy3+rGa+4KHQk7ih48jmXCJKJIlYyZ6SS+7AwlT5Vry+b7 3N6ZI+5A6bDqcQl1VqU/A1nuRijjjBs= X-Stat-Signature: kd8q5g1txzh9axj87nikiofuepybfeoi X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 84C0D4017A Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=sberdevices.ru header.s=mail header.b=Tckq2Etg; spf=pass (imf04.hostedemail.com: domain of AVRomanov@sberdevices.ru designates 45.89.227.171 as permitted sender) smtp.mailfrom=AVRomanov@sberdevices.ru; dmarc=pass (policy=quarantine) header.from=sberdevices.ru X-Rspam-User: X-HE-Tag: 1660232287-314031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! This patchset remove some unnecessary checks and adds clarifying comment. While analysis zs_object_copy() function code, I spent some time to understand what the call kunmap_atomic(d_addr) is for. It seems that this point is not trivial and it is worth adding a comment. Alexey Romanov (2): zsmalloc: zs_object_copy: add clarifying comment zsmalloc: remove unnecessary size_class NULL check mm/zsmalloc.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) -- 2.30.1